[{"id":30647,"web_url":"https://patchwork.libcamera.org/comment/30647/","msgid":"","date":"2024-08-07T08:37:39","subject":"Re: [PATCH v5 10/18] libcamera: Consolidate all IPA headers in\n\tlibcamera_ipa_headers","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Laurent\n\nOn 05/08/2024 15:36, Laurent Pinchart wrote:\n> The IPA headers are listed in two different meson variables, one for\n> generated headers, and one for the other headers. There's no real reason\n> for this split, consolidate all of them in the libcamera_ipa_headers\n> variable.\n>\n> While at it, don't add the IPA headers to the libcamera_internal_sources\n> variable, but list libcamera_ipa_headers in the sources for the shared\n> library. This moves the libcamera_internal_sources variable towards\n> holding source files, not header files, to improve clarity of the build\n> system.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\nReviewed-by: Daniel Scally \n> include/libcamera/ipa/meson.build | 8 +++-----\n> src/libcamera/meson.build | 3 +--\n> 2 files changed, 4 insertions(+), 7 deletions(-)\n>\n> diff --git a/include/libcamera/ipa/meson.build b/include/libcamera/ipa/meson.build\n> index 3352d08fbd98..96fca42cc0b8 100644\n> --- a/include/libcamera/ipa/meson.build\n> +++ b/include/libcamera/ipa/meson.build\n> @@ -11,8 +11,6 @@ libcamera_ipa_headers = files([\n> install_headers(libcamera_ipa_headers,\n> subdir : libcamera_ipa_include_dir)\n> \n> -libcamera_generated_ipa_headers = []\n> -\n> ipa_headers_install_dir = get_option('includedir') / libcamera_ipa_include_dir\n> \n> #\n> @@ -31,7 +29,7 @@ ipa_mojom_core = custom_target(core_mojom_file.split('.')[0] + '_mojom_module',\n> ])\n> \n> # core_ipa_interface.h\n> -libcamera_generated_ipa_headers += custom_target('core_ipa_interface_h',\n> +libcamera_ipa_headers += custom_target('core_ipa_interface_h',\n> input : ipa_mojom_core,\n> output : 'core_ipa_interface.h',\n> depends : mojom_templates,\n> @@ -47,7 +45,7 @@ libcamera_generated_ipa_headers += custom_target('core_ipa_interface_h',\n> ])\n> \n> # core_ipa_serializer.h\n> -libcamera_generated_ipa_headers += custom_target('core_ipa_serializer_h',\n> +libcamera_ipa_headers += custom_target('core_ipa_serializer_h',\n> input : ipa_mojom_core,\n> output : 'core_ipa_serializer.h',\n> depends : mojom_templates,\n> @@ -152,7 +150,7 @@ foreach pipeline, file : pipeline_ipa_mojom_mapping\n> 'mojom': mojom,\n> }\n> \n> - libcamera_generated_ipa_headers += [header, serializer, proxy_header]\n> + libcamera_ipa_headers += [header, serializer, proxy_header]\n> endforeach\n> \n> ipa_mojom_files = []\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 61a97c738ae8..86e8b88cc1b2 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -55,7 +55,6 @@ libcamera_internal_sources = files([\n> ])\n> \n> libcamera_public_sources += libcamera_public_headers\n> -libcamera_internal_sources += libcamera_generated_ipa_headers\n> libcamera_internal_sources += libcamera_tracepoint_header\n> \n> includes = [\n> @@ -196,6 +195,7 @@ libcamera_deps += [\n> libcamera = shared_library('libcamera',\n> [\n> libcamera_public_sources,\n> + libcamera_ipa_headers,\n> libcamera_internal_sources,\n> ],\n> version : libcamera_version,\n> @@ -216,7 +216,6 @@ libcamera_public = declare_dependency(sources : [\n> # Internal dependency for components and plugins which can use private APIs\n> libcamera_private = declare_dependency(sources : [\n> libcamera_ipa_headers,\n> - libcamera_generated_ipa_headers,\n> ],\n> dependencies : [\n> libcamera_public,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4D532C323E\n\tfor ;\n\tWed, 7 Aug 2024 08:37:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ED89463393;\n\tWed, 7 Aug 2024 10:37:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B849F61946\n\tfor ;\n\tWed, 7 Aug 2024 10:37:41 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 270E66AF\n\tfor ;\n\tWed, 7 Aug 2024 10:36:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Yvo333uO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723019809;\n\tbh=n0pXOz+e73jWqQx94IkXCIOvVcHV+ix6qS5UXCc2/Sg=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=Yvo333uOAtXa3hrlWnWaOczn5oM/II8ebByVvObp+/8OxiuZ8uLVtSF3mCTsV19UA\n\t2aPPxb1PpyoLbmyPG3GCdmWBj+C3MfQcM1UuCe+e7Iezq6Y7zmiAI8sHNUyX0lKIW/\n\t7g7T8rBj3gbETevXNXE6D7aZYwFhRRiGyYpyRxbw=","Message-ID":"","Date":"Wed, 7 Aug 2024 09:37:39 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v5 10/18] libcamera: Consolidate all IPA headers in\n\tlibcamera_ipa_headers","To":"libcamera-devel@lists.libcamera.org","References":"<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>\n\t<20240805143654.20870-11-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240805143654.20870-11-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30664,"web_url":"https://patchwork.libcamera.org/comment/30664/","msgid":"<172302928072.1687952.1369989332500885493@ping.linuxembedded.co.uk>","date":"2024-08-07T11:14:40","subject":"Re: [PATCH v5 10/18] libcamera: Consolidate all IPA headers in\n\tlibcamera_ipa_headers","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-08-05 15:36:46)\n> The IPA headers are listed in two different meson variables, one for\n> generated headers, and one for the other headers. There's no real reason\n> for this split, consolidate all of them in the libcamera_ipa_headers\n> variable.\n> \n> While at it, don't add the IPA headers to the libcamera_internal_sources\n> variable, but list libcamera_ipa_headers in the sources for the shared\n> library. This moves the libcamera_internal_sources variable towards\n> holding source files, not header files, to improve clarity of the build\n> system.\n\nLooks reasonable indeed! One less variable to track.\n\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/ipa/meson.build | 8 +++-----\n> src/libcamera/meson.build | 3 +--\n> 2 files changed, 4 insertions(+), 7 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/meson.build b/include/libcamera/ipa/meson.build\n> index 3352d08fbd98..96fca42cc0b8 100644\n> --- a/include/libcamera/ipa/meson.build\n> +++ b/include/libcamera/ipa/meson.build\n> @@ -11,8 +11,6 @@ libcamera_ipa_headers = files([\n> install_headers(libcamera_ipa_headers,\n> subdir : libcamera_ipa_include_dir)\n> \n> -libcamera_generated_ipa_headers = []\n> -\n> ipa_headers_install_dir = get_option('includedir') / libcamera_ipa_include_dir\n> \n> #\n> @@ -31,7 +29,7 @@ ipa_mojom_core = custom_target(core_mojom_file.split('.')[0] + '_mojom_module',\n> ])\n> \n> # core_ipa_interface.h\n> -libcamera_generated_ipa_headers += custom_target('core_ipa_interface_h',\n> +libcamera_ipa_headers += custom_target('core_ipa_interface_h',\n> input : ipa_mojom_core,\n> output : 'core_ipa_interface.h',\n> depends : mojom_templates,\n> @@ -47,7 +45,7 @@ libcamera_generated_ipa_headers += custom_target('core_ipa_interface_h',\n> ])\n> \n> # core_ipa_serializer.h\n> -libcamera_generated_ipa_headers += custom_target('core_ipa_serializer_h',\n> +libcamera_ipa_headers += custom_target('core_ipa_serializer_h',\n> input : ipa_mojom_core,\n> output : 'core_ipa_serializer.h',\n> depends : mojom_templates,\n> @@ -152,7 +150,7 @@ foreach pipeline, file : pipeline_ipa_mojom_mapping\n> 'mojom': mojom,\n> }\n> \n> - libcamera_generated_ipa_headers += [header, serializer, proxy_header]\n> + libcamera_ipa_headers += [header, serializer, proxy_header]\n> endforeach\n> \n> ipa_mojom_files = []\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 61a97c738ae8..86e8b88cc1b2 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -55,7 +55,6 @@ libcamera_internal_sources = files([\n> ])\n> \n> libcamera_public_sources += libcamera_public_headers\n> -libcamera_internal_sources += libcamera_generated_ipa_headers\n> libcamera_internal_sources += libcamera_tracepoint_header\n> \n> includes = [\n> @@ -196,6 +195,7 @@ libcamera_deps += [\n> libcamera = shared_library('libcamera',\n> [\n> libcamera_public_sources,\n> + libcamera_ipa_headers,\n> libcamera_internal_sources,\n> ],\n> version : libcamera_version,\n> @@ -216,7 +216,6 @@ libcamera_public = declare_dependency(sources : [\n> # Internal dependency for components and plugins which can use private APIs\n> libcamera_private = declare_dependency(sources : [\n> libcamera_ipa_headers,\n> - libcamera_generated_ipa_headers,\n> ],\n> dependencies : [\n> libcamera_public,\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64107C323E\n\tfor ;\n\tWed, 7 Aug 2024 11:14:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B1066338D;\n\tWed, 7 Aug 2024 13:14:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2FF6963382\n\tfor ;\n\tWed, 7 Aug 2024 13:14:44 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5C6366AF;\n\tWed, 7 Aug 2024 13:13:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CCD7LVGZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723029231;\n\tbh=CzKseuA2D2c8H3SvbDvIuefEeSnQ6fCkzy9PRkOq8v0=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=CCD7LVGZBOBbo+zyqXRIeikLHrfcSnZceiBy6Za7QmN3jiOZCPZuGiHrx9u4pJNKB\n\tNf12F3PbkzvrMD8WT8xWbCtVmYylvXc8Hu0Ka0qVDTh+xmGOTo+BzqdC5D6tyIp2rt\n\thcpqvDiDhERzyWusO7Ws2rec6BBvFpXlLkAg7pyA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240805143654.20870-11-laurent.pinchart@ideasonboard.com>","References":"<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>\n\t<20240805143654.20870-11-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH v5 10/18] libcamera: Consolidate all IPA headers in\n\tlibcamera_ipa_headers","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 07 Aug 2024 12:14:40 +0100","Message-ID":"<172302928072.1687952.1369989332500885493@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]