[{"id":30634,"web_url":"https://patchwork.libcamera.org/comment/30634/","msgid":"","date":"2024-08-06T15:12:42","subject":"Re: [PATCH v5 08/18] libcamera: Drop libcamera_generated_ipa_headers\n\tfrom sources","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Laurent\n\nOn 05/08/2024 15:36, Laurent Pinchart wrote:\n> The libcamera_generated_ipa_headers variable, containing the list of\n> generated IPA headers, is listed in the sources of IPA modules, as well\n> as IPA tests. This was done to ensure that the modules and tests get\n> rebuilt when the generate IPA headers change. However, the dependency is\n> already handled through the libcamera_private dependency object,\n> specified for all those modules and tests. There's no need to list the\n> IPA generated headers as sources. Drop them.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n\nHow did you catch that one too?\n\n\nReviewed-by: Daniel Scally \n\n> src/ipa/ipu3/meson.build | 3 +--\n> src/ipa/rkisp1/meson.build | 3 +--\n> src/ipa/rpi/vc4/meson.build | 3 +--\n> src/ipa/simple/meson.build | 3 +--\n> src/ipa/vimc/meson.build | 3 +--\n> src/libcamera/proxy/worker/meson.build | 3 +--\n> test/ipa/meson.build | 2 +-\n> test/ipa/rkisp1/meson.build | 2 +-\n> 8 files changed, 8 insertions(+), 14 deletions(-)\n>\n> diff --git a/src/ipa/ipu3/meson.build b/src/ipa/ipu3/meson.build\n> index e76f97c07c87..34de6213aa83 100644\n> --- a/src/ipa/ipu3/meson.build\n> +++ b/src/ipa/ipu3/meson.build\n> @@ -12,8 +12,7 @@ ipu3_ipa_sources = files([\n> \n> ipu3_ipa_sources += ipu3_ipa_algorithms\n> \n> -mod = shared_module(ipa_name,\n> - [ipu3_ipa_sources, libcamera_generated_ipa_headers],\n> +mod = shared_module(ipa_name, ipu3_ipa_sources,\n> name_prefix : '',\n> include_directories : [ipa_includes],\n> dependencies : [libcamera_private, libipa_dep],\n> diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build\n> index e8b266f1ccca..160ef52dd52e 100644\n> --- a/src/ipa/rkisp1/meson.build\n> +++ b/src/ipa/rkisp1/meson.build\n> @@ -13,8 +13,7 @@ rkisp1_ipa_sources = files([\n> \n> rkisp1_ipa_sources += rkisp1_ipa_algorithms\n> \n> -mod = shared_module(ipa_name,\n> - [rkisp1_ipa_sources, libcamera_generated_ipa_headers],\n> +mod = shared_module(ipa_name, rkisp1_ipa_sources,\n> name_prefix : '',\n> include_directories : [ipa_includes],\n> dependencies : [libcamera_private, libipa_dep],\n> diff --git a/src/ipa/rpi/vc4/meson.build b/src/ipa/rpi/vc4/meson.build\n> index 63fc5925b06c..c10fa17e1ba4 100644\n> --- a/src/ipa/rpi/vc4/meson.build\n> +++ b/src/ipa/rpi/vc4/meson.build\n> @@ -23,8 +23,7 @@ vc4_ipa_sources = files([\n> \n> vc4_ipa_includes += include_directories('..')\n> \n> -mod = shared_module(ipa_name,\n> - [vc4_ipa_sources, libcamera_generated_ipa_headers],\n> +mod = shared_module(ipa_name, vc4_ipa_sources,\n> name_prefix : '',\n> include_directories : vc4_ipa_includes,\n> dependencies : [vc4_ipa_deps, libipa_dep],\n> diff --git a/src/ipa/simple/meson.build b/src/ipa/simple/meson.build\n> index 33d1c96aa4f2..b297e1d2e677 100644\n> --- a/src/ipa/simple/meson.build\n> +++ b/src/ipa/simple/meson.build\n> @@ -7,8 +7,7 @@ soft_simple_sources = files([\n> 'black_level.cpp',\n> ])\n> \n> -mod = shared_module(ipa_name,\n> - [soft_simple_sources, libcamera_generated_ipa_headers],\n> +mod = shared_module(ipa_name, soft_simple_sources,\n> name_prefix : '',\n> include_directories : [ipa_includes],\n> dependencies : [libcamera_private, libipa_dep],\n> diff --git a/src/ipa/vimc/meson.build b/src/ipa/vimc/meson.build\n> index d0b63eddd5f6..2cc5f80b0b69 100644\n> --- a/src/ipa/vimc/meson.build\n> +++ b/src/ipa/vimc/meson.build\n> @@ -2,8 +2,7 @@\n> \n> ipa_name = 'ipa_vimc'\n> \n> -mod = shared_module(ipa_name,\n> - ['vimc.cpp', libcamera_generated_ipa_headers],\n> +mod = shared_module(ipa_name, 'vimc.cpp',\n> name_prefix : '',\n> include_directories : [ipa_includes],\n> dependencies : [libcamera_private, libipa_dep],\n> diff --git a/src/libcamera/proxy/worker/meson.build b/src/libcamera/proxy/worker/meson.build\n> index aa4d9cd7b5d8..b5ab9794c622 100644\n> --- a/src/libcamera/proxy/worker/meson.build\n> +++ b/src/libcamera/proxy/worker/meson.build\n> @@ -17,8 +17,7 @@ foreach mojom : ipa_mojoms\n> './' + '@INPUT@'\n> ])\n> \n> - proxy = executable(mojom['name'] + '_ipa_proxy',\n> - [worker, libcamera_generated_ipa_headers],\n> + proxy = executable(mojom['name'] + '_ipa_proxy', worker,\n> install : true,\n> install_dir : proxy_install_dir,\n> dependencies : libcamera_private)\n> diff --git a/test/ipa/meson.build b/test/ipa/meson.build\n> index fe21ca58b64f..e9871aba44ee 100644\n> --- a/test/ipa/meson.build\n> +++ b/test/ipa/meson.build\n> @@ -8,7 +8,7 @@ ipa_test = [\n> ]\n> \n> foreach test : ipa_test\n> - exe = executable(test['name'], test['sources'], libcamera_generated_ipa_headers,\n> + exe = executable(test['name'], test['sources'],\n> dependencies : [libcamera_private, libipa_dep],\n> link_with : [test_libraries],\n> include_directories : [test_includes_internal])\n> diff --git a/test/ipa/rkisp1/meson.build b/test/ipa/rkisp1/meson.build\n> index 5b08e2939ce6..894523daf76b 100644\n> --- a/test/ipa/rkisp1/meson.build\n> +++ b/test/ipa/rkisp1/meson.build\n> @@ -5,7 +5,7 @@ rkisp1_ipa_test = [\n> ]\n> \n> foreach test : rkisp1_ipa_test\n> - exe = executable(test['name'], test['sources'], libcamera_generated_ipa_headers,\n> + exe = executable(test['name'], test['sources'],\n> dependencies : [libcamera_private, libipa_dep],\n> link_with : [test_libraries],\n> include_directories : [test_includes_internal,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A2DCABE173\n\tfor ;\n\tTue, 6 Aug 2024 15:12:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D750D633AC;\n\tTue, 6 Aug 2024 17:12:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C87846337C\n\tfor ;\n\tTue, 6 Aug 2024 17:12:45 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 843804CD\n\tfor ;\n\tTue, 6 Aug 2024 17:11:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OluxALnG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722957113;\n\tbh=pFg+oAsGYt+GTa9n/ecejRSo83zmz6q01xcr/4v6PEs=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=OluxALnGLPt8O0wrW9afmMh3Wg+vKHNJHV811+VXm5cvFZBMifO266I/62WSewxIf\n\tGjfyNS+C0FaF/NWB6bwh3wD6GK1CBvZuGdPWmb+U1PsL6iUuYtWoHRoOnp3GleMIJp\n\tPx/cgDhtc6x1Hl8BQfwbUcPOs0ht8eTlugYfOrQc=","Message-ID":"","Date":"Tue, 6 Aug 2024 16:12:42 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v5 08/18] libcamera: Drop libcamera_generated_ipa_headers\n\tfrom sources","To":"libcamera-devel@lists.libcamera.org","References":"<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>\n\t<20240805143654.20870-9-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240805143654.20870-9-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30635,"web_url":"https://patchwork.libcamera.org/comment/30635/","msgid":"<20240806152334.GB8166@pendragon.ideasonboard.com>","date":"2024-08-06T15:23:34","subject":"Re: [PATCH v5 08/18] libcamera: Drop libcamera_generated_ipa_headers\n\tfrom sources","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Aug 06, 2024 at 04:12:42PM +0100, Daniel Scally wrote:\n> On 05/08/2024 15:36, Laurent Pinchart wrote:\n> > The libcamera_generated_ipa_headers variable, containing the list of\n> > generated IPA headers, is listed in the sources of IPA modules, as well\n> > as IPA tests. This was done to ensure that the modules and tests get\n> > rebuilt when the generate IPA headers change. However, the dependency is\n> > already handled through the libcamera_private dependency object,\n> > specified for all those modules and tests. There's no need to list the\n> > IPA generated headers as sources. Drop them.\n> >\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> \n> How did you catch that one too?\n\nI wanted to drop the libcamera_generated_ipa_headers variable, I looked\nat where it was used, and realized there was no need to pass it to\nshared_module() explicitly.\n\n> Reviewed-by: Daniel Scally \n> \n> > src/ipa/ipu3/meson.build | 3 +--\n> > src/ipa/rkisp1/meson.build | 3 +--\n> > src/ipa/rpi/vc4/meson.build | 3 +--\n> > src/ipa/simple/meson.build | 3 +--\n> > src/ipa/vimc/meson.build | 3 +--\n> > src/libcamera/proxy/worker/meson.build | 3 +--\n> > test/ipa/meson.build | 2 +-\n> > test/ipa/rkisp1/meson.build | 2 +-\n> > 8 files changed, 8 insertions(+), 14 deletions(-)\n> >\n> > diff --git a/src/ipa/ipu3/meson.build b/src/ipa/ipu3/meson.build\n> > index e76f97c07c87..34de6213aa83 100644\n> > --- a/src/ipa/ipu3/meson.build\n> > +++ b/src/ipa/ipu3/meson.build\n> > @@ -12,8 +12,7 @@ ipu3_ipa_sources = files([\n> > \n> > ipu3_ipa_sources += ipu3_ipa_algorithms\n> > \n> > -mod = shared_module(ipa_name,\n> > - [ipu3_ipa_sources, libcamera_generated_ipa_headers],\n> > +mod = shared_module(ipa_name, ipu3_ipa_sources,\n> > name_prefix : '',\n> > include_directories : [ipa_includes],\n> > dependencies : [libcamera_private, libipa_dep],\n> > diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build\n> > index e8b266f1ccca..160ef52dd52e 100644\n> > --- a/src/ipa/rkisp1/meson.build\n> > +++ b/src/ipa/rkisp1/meson.build\n> > @@ -13,8 +13,7 @@ rkisp1_ipa_sources = files([\n> > \n> > rkisp1_ipa_sources += rkisp1_ipa_algorithms\n> > \n> > -mod = shared_module(ipa_name,\n> > - [rkisp1_ipa_sources, libcamera_generated_ipa_headers],\n> > +mod = shared_module(ipa_name, rkisp1_ipa_sources,\n> > name_prefix : '',\n> > include_directories : [ipa_includes],\n> > dependencies : [libcamera_private, libipa_dep],\n> > diff --git a/src/ipa/rpi/vc4/meson.build b/src/ipa/rpi/vc4/meson.build\n> > index 63fc5925b06c..c10fa17e1ba4 100644\n> > --- a/src/ipa/rpi/vc4/meson.build\n> > +++ b/src/ipa/rpi/vc4/meson.build\n> > @@ -23,8 +23,7 @@ vc4_ipa_sources = files([\n> > \n> > vc4_ipa_includes += include_directories('..')\n> > \n> > -mod = shared_module(ipa_name,\n> > - [vc4_ipa_sources, libcamera_generated_ipa_headers],\n> > +mod = shared_module(ipa_name, vc4_ipa_sources,\n> > name_prefix : '',\n> > include_directories : vc4_ipa_includes,\n> > dependencies : [vc4_ipa_deps, libipa_dep],\n> > diff --git a/src/ipa/simple/meson.build b/src/ipa/simple/meson.build\n> > index 33d1c96aa4f2..b297e1d2e677 100644\n> > --- a/src/ipa/simple/meson.build\n> > +++ b/src/ipa/simple/meson.build\n> > @@ -7,8 +7,7 @@ soft_simple_sources = files([\n> > 'black_level.cpp',\n> > ])\n> > \n> > -mod = shared_module(ipa_name,\n> > - [soft_simple_sources, libcamera_generated_ipa_headers],\n> > +mod = shared_module(ipa_name, soft_simple_sources,\n> > name_prefix : '',\n> > include_directories : [ipa_includes],\n> > dependencies : [libcamera_private, libipa_dep],\n> > diff --git a/src/ipa/vimc/meson.build b/src/ipa/vimc/meson.build\n> > index d0b63eddd5f6..2cc5f80b0b69 100644\n> > --- a/src/ipa/vimc/meson.build\n> > +++ b/src/ipa/vimc/meson.build\n> > @@ -2,8 +2,7 @@\n> > \n> > ipa_name = 'ipa_vimc'\n> > \n> > -mod = shared_module(ipa_name,\n> > - ['vimc.cpp', libcamera_generated_ipa_headers],\n> > +mod = shared_module(ipa_name, 'vimc.cpp',\n> > name_prefix : '',\n> > include_directories : [ipa_includes],\n> > dependencies : [libcamera_private, libipa_dep],\n> > diff --git a/src/libcamera/proxy/worker/meson.build b/src/libcamera/proxy/worker/meson.build\n> > index aa4d9cd7b5d8..b5ab9794c622 100644\n> > --- a/src/libcamera/proxy/worker/meson.build\n> > +++ b/src/libcamera/proxy/worker/meson.build\n> > @@ -17,8 +17,7 @@ foreach mojom : ipa_mojoms\n> > './' + '@INPUT@'\n> > ])\n> > \n> > - proxy = executable(mojom['name'] + '_ipa_proxy',\n> > - [worker, libcamera_generated_ipa_headers],\n> > + proxy = executable(mojom['name'] + '_ipa_proxy', worker,\n> > install : true,\n> > install_dir : proxy_install_dir,\n> > dependencies : libcamera_private)\n> > diff --git a/test/ipa/meson.build b/test/ipa/meson.build\n> > index fe21ca58b64f..e9871aba44ee 100644\n> > --- a/test/ipa/meson.build\n> > +++ b/test/ipa/meson.build\n> > @@ -8,7 +8,7 @@ ipa_test = [\n> > ]\n> > \n> > foreach test : ipa_test\n> > - exe = executable(test['name'], test['sources'], libcamera_generated_ipa_headers,\n> > + exe = executable(test['name'], test['sources'],\n> > dependencies : [libcamera_private, libipa_dep],\n> > link_with : [test_libraries],\n> > include_directories : [test_includes_internal])\n> > diff --git a/test/ipa/rkisp1/meson.build b/test/ipa/rkisp1/meson.build\n> > index 5b08e2939ce6..894523daf76b 100644\n> > --- a/test/ipa/rkisp1/meson.build\n> > +++ b/test/ipa/rkisp1/meson.build\n> > @@ -5,7 +5,7 @@ rkisp1_ipa_test = [\n> > ]\n> > \n> > foreach test : rkisp1_ipa_test\n> > - exe = executable(test['name'], test['sources'], libcamera_generated_ipa_headers,\n> > + exe = executable(test['name'], test['sources'],\n> > dependencies : [libcamera_private, libipa_dep],\n> > link_with : [test_libraries],\n> > include_directories : [test_includes_internal,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81EEBC323E\n\tfor ;\n\tTue, 6 Aug 2024 15:23:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7410F6338D;\n\tTue, 6 Aug 2024 17:23:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 838C96195D\n\tfor ;\n\tTue, 6 Aug 2024 17:23:57 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 103D34CD;\n\tTue, 6 Aug 2024 17:23:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fjQjhySt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722957785;\n\tbh=o5dK/+nQUacV3bKvn79fy8PcuzDWu84To/n0nySLRXs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fjQjhyStg9QZ4E0Ce5SSO2z+MA4Tx79RFFSAEytradUZUx3LfpgEv2f5noFQDE8op\n\tASin4tykx/uaoDDrX9oZzMjSz+FEh4LK8W27OzH9CPvtfy5xHyHoVTYjyX/PbmonDY\n\t8jhrRIRGHUC0hzb63AEE8843yQArXNyBSWrRrmd8=","Date":"Tue, 6 Aug 2024 18:23:34 +0300","From":"Laurent Pinchart ","To":"Dan Scally ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v5 08/18] libcamera: Drop libcamera_generated_ipa_headers\n\tfrom sources","Message-ID":"<20240806152334.GB8166@pendragon.ideasonboard.com>","References":"<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>\n\t<20240805143654.20870-9-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30662,"web_url":"https://patchwork.libcamera.org/comment/30662/","msgid":"<172302906553.1687952.6704014135664561419@ping.linuxembedded.co.uk>","date":"2024-08-07T11:11:05","subject":"Re: [PATCH v5 08/18] libcamera: Drop libcamera_generated_ipa_headers\n\tfrom sources","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-08-05 15:36:44)\n> The libcamera_generated_ipa_headers variable, containing the list of\n> generated IPA headers, is listed in the sources of IPA modules, as well\n> as IPA tests. This was done to ensure that the modules and tests get\n> rebuilt when the generate IPA headers change. However, the dependency is\n> already handled through the libcamera_private dependency object,\n> specified for all those modules and tests. There's no need to list the\n> IPA generated headers as sources. Drop them.\n\nI'm fine with this but a little scared, as I think I remember the issue\nwe had here where the updates weren't handled.\n\nBut ... looking through I see indeed,\n\n\n# Internal dependency for components and plugins which can use private APIs\nlibcamera_private = declare_dependency(sources : [\n libcamera_generated_ipa_headers,\n ],\n dependencies : [\n libcamera_public,\n libcamera_base_private,\n ])\n\n\nSo this is good imo.\n\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/ipu3/meson.build | 3 +--\n> src/ipa/rkisp1/meson.build | 3 +--\n> src/ipa/rpi/vc4/meson.build | 3 +--\n> src/ipa/simple/meson.build | 3 +--\n> src/ipa/vimc/meson.build | 3 +--\n> src/libcamera/proxy/worker/meson.build | 3 +--\n> test/ipa/meson.build | 2 +-\n> test/ipa/rkisp1/meson.build | 2 +-\n> 8 files changed, 8 insertions(+), 14 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/meson.build b/src/ipa/ipu3/meson.build\n> index e76f97c07c87..34de6213aa83 100644\n> --- a/src/ipa/ipu3/meson.build\n> +++ b/src/ipa/ipu3/meson.build\n> @@ -12,8 +12,7 @@ ipu3_ipa_sources = files([\n> \n> ipu3_ipa_sources += ipu3_ipa_algorithms\n> \n> -mod = shared_module(ipa_name,\n> - [ipu3_ipa_sources, libcamera_generated_ipa_headers],\n> +mod = shared_module(ipa_name, ipu3_ipa_sources,\n> name_prefix : '',\n> include_directories : [ipa_includes],\n> dependencies : [libcamera_private, libipa_dep],\n> diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build\n> index e8b266f1ccca..160ef52dd52e 100644\n> --- a/src/ipa/rkisp1/meson.build\n> +++ b/src/ipa/rkisp1/meson.build\n> @@ -13,8 +13,7 @@ rkisp1_ipa_sources = files([\n> \n> rkisp1_ipa_sources += rkisp1_ipa_algorithms\n> \n> -mod = shared_module(ipa_name,\n> - [rkisp1_ipa_sources, libcamera_generated_ipa_headers],\n> +mod = shared_module(ipa_name, rkisp1_ipa_sources,\n> name_prefix : '',\n> include_directories : [ipa_includes],\n> dependencies : [libcamera_private, libipa_dep],\n> diff --git a/src/ipa/rpi/vc4/meson.build b/src/ipa/rpi/vc4/meson.build\n> index 63fc5925b06c..c10fa17e1ba4 100644\n> --- a/src/ipa/rpi/vc4/meson.build\n> +++ b/src/ipa/rpi/vc4/meson.build\n> @@ -23,8 +23,7 @@ vc4_ipa_sources = files([\n> \n> vc4_ipa_includes += include_directories('..')\n> \n> -mod = shared_module(ipa_name,\n> - [vc4_ipa_sources, libcamera_generated_ipa_headers],\n> +mod = shared_module(ipa_name, vc4_ipa_sources,\n> name_prefix : '',\n> include_directories : vc4_ipa_includes,\n> dependencies : [vc4_ipa_deps, libipa_dep],\n> diff --git a/src/ipa/simple/meson.build b/src/ipa/simple/meson.build\n> index 33d1c96aa4f2..b297e1d2e677 100644\n> --- a/src/ipa/simple/meson.build\n> +++ b/src/ipa/simple/meson.build\n> @@ -7,8 +7,7 @@ soft_simple_sources = files([\n> 'black_level.cpp',\n> ])\n> \n> -mod = shared_module(ipa_name,\n> - [soft_simple_sources, libcamera_generated_ipa_headers],\n> +mod = shared_module(ipa_name, soft_simple_sources,\n> name_prefix : '',\n> include_directories : [ipa_includes],\n> dependencies : [libcamera_private, libipa_dep],\n> diff --git a/src/ipa/vimc/meson.build b/src/ipa/vimc/meson.build\n> index d0b63eddd5f6..2cc5f80b0b69 100644\n> --- a/src/ipa/vimc/meson.build\n> +++ b/src/ipa/vimc/meson.build\n> @@ -2,8 +2,7 @@\n> \n> ipa_name = 'ipa_vimc'\n> \n> -mod = shared_module(ipa_name,\n> - ['vimc.cpp', libcamera_generated_ipa_headers],\n> +mod = shared_module(ipa_name, 'vimc.cpp',\n> name_prefix : '',\n> include_directories : [ipa_includes],\n> dependencies : [libcamera_private, libipa_dep],\n> diff --git a/src/libcamera/proxy/worker/meson.build b/src/libcamera/proxy/worker/meson.build\n> index aa4d9cd7b5d8..b5ab9794c622 100644\n> --- a/src/libcamera/proxy/worker/meson.build\n> +++ b/src/libcamera/proxy/worker/meson.build\n> @@ -17,8 +17,7 @@ foreach mojom : ipa_mojoms\n> './' + '@INPUT@'\n> ])\n> \n> - proxy = executable(mojom['name'] + '_ipa_proxy',\n> - [worker, libcamera_generated_ipa_headers],\n> + proxy = executable(mojom['name'] + '_ipa_proxy', worker,\n> install : true,\n> install_dir : proxy_install_dir,\n> dependencies : libcamera_private)\n> diff --git a/test/ipa/meson.build b/test/ipa/meson.build\n> index fe21ca58b64f..e9871aba44ee 100644\n> --- a/test/ipa/meson.build\n> +++ b/test/ipa/meson.build\n> @@ -8,7 +8,7 @@ ipa_test = [\n> ]\n> \n> foreach test : ipa_test\n> - exe = executable(test['name'], test['sources'], libcamera_generated_ipa_headers,\n> + exe = executable(test['name'], test['sources'],\n> dependencies : [libcamera_private, libipa_dep],\n> link_with : [test_libraries],\n> include_directories : [test_includes_internal])\n> diff --git a/test/ipa/rkisp1/meson.build b/test/ipa/rkisp1/meson.build\n> index 5b08e2939ce6..894523daf76b 100644\n> --- a/test/ipa/rkisp1/meson.build\n> +++ b/test/ipa/rkisp1/meson.build\n> @@ -5,7 +5,7 @@ rkisp1_ipa_test = [\n> ]\n> \n> foreach test : rkisp1_ipa_test\n> - exe = executable(test['name'], test['sources'], libcamera_generated_ipa_headers,\n> + exe = executable(test['name'], test['sources'],\n> dependencies : [libcamera_private, libipa_dep],\n> link_with : [test_libraries],\n> include_directories : [test_includes_internal,\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C9A8ABE173\n\tfor ;\n\tWed, 7 Aug 2024 11:11:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6FD126338D;\n\tWed, 7 Aug 2024 13:11:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 535406337E\n\tfor ;\n\tWed, 7 Aug 2024 13:11:08 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5C12B6AF;\n\tWed, 7 Aug 2024 13:10:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WIMbarXs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723029015;\n\tbh=GgvmA+O3yDWGw8s5/CIJ6AEmPjSoTNDi6gzFxwFzl3M=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=WIMbarXs84pmNkCLclcpeSsAa+6rJAlZF/TgMl9LbsTzWP1LwF/U19n2dJDQ7zYe9\n\t43TA/2aBakmcu7htVAAnkhXifj/8r66ca6n0ItYv8pdDSZ4GcR4dsIPLWA6E8lXLem\n\t7afUSDjt6jN+NSFtvYPLnjUWojy151J/ryHwAfu4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240805143654.20870-9-laurent.pinchart@ideasonboard.com>","References":"<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>\n\t<20240805143654.20870-9-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH v5 08/18] libcamera: Drop libcamera_generated_ipa_headers\n\tfrom sources","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 07 Aug 2024 12:11:05 +0100","Message-ID":"<172302906553.1687952.6704014135664561419@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]