{"id":2079,"url":"https://patchwork.libcamera.org/api/patches/2079/?format=json","web_url":"https://patchwork.libcamera.org/patch/2079/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20191003152037.74617-4-jacopo@jmondi.org>","date":"2019-10-03T15:20:35","name":"[libcamera-devel,3/5] ipa: ipa_manager: Print the loaded IPA modules path","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"00c557ad59264856f7780e4db4aa5eb2bd1523a5","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2079/mbox/","series":[{"id":515,"url":"https://patchwork.libcamera.org/api/series/515/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=515","date":"2019-10-03T15:20:32","name":"test: Add IPA interface test support","version":1,"mbox":"https://patchwork.libcamera.org/series/515/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2079/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2079/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C27D60BE9\n\tfor ;\n\tThu, 3 Oct 2019 17:19:05 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 3C9EDC0008;\n\tThu, 3 Oct 2019 15:19:05 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 3 Oct 2019 17:20:35 +0200","Message-Id":"<20191003152037.74617-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.23.0","In-Reply-To":"<20191003152037.74617-1-jacopo@jmondi.org>","References":"<20191003152037.74617-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 3/5] ipa: ipa_manager: Print the loaded\n\tIPA modules path","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 03 Oct 2019 15:19:05 -0000"},"content":"Add debug message to report which IPA modules have been loaded and in\nwhich order.\n\nThe loading order is particularly relevant for the test VIMC IPA, as the\nsame IPA is compiled with an open source license tag and a proprietary\none and they both match() against the VIMC pipeline handler. Being\ninformed about their loading order is helpful to understand which one of\nthe two is actually in use.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/ipa_manager.cpp | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\nindex 708233e8a9c7..e990bdcdf84b 100644\n--- a/src/libcamera/ipa_manager.cpp\n+++ b/src/libcamera/ipa_manager.cpp\n@@ -120,13 +120,16 @@ int IPAManager::addDir(const char *libDir)\n \t\tif (strcmp(&ent->d_name[offset], \".so\"))\n \t\t\tcontinue;\n \n-\t\tIPAModule *ipaModule = new IPAModule(std::string(libDir) +\n-\t\t\t\t\t\t \"/\" + ent->d_name);\n+\t\tstd::string modulePath = std::string(libDir) + \"/\" +\n+\t\t\t\t\t ent->d_name;\n+\t\tIPAModule *ipaModule = new IPAModule(modulePath);\n \t\tif (!ipaModule->isValid()) {\n \t\t\tdelete ipaModule;\n \t\t\tcontinue;\n \t\t}\n \n+\t\tLOG(IPAManager, Debug) << \"Loaded IPA module: \" << modulePath;\n+\n \t\tmodules_.push_back(ipaModule);\n \t\tcount++;\n \t}\n","prefixes":["libcamera-devel","3/5"]}