{"id":20788,"url":"https://patchwork.libcamera.org/api/patches/20788/?format=json","web_url":"https://patchwork.libcamera.org/patch/20788/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240805143654.20870-3-laurent.pinchart@ideasonboard.com>","date":"2024-08-05T14:36:38","name":"[v5,02/18] libcamera: Make all internal headers visible to Doxygen","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"03c0596c216c4647d32b3f8ac1fc72f969215f17","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20788/mbox/","series":[{"id":4488,"url":"https://patchwork.libcamera.org/api/series/4488/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4488","date":"2024-08-05T14:36:36","name":"Split libcamera documentation in public and internal APIs","version":5,"mbox":"https://patchwork.libcamera.org/series/4488/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20788/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20788/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C4E37C323E\n\tfor ;\n\tMon, 5 Aug 2024 14:37:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F104A6338B;\n\tMon, 5 Aug 2024 16:37:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5009C63381\n\tfor ;\n\tMon, 5 Aug 2024 16:37:20 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B6C00581\n\tfor ;\n\tMon, 5 Aug 2024 16:36:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BHLCLnyj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722868588;\n\tbh=3EZ88y47cKHOkONmkzjpxp1fS7sHbz3+QV7akuG3PyM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=BHLCLnyjscVysdnIw1iBakmaJ9dGDmBGjRqaCoqicavCxv0zct+d/RXGhM2NAa23E\n\t2kscjo2HgoncmJx0w5evhpjCmeYa6ZAO7ftUpqyZr74zUT4S9kxN7NWPIERrQhNa0x\n\tAaE5eOyzqp9Lxj1mDwv8aHO91GzHlPa87Tt9Iico=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v5 02/18] libcamera: Make all internal headers visible to\n\tDoxygen","Date":"Mon, 5 Aug 2024 17:36:38 +0300","Message-ID":"<20240805143654.20870-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","In-Reply-To":"<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>","References":"<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Two classes that have both public and internal headers, namely Camera\nand Request, make only their public header visible to Doxygen through a\nfile directive. Fix them.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/camera.cpp | 5 +++++\n src/libcamera/request.cpp | 5 +++++\n 2 files changed, 10 insertions(+)","diff":"diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 67f3490133b2..f89510ea0472 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -117,6 +117,11 @@\n * of view is affected by the pipeline.\n */\n \n+/**\n+ * \\file libcamera/internal/camera.h\n+ * \\brief Internal camera device handling\n+ */\n+\n namespace libcamera {\n \n LOG_DECLARE_CATEGORY(Camera)\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex cfb451e908da..fdf12c1e9088 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -28,6 +28,11 @@\n * \\brief Describes a frame capture request to be processed by a camera\n */\n \n+/**\n+ * \\file libcamera/internal/request.h\n+ * \\brief Internal support for request handling\n+ */\n+\n namespace libcamera {\n \n LOG_DEFINE_CATEGORY(Request)\n","prefixes":["v5","02/18"]}