[{"id":30627,"web_url":"https://patchwork.libcamera.org/comment/30627/","msgid":"","date":"2024-08-06T13:28:59","subject":"Re: [PATCH v5 01/18] libcamera: Drop path prefix from Doxygen file\n\tdirective","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Laurent, thanks for the patchset\n\nOn 05/08/2024 15:36, Laurent Pinchart wrote:\n> The Doxygen directive only requires qualifying header file names with a\n> path to differentiate between multiple header files with the same name.\n> Most file directives that refer to unambiguous files do not have a\n> libcamera/ and/or internal/ path prefix, but a few do, most likely due\n> to copy&paste. Drop the prefix in those few files for consistency.\n>\n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Daniel Scally \n\n> ---\n> src/libcamera/converter.cpp | 2 +-\n> src/libcamera/converter/converter_v4l2_m2m.cpp | 2 +-\n> src/libcamera/fence.cpp | 2 +-\n> src/libcamera/mapped_framebuffer.cpp | 2 +-\n> src/libcamera/orientation.cpp | 2 +-\n> src/libcamera/yaml_parser.cpp | 2 +-\n> 6 files changed, 6 insertions(+), 6 deletions(-)\n>\n> diff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp\n> index 2ab461332677..8237998f044b 100644\n> --- a/src/libcamera/converter.cpp\n> +++ b/src/libcamera/converter.cpp\n> @@ -14,7 +14,7 @@\n> #include \"libcamera/internal/media_device.h\"\n> \n> /**\n> - * \\file internal/converter.h\n> + * \\file converter.h\n> * \\brief Abstract converter\n> */\n> \n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index 2e77872e1710..006ba9f7f665 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -23,7 +23,7 @@\n> #include \"libcamera/internal/v4l2_videodevice.h\"\n> \n> /**\n> - * \\file internal/converter/converter_v4l2_m2m.h\n> + * \\file converter/converter_v4l2_m2m.h\n> * \\brief V4L2 M2M based converter\n> */\n> \n> diff --git a/src/libcamera/fence.cpp b/src/libcamera/fence.cpp\n> index 634c74f8e13e..73299b402702 100644\n> --- a/src/libcamera/fence.cpp\n> +++ b/src/libcamera/fence.cpp\n> @@ -11,7 +11,7 @@ namespace libcamera {\n> \n> /**\n> *\n> - * \\file libcamera/fence.h\n> + * \\file fence.h\n> * \\brief Definition of the Fence class\n> */\n> \n> diff --git a/src/libcamera/mapped_framebuffer.cpp b/src/libcamera/mapped_framebuffer.cpp\n> index b3104e0504d4..ad82e1f6e49c 100644\n> --- a/src/libcamera/mapped_framebuffer.cpp\n> +++ b/src/libcamera/mapped_framebuffer.cpp\n> @@ -16,7 +16,7 @@\n> #include \n> \n> /**\n> - * \\file libcamera/internal/mapped_framebuffer.h\n> + * \\file mapped_framebuffer.h\n> * \\brief Frame buffer memory mapping support\n> */\n> \n> diff --git a/src/libcamera/orientation.cpp b/src/libcamera/orientation.cpp\n> index 47fd6a32502b..fd191197fb8c 100644\n> --- a/src/libcamera/orientation.cpp\n> +++ b/src/libcamera/orientation.cpp\n> @@ -11,7 +11,7 @@\n> #include \n> \n> /**\n> - * \\file libcamera/orientation.h\n> + * \\file orientation.h\n> * \\brief Image orientation definition\n> */\n> \n> diff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp\n> index 025006bcdcdd..8b6a403898be 100644\n> --- a/src/libcamera/yaml_parser.cpp\n> +++ b/src/libcamera/yaml_parser.cpp\n> @@ -18,7 +18,7 @@\n> #include \n> \n> /**\n> - * \\file libcamera/internal/yaml_parser.h\n> + * \\file yaml_parser.h\n> * \\brief A YAML parser helper\n> */\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0D74BE173\n\tfor ;\n\tTue, 6 Aug 2024 13:29:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E284E6337C;\n\tTue, 6 Aug 2024 15:29:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB4F76195D\n\tfor ;\n\tTue, 6 Aug 2024 15:29:02 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B5154CD\n\tfor ;\n\tTue, 6 Aug 2024 15:28:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Anh844Lg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722950890;\n\tbh=qvr5Dqyk5+17xSOg1yP1iCvJi+aZwBwdw27+PQo6lBc=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=Anh844LgFORgFl/Z5pl+4yEh7raEBheADQIJudVRbL9p9Qy2Adjf1t+izhmU6nLy/\n\t8ZuI6Uzg4kOcZK/fZoCisPdEHUPCv6tC5RDSRLX5dWlvCPq0AV8jYy5P5Pyn1wayC1\n\tUt6hwXxCkQEjmIWxXRzvyr8XiIP/oYM7AKtt51fw=","Message-ID":"","Date":"Tue, 6 Aug 2024 14:28:59 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v5 01/18] libcamera: Drop path prefix from Doxygen file\n\tdirective","To":"libcamera-devel@lists.libcamera.org","References":"<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>\n\t<20240805143654.20870-2-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240805143654.20870-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30638,"web_url":"https://patchwork.libcamera.org/comment/30638/","msgid":"<172300592004.1507574.6432279982402878200@ping.linuxembedded.co.uk>","date":"2024-08-07T04:45:20","subject":"Re: [PATCH v5 01/18] libcamera: Drop path prefix from Doxygen file\n\tdirective","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-08-05 15:36:37)\n> The Doxygen directive only requires qualifying header file names with a\n> path to differentiate between multiple header files with the same name.\n> Most file directives that refer to unambiguous files do not have a\n> libcamera/ and/or internal/ path prefix, but a few do, most likely due\n> to copy&paste. Drop the prefix in those few files for consistency.\n> \n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/converter.cpp | 2 +-\n> src/libcamera/converter/converter_v4l2_m2m.cpp | 2 +-\n> src/libcamera/fence.cpp | 2 +-\n> src/libcamera/mapped_framebuffer.cpp | 2 +-\n> src/libcamera/orientation.cpp | 2 +-\n> src/libcamera/yaml_parser.cpp | 2 +-\n> 6 files changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp\n> index 2ab461332677..8237998f044b 100644\n> --- a/src/libcamera/converter.cpp\n> +++ b/src/libcamera/converter.cpp\n> @@ -14,7 +14,7 @@\n> #include \"libcamera/internal/media_device.h\"\n> \n> /**\n> - * \\file internal/converter.h\n> + * \\file converter.h\n> * \\brief Abstract converter\n> */\n> \n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index 2e77872e1710..006ba9f7f665 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -23,7 +23,7 @@\n> #include \"libcamera/internal/v4l2_videodevice.h\"\n> \n> /**\n> - * \\file internal/converter/converter_v4l2_m2m.h\n> + * \\file converter/converter_v4l2_m2m.h\n> * \\brief V4L2 M2M based converter\n> */\n> \n> diff --git a/src/libcamera/fence.cpp b/src/libcamera/fence.cpp\n> index 634c74f8e13e..73299b402702 100644\n> --- a/src/libcamera/fence.cpp\n> +++ b/src/libcamera/fence.cpp\n> @@ -11,7 +11,7 @@ namespace libcamera {\n> \n> /**\n> *\n> - * \\file libcamera/fence.h\n> + * \\file fence.h\n> * \\brief Definition of the Fence class\n> */\n> \n> diff --git a/src/libcamera/mapped_framebuffer.cpp b/src/libcamera/mapped_framebuffer.cpp\n> index b3104e0504d4..ad82e1f6e49c 100644\n> --- a/src/libcamera/mapped_framebuffer.cpp\n> +++ b/src/libcamera/mapped_framebuffer.cpp\n> @@ -16,7 +16,7 @@\n> #include \n> \n> /**\n> - * \\file libcamera/internal/mapped_framebuffer.h\n> + * \\file mapped_framebuffer.h\n> * \\brief Frame buffer memory mapping support\n> */\n> \n> diff --git a/src/libcamera/orientation.cpp b/src/libcamera/orientation.cpp\n> index 47fd6a32502b..fd191197fb8c 100644\n> --- a/src/libcamera/orientation.cpp\n> +++ b/src/libcamera/orientation.cpp\n> @@ -11,7 +11,7 @@\n> #include \n> \n> /**\n> - * \\file libcamera/orientation.h\n> + * \\file orientation.h\n> * \\brief Image orientation definition\n> */\n> \n> diff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp\n> index 025006bcdcdd..8b6a403898be 100644\n> --- a/src/libcamera/yaml_parser.cpp\n> +++ b/src/libcamera/yaml_parser.cpp\n> @@ -18,7 +18,7 @@\n> #include \n> \n> /**\n> - * \\file libcamera/internal/yaml_parser.h\n> + * \\file yaml_parser.h\n> * \\brief A YAML parser helper\n> */\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF9ADBE173\n\tfor ;\n\tWed, 7 Aug 2024 04:45:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BD47F6338D;\n\tWed, 7 Aug 2024 06:45:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 255C76195A\n\tfor ;\n\tWed, 7 Aug 2024 06:45:23 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 571896AF;\n\tWed, 7 Aug 2024 06:44:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"laD9tDbJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723005870;\n\tbh=9WMQepwc4eoh4vupYMHuktVB7NOpBv7TRnxzuV0hMno=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=laD9tDbJx/ZoZlNm/lwvwCWkhUPNpXU+PxNgU5eaYihl1Oe4ODoQ8bNYIT5gFonCv\n\t8oonsmv/9hLnANZD2taCCEHyQDl2b95dLwHQ46Buvzl4XOcxfVTp8em0A3F76/JORI\n\tgIEdbVYEBPMIOI44y8xE/dS6qsWHEXYzlFS9CQP0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240805143654.20870-2-laurent.pinchart@ideasonboard.com>","References":"<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>\n\t<20240805143654.20870-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH v5 01/18] libcamera: Drop path prefix from Doxygen file\n\tdirective","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 07 Aug 2024 05:45:20 +0100","Message-ID":"<172300592004.1507574.6432279982402878200@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]