[{"id":2744,"web_url":"https://patchwork.libcamera.org/comment/2744/","msgid":"<20191003161841.GB5415@pendragon.ideasonboard.com>","date":"2019-10-03T16:18:41","subject":"Re: [libcamera-devel] [PATCH 2/5] test: ipa: Rename the ipa_test to\n\tipa_module_test","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Oct 03, 2019 at 05:20:34PM +0200, Jacopo Mondi wrote:\n> Update the IPA test to match the test class name in prevision of adding\n> more IPA tests. Also update the description comment in the test unit, as\n> the old name for the test was still used.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> test/ipa/{ipa_test.cpp => ipa_module_test.cpp} | 2 +-\n> test/ipa/meson.build | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> rename test/ipa/{ipa_test.cpp => ipa_module_test.cpp} (95%)\n> \n> diff --git a/test/ipa/ipa_test.cpp b/test/ipa/ipa_module_test.cpp\n> similarity index 95%\n> rename from test/ipa/ipa_test.cpp\n> rename to test/ipa/ipa_module_test.cpp\n> index 8f9b2d8058ec..3a634099a550 100644\n> --- a/test/ipa/ipa_test.cpp\n> +++ b/test/ipa/ipa_module_test.cpp\n> @@ -2,7 +2,7 @@\n> /*\n> * Copyright (C) 2019, Google Inc.\n> *\n> - * load-so.cpp - loading .so tests\n> + * ipa_module_test.cpp - Test loading of the VIMC IPA module and verify its info\n> */\n> \n> #include \n> diff --git a/test/ipa/meson.build b/test/ipa/meson.build\n> index 1749ab7d4338..e174671d05e1 100644\n> --- a/test/ipa/meson.build\n> +++ b/test/ipa/meson.build\n> @@ -1,5 +1,5 @@\n> ipa_test = [\n> - ['ipa_test', 'ipa_test.cpp'],\n> + ['ipa_module_test', 'ipa_module_test.cpp'],\n> ]\n> \n> foreach t : ipa_test","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2527360BE9\n\tfor ;\n\tThu, 3 Oct 2019 18:18:56 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [132.205.229.214])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 293112E5;\n\tThu, 3 Oct 2019 18:18:54 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1570119535;\n\tbh=fOjdLRM11IKU8ZAVAKRvuynRdY5VTdGzHLDGj9qDRkA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IgeO2WpBBcxOot9Q/xYVhFPZMn6qz4dHc/Dn5Rgr3CIbqtUgQgKkLjBksv1wRNuhp\n\tSjdUk7PJgDggDwGc/HSMQQsweeR0rYWKvLPbib/dMukom7NH60sy1lojjy5hm4R6ug\n\tCbAw3C6ZheOCcRpxgc+Ye+YO1GpM5HOxJ/rDN7qo=","Date":"Thu, 3 Oct 2019 19:18:41 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191003161841.GB5415@pendragon.ideasonboard.com>","References":"<20191003152037.74617-1-jacopo@jmondi.org>\n\t<20191003152037.74617-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20191003152037.74617-3-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/5] test: ipa: Rename the ipa_test to\n\tipa_module_test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 03 Oct 2019 16:18:56 -0000"}},{"id":2765,"web_url":"https://patchwork.libcamera.org/comment/2765/","msgid":"<20191003202808.GT1322@bigcity.dyn.berto.se>","date":"2019-10-03T20:28:08","subject":"Re: [libcamera-devel] [PATCH 2/5] test: ipa: Rename the ipa_test to\n\tipa_module_test","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2019-10-03 17:20:34 +0200, Jacopo Mondi wrote:\n> Update the IPA test to match the test class name in prevision of adding\n> more IPA tests. Also update the description comment in the test unit, as\n> the old name for the test was still used.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> test/ipa/{ipa_test.cpp => ipa_module_test.cpp} | 2 +-\n> test/ipa/meson.build | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> rename test/ipa/{ipa_test.cpp => ipa_module_test.cpp} (95%)\n> \n> diff --git a/test/ipa/ipa_test.cpp b/test/ipa/ipa_module_test.cpp\n> similarity index 95%\n> rename from test/ipa/ipa_test.cpp\n> rename to test/ipa/ipa_module_test.cpp\n> index 8f9b2d8058ec..3a634099a550 100644\n> --- a/test/ipa/ipa_test.cpp\n> +++ b/test/ipa/ipa_module_test.cpp\n> @@ -2,7 +2,7 @@\n> /*\n> * Copyright (C) 2019, Google Inc.\n> *\n> - * load-so.cpp - loading .so tests\n> + * ipa_module_test.cpp - Test loading of the VIMC IPA module and verify its info\n> */\n> \n> #include \n> diff --git a/test/ipa/meson.build b/test/ipa/meson.build\n> index 1749ab7d4338..e174671d05e1 100644\n> --- a/test/ipa/meson.build\n> +++ b/test/ipa/meson.build\n> @@ -1,5 +1,5 @@\n> ipa_test = [\n> - ['ipa_test', 'ipa_test.cpp'],\n> + ['ipa_module_test', 'ipa_module_test.cpp'],\n> ]\n> \n> foreach t : ipa_test\n> -- \n> 2.23.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 57D6E60BE8\n\tfor ;\n\tThu, 3 Oct 2019 22:28:10 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id q64so4166429ljb.12\n\tfor ;\n\tThu, 03 Oct 2019 13:28:10 -0700 (PDT)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tc21sm638869lff.61.2019.10.03.13.28.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 03 Oct 2019 13:28:09 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=xXNzqcCDjwP8GoWZSi00Yba2o6FWKwQopCfa75YWzgE=;\n\tb=ew2Uj80Gp1VjZq9RgX8FkQmQVzxHFXq90pPgbTA/7Ess5gZCKppPaIfltoIMe0/tNA\n\tMX9Glm2BCBXubKZqfh4FXeB4/sDlkc9qSkcKmSfFlvpE5Q/dlmOd2FjIsOV8NDxN/LIR\n\tQwH76Xb+bdGIjJjici7W6jWgmzaITaSdBq7BHR7viDD72654QAknw2ZIyFUywl7y6N1N\n\t0Xl0km2896DAmGKpKj9DcK0s638Y9y3ldzrr5mOjTgG5TE8kze34phZ/yw+25Hwr3uXP\n\tzVJpAJ5hka2T8u6Y0lgh4boF81qw6LlAfYuXfJ2iULEYJ9l68T/a0sFQfjJ/wpNpejNa\n\tdCHQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=xXNzqcCDjwP8GoWZSi00Yba2o6FWKwQopCfa75YWzgE=;\n\tb=iS2ldkwfYQvKeXdDAP8HLtx2AvZU/EJRgwkwmQpN1Y1hhZJLmAVwbH4fWsn1tLT6nU\n\tpP4IxnqP8VaTeSByMrfwRwnGHsP1T6sdeZ0qKTxYJdt7YNAFjJr6G7zu1QUJg+80KLEs\n\tc8ixP2W0f5WQSH61/3TBD84cRq6lDnceQCTn5nfA3N8+BYcOGIjRoCezPk2k475bchfl\n\tDZCrGaHqLSg2uLuxi9NpWiYn0nLnEHvY9wZSgbAeLE76y53B1WHCW/AVh8k8sIFXGnKB\n\tBuWtii6SZ9khxvdcAtF6FBPonhvhUeljAQ+/ZLsNMiZKI31ySjxaS0KTjMF8SXb1TsJf\n\tzqhw==","X-Gm-Message-State":"APjAAAX9+ES2Htdl2gZhdXKQ4o4xB9L9L0V52ErRqGCmxb89MKUc6g9S\n\t+Tv+/ktGmqBifQu9o9mXwVB4i7D7AVQ=","X-Google-Smtp-Source":"APXvYqyYRNMjqFempf4C6y2ewSZKtG343a83NCVLSYAoiDnR3faA13PFAcW9DD1sdErN1k8Cyje6jQ==","X-Received":"by 2002:a2e:9748:: with SMTP id f8mr6784673ljj.167.1570134489848;\n\tThu, 03 Oct 2019 13:28:09 -0700 (PDT)","Date":"Thu, 3 Oct 2019 22:28:08 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191003202808.GT1322@bigcity.dyn.berto.se>","References":"<20191003152037.74617-1-jacopo@jmondi.org>\n\t<20191003152037.74617-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191003152037.74617-3-jacopo@jmondi.org>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH 2/5] test: ipa: Rename the ipa_test to\n\tipa_module_test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 03 Oct 2019 20:28:10 -0000"}}]