[{"id":30595,"web_url":"https://patchwork.libcamera.org/comment/30595/","msgid":"<172286595850.1687952.8769565250162919995@ping.linuxembedded.co.uk>","date":"2024-08-05T13:52:38","subject":"Re: [PATCH v1 6/6] utils: tuning: rkisp1: Replace static AWB with\n\tnew AWB module","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2024-08-05 13:05:07)\n> The rkisp1 tuner used a static module to insert the AWB algorithm into\n> the tuning file. Replace that with the new AWB module.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> utils/tuning/rkisp1.py | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\n> index f5c42a61d15e..9f40fd8bd63b 100755\n> --- a/utils/tuning/rkisp1.py\n> +++ b/utils/tuning/rkisp1.py\n> @@ -2,6 +2,7 @@\n> # SPDX-License-Identifier: GPL-2.0-or-later\n> #\n> # Copyright (C) 2022, Paul Elder \n> +# Copyright (C) 2024, Ideas On Board\n> #\n> # Tuning script for rkisp1\n> \n> @@ -14,13 +15,14 @@ from libtuning.parsers import YamlParser\n> from libtuning.generators import YamlOutput\n> from libtuning.modules.lsc import LSCRkISP1\n> from libtuning.modules.agc import AGCRkISP1\n> +from libtuning.modules.awb import AWBRkISP1\n> from libtuning.modules.ccm import CCMRkISP1\n> from libtuning.modules.static import StaticModule\n> \n> coloredlogs.install(level=logging.INFO, fmt='%(name)s %(levelname)s %(message)s')\n> \n> agc = AGCRkISP1(debug=[lt.Debug.Plot])\n> -awb = StaticModule('Awb')\n> +awb = AWBRkISP1(debug=[lt.Debug.Plot])\n\nOk so that's 'why' there's an RkISP1 part for now I guess.\nI'm still curious if it's actually anything specific ... but fine for\nnow ... and as this patch stands on top of the predecessors:\n\n\nReviewed-by: Kieran Bingham \n\n> blc = StaticModule('BlackLevelCorrection')\n> ccm = CCMRkISP1(debug=[lt.Debug.Plot])\n> color_processing = StaticModule('ColorProcessing')\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 91866BE173\n\tfor ;\n\tMon, 5 Aug 2024 13:52:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3AB5563386;\n\tMon, 5 Aug 2024 15:52:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 26E166337E\n\tfor ;\n\tMon, 5 Aug 2024 15:52:42 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AC21418D;\n\tMon, 5 Aug 2024 15:51:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gO4odCJ5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722865910;\n\tbh=Xh840eEQn8SQXKC+ERSXuekt/wPFPWEmJFslASpWM8U=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=gO4odCJ5vOu9tTskvl479cRNUr3F33aqB/R+VuQ7a5bO7MS9mVZ+oZPtY0RGXP+qo\n\tj9VGot7Vbugm92FyudcrrT03z22PelkqujUQryysOINVESNrufpFTKdJ4uElILdfVo\n\tRjYvTD7q6ZYwAisb2kG7CadPVLBPqceY7nKpWZuY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240805120522.1613342-7-stefan.klug@ideasonboard.com>","References":"<20240805120522.1613342-1-stefan.klug@ideasonboard.com>\n\t<20240805120522.1613342-7-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v1 6/6] utils: tuning: rkisp1: Replace static AWB with\n\tnew AWB module","From":"Kieran Bingham ","Cc":"David Plowman ,\n\tStefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 05 Aug 2024 14:52:38 +0100","Message-ID":"<172286595850.1687952.8769565250162919995@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]