[{"id":2743,"web_url":"https://patchwork.libcamera.org/comment/2743/","msgid":"<20191003155040.GA5415@pendragon.ideasonboard.com>","date":"2019-10-03T15:50:40","subject":"Re: [libcamera-devel] [PATCH 1/5] ipa: vimc: Rename ipa_dummy to\n\tipa_vimc","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Oct 03, 2019 at 05:20:33PM +0200, Jacopo Mondi wrote:\n> The DummyIPA is actually a test IPA module for the virtual media\n> controller driver VIMC. Rename it accordingly to its usage.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/{ipa_dummy.cpp => ipa_vimc.cpp} | 10 +++++-----\n> src/ipa/meson.build | 10 +++++-----\n> test/ipa/ipa_test.cpp | 2 +-\n> 3 files changed, 11 insertions(+), 11 deletions(-)\n> rename src/ipa/{ipa_dummy.cpp => ipa_vimc.cpp} (71%)\n> \n> diff --git a/src/ipa/ipa_dummy.cpp b/src/ipa/ipa_vimc.cpp\n> similarity index 71%\n> rename from src/ipa/ipa_dummy.cpp\n> rename to src/ipa/ipa_vimc.cpp\n> index 9d0cbdc8b1ad..abc06e7f5fd5 100644\n> --- a/src/ipa/ipa_dummy.cpp\n> +++ b/src/ipa/ipa_vimc.cpp\n> @@ -2,7 +2,7 @@\n> /*\n> * Copyright (C) 2019, Google Inc.\n> *\n> - * ipa_dummy.cpp - Dummy Image Processing Algorithm module\n> + * ipa_vimc.cpp - Vimc Image Processing Algorithm module\n> */\n> \n> #include \n> @@ -12,15 +12,15 @@\n> \n> namespace libcamera {\n> \n> -class IPADummy : public IPAInterface\n> +class IPAVimc : public IPAInterface\n> {\n> public:\n> \tint init();\n> };\n> \n> -int IPADummy::init()\n> +int IPAVimc::init()\n> {\n> -\tstd::cout << \"initializing dummy IPA!\" << std::endl;\n> +\tstd::cout << \"initializing vimc IPA!\" << std::endl;\n> \treturn 0;\n> }\n> \n> @@ -39,7 +39,7 @@ const struct IPAModuleInfo ipaModuleInfo = {\n> \n> IPAInterface *ipaCreate()\n> {\n> -\treturn new IPADummy();\n> +\treturn new IPAVimc();\n> }\n> };\n> \n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index f09915bc1388..b5bcd7b2c3db 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -1,12 +1,12 @@\n> -ipa_dummy_sources = [\n> - ['ipa_dummy', 'LGPL-2.1-or-later'],\n> - ['ipa_dummy_isolate', 'Proprietary'],\n> +ipa_vimc_sources = [\n> + ['ipa_vimc', 'LGPL-2.1-or-later'],\n> + ['ipa_vimc_isolate', 'Proprietary'],\n> ]\n> \n> ipa_install_dir = join_paths(get_option('libdir'), 'libcamera')\n> \n> -foreach t : ipa_dummy_sources\n> - ipa = shared_module(t[0], 'ipa_dummy.cpp',\n> +foreach t : ipa_vimc_sources\n> + ipa = shared_module(t[0], 'ipa_vimc.cpp',\n> name_prefix : '',\n> include_directories : libcamera_includes,\n> install : true,\n> diff --git a/test/ipa/ipa_test.cpp b/test/ipa/ipa_test.cpp\n> index b9e1bd61c299..8f9b2d8058ec 100644\n> --- a/test/ipa/ipa_test.cpp\n> +++ b/test/ipa/ipa_test.cpp\n> @@ -62,7 +62,7 @@ protected:\n> \t\t\t\"GPL-2.0-or-later\",\n> \t\t};\n> \n> -\t\tcount += runTest(\"src/ipa/ipa_dummy.so\", testInfo);\n> +\t\tcount += runTest(\"src/ipa/ipa_vimc.so\", testInfo);\n> \n> \t\tif (count < 0)\n> \t\t\treturn TestFail;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB98A60BE9\n\tfor ;\n\tThu, 3 Oct 2019 17:50:54 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [132.205.229.214])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D27562E5;\n\tThu, 3 Oct 2019 17:50:53 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1570117854;\n\tbh=uDe9viWl9DjE4sgaWR3zDGtQcULyTFA+loYVFWbV6XM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=aRIKzgfAfJv3j73HQ8S4qlPhiqz80oaFLf4GoVWg+riWTrdstObnnSF087PvmljJ/\n\twwxg8yXxzajsukS5BksPdEnxyvKqqh4CPluDrBYFa5xC4lTpsaHj4SRv5MBo7YG+3t\n\tUJ0zdH20IzSXi2M3alfyayHhk1fWPjQEBeXkDXFo=","Date":"Thu, 3 Oct 2019 18:50:40 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191003155040.GA5415@pendragon.ideasonboard.com>","References":"<20191003152037.74617-1-jacopo@jmondi.org>\n\t<20191003152037.74617-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20191003152037.74617-2-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/5] ipa: vimc: Rename ipa_dummy to\n\tipa_vimc","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 03 Oct 2019 15:50:54 -0000"}},{"id":2764,"web_url":"https://patchwork.libcamera.org/comment/2764/","msgid":"<20191003202654.GS1322@bigcity.dyn.berto.se>","date":"2019-10-03T20:26:54","subject":"Re: [libcamera-devel] [PATCH 1/5] ipa: vimc: Rename ipa_dummy to\n\tipa_vimc","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2019-10-03 17:20:33 +0200, Jacopo Mondi wrote:\n> The DummyIPA is actually a test IPA module for the virtual media\n> controller driver VIMC. Rename it accordingly to its usage.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/ipa/{ipa_dummy.cpp => ipa_vimc.cpp} | 10 +++++-----\n> src/ipa/meson.build | 10 +++++-----\n> test/ipa/ipa_test.cpp | 2 +-\n> 3 files changed, 11 insertions(+), 11 deletions(-)\n> rename src/ipa/{ipa_dummy.cpp => ipa_vimc.cpp} (71%)\n> \n> diff --git a/src/ipa/ipa_dummy.cpp b/src/ipa/ipa_vimc.cpp\n> similarity index 71%\n> rename from src/ipa/ipa_dummy.cpp\n> rename to src/ipa/ipa_vimc.cpp\n> index 9d0cbdc8b1ad..abc06e7f5fd5 100644\n> --- a/src/ipa/ipa_dummy.cpp\n> +++ b/src/ipa/ipa_vimc.cpp\n> @@ -2,7 +2,7 @@\n> /*\n> * Copyright (C) 2019, Google Inc.\n> *\n> - * ipa_dummy.cpp - Dummy Image Processing Algorithm module\n> + * ipa_vimc.cpp - Vimc Image Processing Algorithm module\n> */\n> \n> #include \n> @@ -12,15 +12,15 @@\n> \n> namespace libcamera {\n> \n> -class IPADummy : public IPAInterface\n> +class IPAVimc : public IPAInterface\n> {\n> public:\n> \tint init();\n> };\n> \n> -int IPADummy::init()\n> +int IPAVimc::init()\n> {\n> -\tstd::cout << \"initializing dummy IPA!\" << std::endl;\n> +\tstd::cout << \"initializing vimc IPA!\" << std::endl;\n> \treturn 0;\n> }\n> \n> @@ -39,7 +39,7 @@ const struct IPAModuleInfo ipaModuleInfo = {\n> \n> IPAInterface *ipaCreate()\n> {\n> -\treturn new IPADummy();\n> +\treturn new IPAVimc();\n> }\n> };\n> \n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index f09915bc1388..b5bcd7b2c3db 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -1,12 +1,12 @@\n> -ipa_dummy_sources = [\n> - ['ipa_dummy', 'LGPL-2.1-or-later'],\n> - ['ipa_dummy_isolate', 'Proprietary'],\n> +ipa_vimc_sources = [\n> + ['ipa_vimc', 'LGPL-2.1-or-later'],\n> + ['ipa_vimc_isolate', 'Proprietary'],\n> ]\n> \n> ipa_install_dir = join_paths(get_option('libdir'), 'libcamera')\n> \n> -foreach t : ipa_dummy_sources\n> - ipa = shared_module(t[0], 'ipa_dummy.cpp',\n> +foreach t : ipa_vimc_sources\n> + ipa = shared_module(t[0], 'ipa_vimc.cpp',\n> name_prefix : '',\n> include_directories : libcamera_includes,\n> install : true,\n> diff --git a/test/ipa/ipa_test.cpp b/test/ipa/ipa_test.cpp\n> index b9e1bd61c299..8f9b2d8058ec 100644\n> --- a/test/ipa/ipa_test.cpp\n> +++ b/test/ipa/ipa_test.cpp\n> @@ -62,7 +62,7 @@ protected:\n> \t\t\t\"GPL-2.0-or-later\",\n> \t\t};\n> \n> -\t\tcount += runTest(\"src/ipa/ipa_dummy.so\", testInfo);\n> +\t\tcount += runTest(\"src/ipa/ipa_vimc.so\", testInfo);\n> \n> \t\tif (count < 0)\n> \t\t\treturn TestFail;\n> -- \n> 2.23.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0782F60BE8\n\tfor ;\n\tThu, 3 Oct 2019 22:26:56 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id v24so4208984ljj.3\n\tfor ;\n\tThu, 03 Oct 2019 13:26:55 -0700 (PDT)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tk28sm641430lfj.33.2019.10.03.13.26.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 03 Oct 2019 13:26:54 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=9mpqYpt7QmjyI/AN1qcr5poAEuFFbmlNqaJB9gApjjc=;\n\tb=S06h7d78HGrFIknaROZmfvxiSl8Fwm3ejey+0A+TUm3I2YfYydp7wzS3JHCKG5MFo1\n\t8QuBTKx8fU/jRoaZgTBOa8+2OOlVsPx1/MZRjaz9hZfhErh6JEUFiGmMCwFrt/ZI00wY\n\tQqodhOLAuM/CgdZv9Q5vGlbbGNfSN22oniG4xgUP5J3I2ZODw3GtnEF82maMblarxzt2\n\tcfEs5CNmFclCgyfweBj8GbVED48SzKEBDMeZ9V3LoDzQKL/y1/bFg2WRXi+RfD7mo0XR\n\t1WQjuz7Yj31Neb0V4cVTxaciJFCV5qqnrlBXqgVbHgzK+XuXy/fgm4uR5d4CbuG5IsVe\n\tUJXA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=9mpqYpt7QmjyI/AN1qcr5poAEuFFbmlNqaJB9gApjjc=;\n\tb=OPzgkDYpN+PGrHZ7qHUgvIms6SN/QyeU3+NQbHd40WJ4Ta3F2u7ogZDfDAIyhkpduo\n\tHBRoQFxKVBQ3/io9B1sxIZwlk7O+zAs31vfSNfDYTlwf7QfuEkUUD1oty6iXx0Hp/uwP\n\tL0X8iJrf8RDcXNpQ86S77Wje/bbLHPExc8kpEtdyLJsZD8t5MfAB1SmWV1v3QuyclFOJ\n\tWCPfIiljid5uMLPLZwZVfEKznPBKZQv7PhaQTrD5hoYoEs4MxY+ABNangF8p7JwV/OSL\n\tBsuhatxO+12bu44B1mQlvHqWpFSq82003KtFrBx4TENtAiHcihTNlFIS7BneMhXuaa85\n\tzQWg==","X-Gm-Message-State":"APjAAAXelltBg1AIyqY0eb3HgLftyyZbrRACSyCs2DnnT7yqSJ5CLEBd\n\tye3VxuhhAhOTgOXyJqcvpknrcziXXy4=","X-Google-Smtp-Source":"APXvYqyurFIyfworpF2AN0mGAcbOcGpumQ/plF/yG3G/zYgoyXyInnNmGyB6mOqriyBniZlX8tddcw==","X-Received":"by 2002:a2e:9a50:: with SMTP id\n\tk16mr6936048ljj.221.1570134415416; \n\tThu, 03 Oct 2019 13:26:55 -0700 (PDT)","Date":"Thu, 3 Oct 2019 22:26:54 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191003202654.GS1322@bigcity.dyn.berto.se>","References":"<20191003152037.74617-1-jacopo@jmondi.org>\n\t<20191003152037.74617-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191003152037.74617-2-jacopo@jmondi.org>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH 1/5] ipa: vimc: Rename ipa_dummy to\n\tipa_vimc","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 03 Oct 2019 20:26:56 -0000"}}]