[{"id":30713,"web_url":"https://patchwork.libcamera.org/comment/30713/","msgid":"<20240809220436.GB9967@pendragon.ideasonboard.com>","date":"2024-08-09T22:04:36","subject":"Re: [PATCH v2 2/2] libcamera: add missing include to\n\tinternal/yaml_parser.h","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Sergei,\n\nThank you for the patch.\n\nOn Sun, Aug 04, 2024 at 09:55:44PM +0100, Sergei Trofimovich wrote:\n> Without the change the build fails on upcoming `gcc-15` as:\n> \n> In file included from ../src/libcamera/yaml_parser.cpp:8:\n> ../include/libcamera/internal/yaml_parser.h:183:41: error: 'uint8_t' was not declared in this scope\n> 183 | std::is_same_v ||\n> | ^~~~~~~\n> \n> Signed-off-by: Sergei Trofimovich \n> ---\n> include/libcamera/internal/yaml_parser.h | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/include/libcamera/internal/yaml_parser.h b/include/libcamera/internal/yaml_parser.h\n> index e38a2df9..f8e4f841 100644\n> --- a/include/libcamera/internal/yaml_parser.h\n> +++ b/include/libcamera/internal/yaml_parser.h\n> @@ -7,6 +7,8 @@\n> \n> #pragma once\n> \n> +#include \n> +\n> #include \n> #include \n> #include \n\ncheckstyle.py should have told you that the stdint.h header is not added\nto the right location. I recommend running checkstyle.py automatically\nwith the post-commit git hook:\n\ncp utils/hooks/post-commit .git/hooks/\n\nWith this, committing the patch will output the following:\n\n------------------------------------------------------------------------------------------------------------\ne76753cfe464565d13dc5bda41b69bbec0a2cbb6 libcamera: add missing include to internal/yaml_parser.h\n------------------------------------------------------------------------------------------------------------\n--- include/libcamera/internal/yaml_parser.h\n+++ include/libcamera/internal/yaml_parser.h\n@@ -7,11 +7,10 @@\n\n #pragma once\n\n-#include \n-\n #include \n #include \n #include \n+#include \n #include \n #include \n\n---\n1 potential issue detected, please review\n\nSuccessfully rebased and updated refs/heads/master.\n\n\n\n\nI will fix this when applying the patch, no need for a v3.\n\nReviewed-by: Laurent Pinchart ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AA563BE173\n\tfor ;\n\tFri, 9 Aug 2024 22:05:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B4250633B3;\n\tSat, 10 Aug 2024 00:05:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 191AF61946\n\tfor ;\n\tSat, 10 Aug 2024 00:05:00 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 529F84AB;\n\tSat, 10 Aug 2024 00:04:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LJsL5FJw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723241045;\n\tbh=F9ZQXySNipAaf4Zw7tPKpfTewa2j5NPk7fQ57T4re7I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LJsL5FJwvQIlD38E9osNEt/Klpsd4OMt5cC34EjhyKcRh0/h2S4yENKtoBg3FbV44\n\tIQf2V5qK9dqOl8TlGS5+LS1oJrpSaswBn3AanQ+LOUQLrVGWFHRv03SroGb3gh+BAC\n\tyGmolNTR766bgOl0BgUE6YUov2zVtmsEQggxa9pQ=","Date":"Sat, 10 Aug 2024 01:04:36 +0300","From":"Laurent Pinchart ","To":"Sergei Trofimovich ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 2/2] libcamera: add missing include to\n\tinternal/yaml_parser.h","Message-ID":"<20240809220436.GB9967@pendragon.ideasonboard.com>","References":"<20240804114336.GK3319@pendragon.ideasonboard.com>\n\t<20240804205544.2500138-1-slyich@gmail.com>\n\t<20240804205544.2500138-2-slyich@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240804205544.2500138-2-slyich@gmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30730,"web_url":"https://patchwork.libcamera.org/comment/30730/","msgid":"","date":"2024-08-12T10:59:16","subject":"Re: [PATCH v2 2/2] libcamera: add missing include to\n\tinternal/yaml_parser.h","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Sergei\n\nOn 04/08/2024 21:55, Sergei Trofimovich wrote:\n> Without the change the build fails on upcoming `gcc-15` as:\n>\n> In file included from ../src/libcamera/yaml_parser.cpp:8:\n> ../include/libcamera/internal/yaml_parser.h:183:41: error: 'uint8_t' was not declared in this scope\n> 183 | std::is_same_v ||\n> | ^~~~~~~\n>\n> Signed-off-by: Sergei Trofimovich \n> ---\nReviewed-by: Daniel Scally \n> include/libcamera/internal/yaml_parser.h | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/include/libcamera/internal/yaml_parser.h b/include/libcamera/internal/yaml_parser.h\n> index e38a2df9..f8e4f841 100644\n> --- a/include/libcamera/internal/yaml_parser.h\n> +++ b/include/libcamera/internal/yaml_parser.h\n> @@ -7,6 +7,8 @@\n> \n> #pragma once\n> \n> +#include \n> +\n> #include \n> #include \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2C15FC323E\n\tfor ;\n\tMon, 12 Aug 2024 10:59:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B8D68633BA;\n\tMon, 12 Aug 2024 12:59:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ABB2263398\n\tfor ;\n\tMon, 12 Aug 2024 12:59:19 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7DF0F6B5\n\tfor ;\n\tMon, 12 Aug 2024 12:58:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"r/dxt30P\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723460303;\n\tbh=vxC4cuasO+RBOQNuJV38eBbZcB7qfVpor5tcBEKNNN8=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=r/dxt30P6Nqqn4I9UEOoExiFmvSVQi9WzzMecvLrA967V9EbMogDl1mG6AW6uCilZ\n\thyEmYR00TcolF3unAhXzysbmdcMyvN3GIRQvOoItrmBPJioAqSOQoB7CUDte7DFql4\n\tmPnE1EIRSQk9WxR8Gx6pkdyDSWwnMUyTXhUtaFSg=","Message-ID":"","Date":"Mon, 12 Aug 2024 11:59:16 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 2/2] libcamera: add missing include to\n\tinternal/yaml_parser.h","To":"libcamera-devel@lists.libcamera.org","References":"<20240804114336.GK3319@pendragon.ideasonboard.com>\n\t<20240804205544.2500138-1-slyich@gmail.com>\n\t<20240804205544.2500138-2-slyich@gmail.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240804205544.2500138-2-slyich@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]