[{"id":30563,"web_url":"https://patchwork.libcamera.org/comment/30563/","msgid":"<20240804114336.GK3319@pendragon.ideasonboard.com>","date":"2024-08-04T11:43:36","subject":"Re: [PATCH 1/2] include/libcamera/base/file.h: add missing\n\t include","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Sergei,\n\nThank you for the patch.\n\nThe subject line should read\n\n\"libcamera: base: file: Add missing include\"\n\nto match the usual style.\n\nOn Sun, Aug 04, 2024 at 07:03:59AM +0100, Sergei Trofimovich wrote:\n> Without the change the build fails on upcoming `gcc-15` as:\n> \n> In file included from ../src/libcamera/base/file.cpp:8:\n> ../include/libcamera/base/file.h:62:33: error: 'uint8_t' was not declared in this scope\n> 62 | ssize_t read(const Span &data);\n> | ^~~~~~~\n\nMuch more importantly, the commit message is missing your Signed-off-by\nline. See https://libcamera.org/contributing.html#submitting-patches\n\nIf it were just for the subject line I would change it myself before\napplying the patch, but the missing SoB will require a v2 I'm afraid.\n\nThese comments apply to patch 2/2 too.\n\n> ---\n> include/libcamera/base/file.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/include/libcamera/base/file.h b/include/libcamera/base/file.h\n> index 5637934c..192668ab 100644\n> --- a/include/libcamera/base/file.h\n> +++ b/include/libcamera/base/file.h\n> @@ -7,6 +7,7 @@\n> \n> #pragma once\n> \n> +#include \n> #include \n> \n> #include \n\nIt looks like sys/types.h was added in the wrong place. Could you, while\nat it, fix that so that all the C and C++ standard includes are grouped\ntogether ? It should look like\n\n#include \n#include \n#include \n#include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 98C34BDC71\n\tfor ;\n\tSun, 4 Aug 2024 11:44:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BD13B6192D;\n\tSun, 4 Aug 2024 13:44:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 408B86192D\n\tfor ;\n\tSun, 4 Aug 2024 13:43:59 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 512EE289;\n\tSun, 4 Aug 2024 13:43:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gbh8SW1G\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722771788;\n\tbh=xiSk9GaSdFGz0Pmh5HTHF9y+6P7I3/4W7CiMSD+Ox3s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gbh8SW1GxIzkzqZ0k4AJ0GXm08TXrHp047gkTby8TMy9zFBwyfPCd3qeD3L0yrqxR\n\tQ3W8OsdFM/52O1nevp0E06WHzlKw33YW1cRsL8uLQYY9rm/+OUsECKqdoxyqb8DDDu\n\tmBGn8jtGZnMRwWAsN8Bk3a37BNF+ExU0gVaVrlCs=","Date":"Sun, 4 Aug 2024 14:43:36 +0300","From":"Laurent Pinchart ","To":"Sergei Trofimovich ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/2] include/libcamera/base/file.h: add missing\n\t include","Message-ID":"<20240804114336.GK3319@pendragon.ideasonboard.com>","References":"<20240804060400.2790695-1-slyich@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240804060400.2790695-1-slyich@gmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30711,"web_url":"https://patchwork.libcamera.org/comment/30711/","msgid":"<20240809221522.64ba15e1@nz.home>","date":"2024-08-09T21:15:22","subject":"Re: [PATCH 1/2] include/libcamera/base/file.h: add missing\n\t include","submitter":{"id":203,"url":"https://patchwork.libcamera.org/api/people/203/","name":"Sergei Trofimovich","email":"slyich@gmail.com"},"content":"On Sun, 4 Aug 2024 14:43:36 +0300\nLaurent Pinchart wrote:\n\n> Hi Sergei,\n> \n> Thank you for the patch.\n> \n> The subject line should read\n> \n> \"libcamera: base: file: Add missing include\"\n> \n> to match the usual style.\n> \n> On Sun, Aug 04, 2024 at 07:03:59AM +0100, Sergei Trofimovich wrote:\n> > Without the change the build fails on upcoming `gcc-15` as:\n> > \n> > In file included from ../src/libcamera/base/file.cpp:8:\n> > ../include/libcamera/base/file.h:62:33: error: 'uint8_t' was not declared in this scope\n> > 62 | ssize_t read(const Span &data);\n> > | ^~~~~~~ \n> \n> Much more importantly, the commit message is missing your Signed-off-by\n> line. See https://libcamera.org/contributing.html#submitting-patches\n> \n> If it were just for the subject line I would change it myself before\n> applying the patch, but the missing SoB will require a v2 I'm afraid.\n> \n> These comments apply to patch 2/2 too.\n\nThank you, Laurent! Recent both as a follow up with tweaked subject and\nadded SOB a few days ago as:\n\n https://lists.libcamera.org/pipermail/libcamera-devel/2024-August/043744.html\n\n> > ---\n> > include/libcamera/base/file.h | 1 +\n> > 1 file changed, 1 insertion(+)\n> > \n> > diff --git a/include/libcamera/base/file.h b/include/libcamera/base/file.h\n> > index 5637934c..192668ab 100644\n> > --- a/include/libcamera/base/file.h\n> > +++ b/include/libcamera/base/file.h\n> > @@ -7,6 +7,7 @@\n> > \n> > #pragma once\n> > \n> > +#include \n> > #include \n> > \n> > #include \n> \n> It looks like sys/types.h was added in the wrong place. Could you, while\n> at it, fix that so that all the C and C++ standard includes are grouped\n> together ? It should look like\n> \n> #include \n> #include \n> #include \n> #include \n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E734C323E\n\tfor ;\n\tFri, 9 Aug 2024 21:15:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12D3A633B3;\n\tFri, 9 Aug 2024 23:15:26 +0200 (CEST)","from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com\n\t[IPv6:2a00:1450:4864:20::32a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99B4F63394\n\tfor ;\n\tFri, 9 Aug 2024 23:15:24 +0200 (CEST)","by mail-wm1-x32a.google.com with SMTP id\n\t5b1f17b1804b1-427fc97a88cso18378855e9.0\n\tfor ;\n\tFri, 09 Aug 2024 14:15:24 -0700 (PDT)","from nz.home ([2a00:23c8:a613:101:4861:aa22:93d7:3b8b])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4290c72d4c9sm92185805e9.8.2024.08.09.14.15.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 09 Aug 2024 14:15:23 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ii3EOcvq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1723238124; x=1723842924;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:subject:cc:to:from:date:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=+QjfCGAnlypgn2tZVKl8bkLgZTlRX0zVvlfU+NFOvTY=;\n\tb=ii3EOcvqZtrVyH39sxu0q58DWjI2Thxo9eaK5OJFW4Jf7A69258a0sAR9BGN4/9yO3\n\tnUAIV43gIPrwHrDDfcRKq7xDXra5zhBpkAKCZnTbnOc7WJku6qFLSBEzL6iTvPMYg9Ig\n\tJlEtph4pXTWubxtQ8mbL/GH8zb+IDyJ7MB/cRwlancFBxIYw6IysCsRqHuiocxgelINi\n\tM2vbnAkJSRHqfg1yVpqAOSc+l8jiX/5/O6E/ewvAElr0lzGG0u3hzezDxC+C1KPlY8qR\n\tGeFmYxGAPkQgeXwSiLAYumBcUSK1C+7P9nZ/CxtU/4/7qvEQxhIuuBlJJJbll6zVYoO+\n\tNjcQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1723238124; x=1723842924;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=+QjfCGAnlypgn2tZVKl8bkLgZTlRX0zVvlfU+NFOvTY=;\n\tb=hOZfJ8MfznMr52E66JSKkeqEtIN3uHsYBhuCjyQ84oEvxfhU6XYkXw05Whu5DNgAr1\n\txYXC06oi2XOKI7uh71iw8/m0w86DnChLCXfbPX/PqidIueT1gbHIXq9w/ZgW6/SJOR1p\n\toQ0BRl0+SPwQIKY/rv0hxPNnKVIeUXB/X/g+2Q8K8s2mE4Vo9qk+zNcolvD9tKKaGW5k\n\tee7xy1Jvsd9wXfuJHcNPjY8CdfZK8h/Y6fElgFJ+UhsmN2di6TEa+bfmPwzX7F24D81g\n\tWiKVy7dWMzUgYCGLmufsRLU2sSvqSCBmMc7/2rgPPNiqr0T1E6hmzBi85xdsiGkgozEx\n\t3vtQ==","X-Gm-Message-State":"AOJu0YxLaSCzQ2CR6volnuZCFfem+EOxifyPfQPQ+qLSCU8TPChvz22W\n\tXgdUYB7lqSd0DpXXE50MfOrX8ZOBr5MTPcaXhIM7WB7d9RNScUWE","X-Google-Smtp-Source":"AGHT+IGqe5yBJN4kPAs9Lct/Tn4oiajmCq4k7Zbz8NgwxN16yfbxGwQJCAR7ko+niFlfrpnFQaM0JA==","X-Received":"by 2002:a05:600c:444a:b0:426:6153:5318 with SMTP id\n\t5b1f17b1804b1-429c3a29800mr20072585e9.19.1723238123605; \n\tFri, 09 Aug 2024 14:15:23 -0700 (PDT)","Date":"Fri, 9 Aug 2024 22:15:22 +0100","From":"Sergei Trofimovich ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/2] include/libcamera/base/file.h: add missing\n\t include","Message-ID":"<20240809221522.64ba15e1@nz.home>","In-Reply-To":"<20240804114336.GK3319@pendragon.ideasonboard.com>","References":"<20240804060400.2790695-1-slyich@gmail.com>\n\t<20240804114336.GK3319@pendragon.ideasonboard.com>","X-Mailer":"Claws Mail 4.3.0 (GTK 3.24.43; x86_64-pc-linux-gnu)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30714,"web_url":"https://patchwork.libcamera.org/comment/30714/","msgid":"<20240809220534.GC9967@pendragon.ideasonboard.com>","date":"2024-08-09T22:05:34","subject":"Re: [PATCH 1/2] include/libcamera/base/file.h: add missing\n\t include","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Aug 09, 2024 at 10:15:22PM +0100, Sergei Trofimovich wrote:\n> On Sun, 4 Aug 2024 14:43:36 +0300 Laurent Pinchart wrote:\n> \n> > Hi Sergei,\n> > \n> > Thank you for the patch.\n> > \n> > The subject line should read\n> > \n> > \"libcamera: base: file: Add missing include\"\n> > \n> > to match the usual style.\n> > \n> > On Sun, Aug 04, 2024 at 07:03:59AM +0100, Sergei Trofimovich wrote:\n> > > Without the change the build fails on upcoming `gcc-15` as:\n> > > \n> > > In file included from ../src/libcamera/base/file.cpp:8:\n> > > ../include/libcamera/base/file.h:62:33: error: 'uint8_t' was not declared in this scope\n> > > 62 | ssize_t read(const Span &data);\n> > > | ^~~~~~~ \n> > \n> > Much more importantly, the commit message is missing your Signed-off-by\n> > line. See https://libcamera.org/contributing.html#submitting-patches\n> > \n> > If it were just for the subject line I would change it myself before\n> > applying the patch, but the missing SoB will require a v2 I'm afraid.\n> > \n> > These comments apply to patch 2/2 too.\n> \n> Thank you, Laurent! Recent both as a follow up with tweaked subject and\n> added SOB a few days ago as:\n> \n> https://lists.libcamera.org/pipermail/libcamera-devel/2024-August/043744.html\n\nI've reviewed v2, and I'll push it early next week.\n\n> > > ---\n> > > include/libcamera/base/file.h | 1 +\n> > > 1 file changed, 1 insertion(+)\n> > > \n> > > diff --git a/include/libcamera/base/file.h b/include/libcamera/base/file.h\n> > > index 5637934c..192668ab 100644\n> > > --- a/include/libcamera/base/file.h\n> > > +++ b/include/libcamera/base/file.h\n> > > @@ -7,6 +7,7 @@\n> > > \n> > > #pragma once\n> > > \n> > > +#include \n> > > #include \n> > > \n> > > #include \n> > \n> > It looks like sys/types.h was added in the wrong place. Could you, while\n> > at it, fix that so that all the C and C++ standard includes are grouped\n> > together ? It should look like\n> > \n> > #include \n> > #include \n> > #include \n> > #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 814DEC323E\n\tfor ;\n\tFri, 9 Aug 2024 22:06:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 31EB6633BA;\n\tSat, 10 Aug 2024 00:06:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6567463398\n\tfor ;\n\tSat, 10 Aug 2024 00:05:58 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D3CCC8CC;\n\tSat, 10 Aug 2024 00:05:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MvPSjC0s\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723241104;\n\tbh=XYXIeF4QBupvGnsVCbQiVgGgpMoXJ2UjRKVGd9gAhMc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MvPSjC0syCr1tKGLHTYxHvExG0DW9t49znGT5iQpkLF0FAlRkOLpIFTKASI/vTbLi\n\tDEYiUm2oLK74SK2VD0pbjK1GGtcg2CvykRr9BK+97VIIJoV87ShFxknbvwxmE3Ep/s\n\twOT38nDM5MeO3c0KU3OGYtp/oO/Cjy4zQV8Qj9+g=","Date":"Sat, 10 Aug 2024 01:05:34 +0300","From":"Laurent Pinchart ","To":"Sergei Trofimovich ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/2] include/libcamera/base/file.h: add missing\n\t include","Message-ID":"<20240809220534.GC9967@pendragon.ideasonboard.com>","References":"<20240804060400.2790695-1-slyich@gmail.com>\n\t<20240804114336.GK3319@pendragon.ideasonboard.com>\n\t<20240809221522.64ba15e1@nz.home>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240809221522.64ba15e1@nz.home>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]