[{"id":30578,"web_url":"https://patchwork.libcamera.org/comment/30578/","msgid":"<87cymnpb8k.fsf@redhat.com>","date":"2024-08-05T09:31:07","subject":"Re: [PATCH] ipa: libipa: camera_sensor_helper: Reference\n\tblackLevel() in documentation","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Laurent Pinchart writes:\n\n> The documentation for the blackLevel_ member is very terse. Reference\n> the more complete documentation of the sibling blackLevel() member\n> function to provide more information.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 2f6e7282ad7f..c07b1a8dcaec 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -235,6 +235,7 @@ double CameraSensorHelper::gain(uint32_t gainCode) const\n> /**\n> * \\var CameraSensorHelper::blackLevel_\n> * \\brief The black level of the sensor\n> + * \\sa CameraSensorHelper::blackLevel()\n> */\n> \n> /**\n>\n> base-commit: 19bbca3c0b376ba0183f5db53472c8c46cd402b5","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7DB3CC323E\n\tfor ;\n\tMon, 5 Aug 2024 09:31:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A35863380;\n\tMon, 5 Aug 2024 11:31:16 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 08C636191F\n\tfor ;\n\tMon, 5 Aug 2024 11:31:13 +0200 (CEST)","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n\t[209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-421-3vLNEWfmOvuU5XFTb71bNQ-1; Mon, 05 Aug 2024 05:31:11 -0400","by mail-wr1-f71.google.com with SMTP id\n\tffacd0b85a97d-36863648335so5043840f8f.0\n\tfor ;\n\tMon, 05 Aug 2024 02:31:11 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-36bbd059948sm9207583f8f.87.2024.08.05.02.31.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 05 Aug 2024 02:31:08 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"MmL7TwHx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1722850272;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Bdz8BrqDxVOA3YCM/3FU62FIgHTAdNlifSrsc1+0Fkk=;\n\tb=MmL7TwHxUtmpOUP9R+o3Sc/vBwcZ0TIaxZt6aohPgqTu6dtghnNsBY2oqcCci3ANEXTGnB\n\t54BklYJB/WQdD90LqcCbCblTY/9o6d2lmZIYUSRpaVecgYBa4D1+AnrdDR+2poblmsjjQC\n\tRuSFrYUgISotI17Zo6yvXoY15STspKs=","X-MC-Unique":"3vLNEWfmOvuU5XFTb71bNQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1722850269; x=1723455069;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Bdz8BrqDxVOA3YCM/3FU62FIgHTAdNlifSrsc1+0Fkk=;\n\tb=Qj0r7lrvItJxD8xZJ5QETrYWBFnsxoHHl1VB8AoFdLNlI0Ug2d3PJEFnospKNBtuAb\n\tsSRvemEcoDRwXpM05dg1/LL+G9iX6BOFpjEIdfcDJjldeqhV2Yi+4PiVy+r5rMSEJ8Py\n\tQJZ11zWFAOvyPeAWJyaou3F3ciuZGY4d/cY4xEDa2IF4c1NMvtQtwXb50wYYG8OGdWgD\n\t3OLR1RpDxeUulWfVRF2COYH4e78pXPn7HsU+SbFg9Z1DrZGYy6q+7nLdqlMy8xn9+otm\n\tAUtN1b7SxJ+w+Jqt920l6bZsXIpIa37vOPszKngi7VhUpwgiGpp9OgQm39DcOk4TzhOS\n\tzxsg==","X-Gm-Message-State":"AOJu0YzLij2XJTj2v2J7Uv9WUOxOsJNh5AFjAm4x9uNenBToupG9BH7u\n\tDw50xmsVojzHdvo64M6MjSuTFQhz4hS1JR3WaeRQVXYZuAOpXbScwSS/yUM6fEbGq29V9Tew5a9\n\tc2uTNHywj69VWX+Njd7rQC3xfv+Kz+757hp4zBy6boTPpFKgIek1SyOD8Aulyy1VMr+RcdnCpim\n\tcmrGMqrY5iTHoiFJvPQZ2JzLnAolo78JRt4Dj1DE9dBdi7Lq5osKHLMls=","X-Received":["by 2002:adf:f345:0:b0:368:3f13:22fe with SMTP id\n\tffacd0b85a97d-36bbc0e5fa7mr8330422f8f.23.1722850269616; \n\tMon, 05 Aug 2024 02:31:09 -0700 (PDT)","by 2002:adf:f345:0:b0:368:3f13:22fe with SMTP id\n\tffacd0b85a97d-36bbc0e5fa7mr8330396f8f.23.1722850269080; \n\tMon, 05 Aug 2024 02:31:09 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IFECsSHYAb82Bhh2wrjYcR1YCsh8sIIDwWcLt97rGguqR8lrc25LhGXCbATKYPXhGXC5Vlhww==","From":"Milan Zamazal ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] ipa: libipa: camera_sensor_helper: Reference\n\tblackLevel() in documentation","In-Reply-To":"<20240803213004.23410-1-laurent.pinchart@ideasonboard.com>\n\t(Laurent Pinchart's message of \"Sun, 4 Aug 2024 00:30:03 +0300\")","References":"<20240803213004.23410-1-laurent.pinchart@ideasonboard.com>","Date":"Mon, 05 Aug 2024 11:31:07 +0200","Message-ID":"<87cymnpb8k.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30588,"web_url":"https://patchwork.libcamera.org/comment/30588/","msgid":"<172285766820.372468.9466447130472794892@ping.linuxembedded.co.uk>","date":"2024-08-05T11:34:28","subject":"Re: [PATCH] ipa: libipa: camera_sensor_helper: Reference\n\tblackLevel() in documentation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2024-08-05 10:31:07)\n> Laurent Pinchart writes:\n> \n> > The documentation for the blackLevel_ member is very terse. Reference\n> > the more complete documentation of the sibling blackLevel() member\n> > function to provide more information.\n> >\n> > Signed-off-by: Laurent Pinchart \n> \n> Reviewed-by: Milan Zamazal \n\nReviewed-by: Kieran Bingham \n\n> \n> > ---\n> > src/ipa/libipa/camera_sensor_helper.cpp | 1 +\n> > 1 file changed, 1 insertion(+)\n> >\n> > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> > index 2f6e7282ad7f..c07b1a8dcaec 100644\n> > --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> > +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> > @@ -235,6 +235,7 @@ double CameraSensorHelper::gain(uint32_t gainCode) const\n> > /**\n> > * \\var CameraSensorHelper::blackLevel_\n> > * \\brief The black level of the sensor\n> > + * \\sa CameraSensorHelper::blackLevel()\n> > */\n> > \n> > /**\n> >\n> > base-commit: 19bbca3c0b376ba0183f5db53472c8c46cd402b5\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F322C323E\n\tfor ;\n\tMon, 5 Aug 2024 11:34:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7A89A63369;\n\tMon, 5 Aug 2024 13:34:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 913426195D\n\tfor ;\n\tMon, 5 Aug 2024 13:34:30 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1EA581A2;\n\tMon, 5 Aug 2024 13:33:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"n25uJ4Je\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722857619;\n\tbh=53P+5L8KtxMc2cAoClm84t58rOWb+xwbepjtnclEeIA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=n25uJ4JeFsJ992v9MaabfdqojPlGVnmc65ru6NqPNN73xQAs4od9ttMvOIrJEdHPj\n\tXOySGYSK5EFXgR/1bsAP6H2ZuJZ+m+Z/YN+w3k5iVDA7hXRI09ZME2vntucw5Qa8Hw\n\tONkZtwTr2IIBkIgjVbVr6WESBIOFcQ6Sooe6GZIM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<87cymnpb8k.fsf@redhat.com>","References":"<20240803213004.23410-1-laurent.pinchart@ideasonboard.com>\n\t<87cymnpb8k.fsf@redhat.com>","Subject":"Re: [PATCH] ipa: libipa: camera_sensor_helper: Reference\n\tblackLevel() in documentation","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Laurent Pinchart ,\n\tMilan Zamazal ","Date":"Mon, 05 Aug 2024 12:34:28 +0100","Message-ID":"<172285766820.372468.9466447130472794892@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]