[{"id":30569,"web_url":"https://patchwork.libcamera.org/comment/30569/","msgid":"","date":"2024-08-05T06:05:04","subject":"Re: [PATCH] meson: Drop gcc 8 support","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch.\n\nOn 04/08/24 2:38 am, Laurent Pinchart wrote:\n> The libcamera CI has retired gcc 8 testing with the end of life of\n> Debian Buster at the end of June 2024. As gcc 8 isn't tested anymore, we\n> can't guarantee it will keep building libcamera correctly. Drop its\n> support. If anyone still has a compeling use case for gcc 8 support for\n\ns/compeling/compelling/\n> libcamera, we will investigate how to restore it in CI.\n>\n> Signed-off-by: Laurent Pinchart\n\nReviewed-by: Umang Jain \n\n> ---\n> meson.build | 10 +---------\n> 1 file changed, 1 insertion(+), 9 deletions(-)\n>\n> diff --git a/meson.build b/meson.build\n> index 316abdb84e92..59293e478b00 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -146,16 +146,8 @@ if cc.get_id() == 'clang'\n> endif\n> \n> if cc.get_id() == 'gcc'\n> - if cc.version().version_compare('<8')\n> - error('gcc version is too old, libcamera requires 8.0 or newer')\n> - endif\n> -\n> - # On gcc 8, the file system library is provided in a separate static\n> - # library.\n> if cc.version().version_compare('<9')\n> - cpp_arguments += [\n> - '-lstdc++fs',\n> - ]\n> + error('gcc version is too old, libcamera requires 9.0 or newer')\n> endif\n> \n> # gcc 13 implements the C++23 version of automatic move from local\n>\n> base-commit: 19bbca3c0b376ba0183f5db53472c8c46cd402b5","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB925C323E\n\tfor ;\n\tMon, 5 Aug 2024 06:05:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E7F9663381;\n\tMon, 5 Aug 2024 08:05:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0ACAF6337C\n\tfor ;\n\tMon, 5 Aug 2024 08:05:09 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6DC9AA06;\n\tMon, 5 Aug 2024 08:04:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hKopzPhW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722837857;\n\tbh=9+TjJN+y/0ZD/sbTRhMhAzEk9jZadsYhTQpQ7nyA/Q8=;\n\th=Date:From:Subject:To:References:In-Reply-To:From;\n\tb=hKopzPhWY0VwTZY5ioFSJM8FipfOO+Rv0rsb0DUd4L0tUxPLsc0EXQJshdnimJILQ\n\tDU5+vjV/OsyG1Ac+UL71B6Pu0GSm7BOriNURix/sj6YM4RoWJ7dDc9iXz2EZrDIIJz\n\txT2ZwbS6Sqikr7NDPKp9o9HLibeTamHIFSCt+GzQ=","Message-ID":"","Date":"Mon, 5 Aug 2024 11:35:04 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","From":"Umang Jain ","Subject":"Re: [PATCH] meson: Drop gcc 8 support","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20240803210846.18224-1-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","In-Reply-To":"<20240803210846.18224-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30574,"web_url":"https://patchwork.libcamera.org/comment/30574/","msgid":"<172284801525.372468.10954416999278497060@ping.linuxembedded.co.uk>","date":"2024-08-05T08:53:35","subject":"Re: [PATCH] meson: Drop gcc 8 support","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-08-03 22:08:46)\n> The libcamera CI has retired gcc 8 testing with the end of life of\n> Debian Buster at the end of June 2024. As gcc 8 isn't tested anymore, we\n> can't guarantee it will keep building libcamera correctly. Drop its\n> support. If anyone still has a compeling use case for gcc 8 support for\n> libcamera, we will investigate how to restore it in CI.\n> \n> Signed-off-by: Laurent Pinchart \n\nAcked-by: Kieran Bingham \n\n> ---\n> meson.build | 10 +---------\n> 1 file changed, 1 insertion(+), 9 deletions(-)\n> \n> diff --git a/meson.build b/meson.build\n> index 316abdb84e92..59293e478b00 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -146,16 +146,8 @@ if cc.get_id() == 'clang'\n> endif\n> \n> if cc.get_id() == 'gcc'\n> - if cc.version().version_compare('<8')\n> - error('gcc version is too old, libcamera requires 8.0 or newer')\n> - endif\n> -\n> - # On gcc 8, the file system library is provided in a separate static\n> - # library.\n> if cc.version().version_compare('<9')\n> - cpp_arguments += [\n> - '-lstdc++fs',\n> - ]\n> + error('gcc version is too old, libcamera requires 9.0 or newer')\n> endif\n> \n> # gcc 13 implements the C++23 version of automatic move from local\n> \n> base-commit: 19bbca3c0b376ba0183f5db53472c8c46cd402b5\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1321CBE173\n\tfor ;\n\tMon, 5 Aug 2024 08:53:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 372726195A;\n\tMon, 5 Aug 2024 10:53:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4FECC6191F\n\tfor ;\n\tMon, 5 Aug 2024 10:53:38 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F12A5581;\n\tMon, 5 Aug 2024 10:52:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"o91E7Q6w\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722847967;\n\tbh=r6VbRsCMwXvyL0nXAsex/JR3M9j85f22H3hwMjrvQR8=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=o91E7Q6wPQtA+s+6PAbred/vr3SlsvqyKu/2qABNFNgMjEKgWnfnqcIfLHjUGhJdf\n\tKREqL4tZmA6GJoMowvCmPnbQvYbjT7xCkR/iy0ouXOUkSFcDSaz4wxrbbKJohhq6mx\n\t0J7aCjlFxDB+9KdMhihsntm05VTPOeYqRQlfUomU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240803210846.18224-1-laurent.pinchart@ideasonboard.com>","References":"<20240803210846.18224-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH] meson: Drop gcc 8 support","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 05 Aug 2024 09:53:35 +0100","Message-ID":"<172284801525.372468.10954416999278497060@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]