[{"id":2737,"web_url":"https://patchwork.libcamera.org/comment/2737/","msgid":"<20191001010436.GA4739@pendragon.ideasonboard.com>","date":"2019-10-01T01:04:36","subject":"Re: [libcamera-devel] [PATCH v3 3/3] qcam: Fix timers not emitting\n\ttimeout signal","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Sep 30, 2019 at 11:59:06PM +0200, Niklas Söderlund wrote:\n> The timer signal was never emitted in QtEventDispatcher::timerEvent(),\n> this results in timers not working as designed running under the Qt\n> event loop. Fix this by emitting the signal on timeout.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/qcam/qt_event_dispatcher.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/qcam/qt_event_dispatcher.cpp b/src/qcam/qt_event_dispatcher.cpp\n> index 43588ef081a3f633..d7d1fed290851e6e 100644\n> --- a/src/qcam/qt_event_dispatcher.cpp\n> +++ b/src/qcam/qt_event_dispatcher.cpp\n> @@ -134,6 +134,7 @@ void QtEventDispatcher::timerEvent(QTimerEvent *event)\n> \tTimer *timer = it->second;\n> \n> \ttimer->stop();\n> +\ttimer->timeout.emit(timer);\n> }\n> \n> void QtEventDispatcher::processEvents()","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 21A5261654\n\tfor ;\n\tTue, 1 Oct 2019 03:04:50 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(modemcable151.96-160-184.mc.videotron.ca [184.160.96.151])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 267872BB;\n\tTue, 1 Oct 2019 03:04:48 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1569891889;\n\tbh=H6Azx/QVpjGFth4/0qDG3T9GJ6/V/vFz+9PvXYX22ZE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rbq36Lfe0t1Kh6j/s5zkgPKucTwrgZlRkirMVlXhRtllNz6OikxsqxxSktDLbK/0+\n\t+dacRijlF6gq58MWPyMmzJi5TzVyNG/WXMfOupPg1n8lMnD/kd/nGu2ceFUEF/g6cL\n\trxcK2vxY1KUGBkG2OdsfgQR6ioDt6cVB4fefoLTw=","Date":"Tue, 1 Oct 2019 04:04:36 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191001010436.GA4739@pendragon.ideasonboard.com>","References":"<20190930215906.1058301-1-niklas.soderlund@ragnatech.se>\n\t<20190930215906.1058301-4-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190930215906.1058301-4-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 3/3] qcam: Fix timers not emitting\n\ttimeout signal","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 01 Oct 2019 01:04:50 -0000"}}]