{"id":2075,"url":"https://patchwork.libcamera.org/api/patches/2075/?format=json","web_url":"https://patchwork.libcamera.org/patch/2075/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190930215906.1058301-4-niklas.soderlund@ragnatech.se>","date":"2019-09-30T21:59:06","name":"[libcamera-devel,v3,3/3] qcam: Fix timers not emitting timeout signal","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"fe88b6bd789405da79493f4218bf042289d32f61","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2075/mbox/","series":[{"id":514,"url":"https://patchwork.libcamera.org/api/series/514/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=514","date":"2019-09-30T21:59:03","name":"qcam: Fix issues in the Qt event dispatcher","version":3,"mbox":"https://patchwork.libcamera.org/series/514/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2075/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2075/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD3E061658\n\tfor ;\n\tMon, 30 Sep 2019 23:59:51 +0200 (CEST)","from bismarck.berto.se (unknown [84.172.88.101])\n\tby bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 90c2f444-e3cd-11e9-bdc3-005056917a89;\n\tMon, 30 Sep 2019 23:59:25 +0200 (CEST)"],"X-Halon-ID":"90c2f444-e3cd-11e9-bdc3-005056917a89","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 30 Sep 2019 23:59:06 +0200","Message-Id":"<20190930215906.1058301-4-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.23.0","In-Reply-To":"<20190930215906.1058301-1-niklas.soderlund@ragnatech.se>","References":"<20190930215906.1058301-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 3/3] qcam: Fix timers not emitting\n\ttimeout signal","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 30 Sep 2019 21:59:52 -0000"},"content":"The timer signal was never emitted in QtEventDispatcher::timerEvent(),\nthis results in timers not working as designed running under the Qt\nevent loop. Fix this by emitting the signal on timeout.\n\nSigned-off-by: Niklas Söderlund \n---\n src/qcam/qt_event_dispatcher.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/qcam/qt_event_dispatcher.cpp b/src/qcam/qt_event_dispatcher.cpp\nindex 43588ef081a3f633..d7d1fed290851e6e 100644\n--- a/src/qcam/qt_event_dispatcher.cpp\n+++ b/src/qcam/qt_event_dispatcher.cpp\n@@ -134,6 +134,7 @@ void QtEventDispatcher::timerEvent(QTimerEvent *event)\n \tTimer *timer = it->second;\n \n \ttimer->stop();\n+\ttimer->timeout.emit(timer);\n }\n \n void QtEventDispatcher::processEvents()\n","prefixes":["libcamera-devel","v3","3/3"]}