[{"id":30577,"web_url":"https://patchwork.libcamera.org/comment/30577/","msgid":"<87h6bzpby4.fsf@redhat.com>","date":"2024-08-05T09:15:47","subject":"Re: [PATCH] libcamera: Remove spaces at end of lines","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Laurent,\n\nthank you for the cleanup.\n\nLaurent Pinchart writes:\n\n> Spaces at end of lines have cropped up in a few places in libcamera.\n> Remove them.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Milan Zamazal \n\n(The other occurrences either make sense or are copied from elsewhere.)\n\n> ---\n> .clang-format | 4 ++--\n> Documentation/coding-style.rst | 2 +-\n> Documentation/environment_variables.rst | 4 ++--\n> src/libcamera/control_ids_core.yaml | 4 ++--\n> 4 files changed, 7 insertions(+), 7 deletions(-)\n>\n> diff --git a/.clang-format b/.clang-format\n> index f2b44e87d4fb..7fc30f614ab1 100644\n> --- a/.clang-format\n> +++ b/.clang-format\n> @@ -80,7 +80,7 @@ IncludeCategories:\n> # Headers in <> with an extension. (+system libraries)\n> - Regex: '<([A-Za-z0-9\\-_])+\\.h>'\n> Priority: 2\n> - # System headers \n> + # System headers\n> - Regex: ''\n> Priority: 2\n> # C++ standard library includes (no extension)\n> @@ -100,7 +100,7 @@ IncludeCategories:\n> # IPA Interfaces\n> - Regex: ''\n> Priority: 7\n> - # libcamera Internal headers in \"\" \n> + # libcamera Internal headers in \"\"\n> - Regex: '\"libcamera/internal/.*\\.h\"'\n> Priority: 8\n> # Other libraries headers with one group per library (.h or .hpp)\n> diff --git a/Documentation/coding-style.rst b/Documentation/coding-style.rst\n> index 72cb28d25189..3352b75c76c8 100644\n> --- a/Documentation/coding-style.rst\n> +++ b/Documentation/coding-style.rst\n> @@ -215,7 +215,7 @@ shall be avoided when possible, but are allowed when required (for instance to\n> implement factories with auto-registration). They shall not depend on any other\n> global variable, should run a minimal amount of code in the constructor and\n> destructor, and code that contains dependencies should be moved to a later\n> -point in time. \n> +point in time.\n> \n> Error Handling\n> ~~~~~~~~~~~~~~\n> diff --git a/Documentation/environment_variables.rst b/Documentation/environment_variables.rst\n> index 7cc13e9f3808..de434c386707 100644\n> --- a/Documentation/environment_variables.rst\n> +++ b/Documentation/environment_variables.rst\n> @@ -39,9 +39,9 @@ LIBCAMERA_IPA_MODULE_PATH\n> \n> LIBCAMERA_IPA_PROXY_PATH\n> Define custom full path for a proxy worker for a given executable name.\n> - \n> +\n> Example value: ``${HOME}/.libcamera/proxy/worker:/opt/libcamera/vendor/proxy/worker``\n> - \n> +\n> LIBCAMERA_PIPELINES_MATCH_LIST\n> Define an ordered list of pipeline names to be used to match the media\n> devices in the system. The pipeline handler names used to populate the\n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index 9d413a94e0ee..cf40771d3896 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -868,8 +868,8 @@ controls:\n> - Gamma:\n> type: float\n> description: |\n> - Specify a fixed gamma value. Default must be 2.2 which closely mimics \n> - sRGB gamma. Note that this is camera gamma, so it is applied as \n> + Specify a fixed gamma value. Default must be 2.2 which closely mimics\n> + sRGB gamma. Note that this is camera gamma, so it is applied as\n> 1.0/gamma.\n> \n> ...\n>\n> base-commit: 19bbca3c0b376ba0183f5db53472c8c46cd402b5","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D17CBE173\n\tfor ;\n\tMon, 5 Aug 2024 09:15:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7BC0963383;\n\tMon, 5 Aug 2024 11:15:55 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9CDFA6195A\n\tfor ;\n\tMon, 5 Aug 2024 11:15:53 +0200 (CEST)","from mail-ej1-f70.google.com (mail-ej1-f70.google.com\n\t[209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-518-c4Oc1XExNviIBGWlUZbB4w-1; Mon, 05 Aug 2024 05:15:50 -0400","by mail-ej1-f70.google.com with SMTP id\n\ta640c23a62f3a-a6f571c3eefso602306566b.2\n\tfor ;\n\tMon, 05 Aug 2024 02:15:50 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-a7dc9c0ca00sm427576066b.68.2024.08.05.02.15.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 05 Aug 2024 02:15:47 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Rn+7U4Cf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1722849352;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=WgCDxi4xVkSUu6lmaPgBLXJdZy1qkWdtS7erCyR8uiE=;\n\tb=Rn+7U4CfS+reflJqlnwMHqjMw1PGMguzivMxprvJiAtFpDqiKWlR2keokdOqSUlUj5KqGi\n\tKw1ZrtDrUXbb3LZZtQAM9wd/U6P890IDK+thckXA03qw8+9sgFf3GP7hgvSXni9JKMljT/\n\tAgTq7QDeU8UMAi3vgJto0TAluHBp6ZY=","X-MC-Unique":"c4Oc1XExNviIBGWlUZbB4w-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1722849349; x=1723454149;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=WgCDxi4xVkSUu6lmaPgBLXJdZy1qkWdtS7erCyR8uiE=;\n\tb=PbC0iPemWzinQsmLHHh39TKbWwIJXjjB8OfuQUDhy1pbQT3l0dU0O3ODhLrXBuzLyq\n\tT1fWuUZFggAc/QA+jLF4cDUsTVaVU2RQwvf0gsGDcqGn/+J9XvHTJay1e36bPOh6U9oM\n\t6z3YAp8HSMdJg2g3H9EOx2bCIp+Zco8hjkTTs7ZGknRhr+eHS8NNCFBPjST4IzeRfAMX\n\t8Hu6Lo6guAZPToR/wHerFjcgqxzmb4iIx+LFMC2n16xDXVb2UYWxDhgo3fJiiwNKTZKt\n\tHkO5ywABG9T3OPJLX8Z/wNIFq5Mw7Pxbesl//+9Z4F/1ZnH2qejMznpXnjtHmLzHtVB3\n\tNpdg==","X-Gm-Message-State":"AOJu0Yy5WR1GM9DzqVznM6fkfIhi1Cy/q4cLPcmuA5tAxEMpzSEEuQgy\n\tyzPG7TwtPo0K2Uia9zVFoGqR/eKyldB6jaDd5hzrTPKbNK74mgxO+NmHMOmeoNu4DTvUwjW2XDZ\n\taHSgkhK1Lc4vlBHGWwPMlxGgprui7uF5eCEx0eE1V84kjrqUfN+RmgrulkpFCHeYAfEz9nbvoc/\n\tcj2ABXgxkBBZbrIehhE/lySmsuimY49iw1RvZ4OlFg0m1eRLfX4yAXZAI=","X-Received":["by 2002:a17:906:c156:b0:a77:d1ea:ab26 with SMTP id\n\ta640c23a62f3a-a7dc5105151mr765592866b.65.1722849348940; \n\tMon, 05 Aug 2024 02:15:48 -0700 (PDT)","by 2002:a17:906:c156:b0:a77:d1ea:ab26 with SMTP id\n\ta640c23a62f3a-a7dc5105151mr765589866b.65.1722849348447; \n\tMon, 05 Aug 2024 02:15:48 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IEDii9iCYncBbJB2K4tgsJ6J9AnJlBkiEp7yh9KIhC556RWbrW5i/iJgtaNkjw6BVfVXeScQQ==","From":"Milan Zamazal ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: Remove spaces at end of lines","In-Reply-To":"<20240803195505.842-1-laurent.pinchart@ideasonboard.com>\n\t(Laurent Pinchart's message of \"Sat, 3 Aug 2024 22:55:05 +0300\")","References":"<20240803195505.842-1-laurent.pinchart@ideasonboard.com>","Date":"Mon, 05 Aug 2024 11:15:47 +0200","Message-ID":"<87h6bzpby4.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30589,"web_url":"https://patchwork.libcamera.org/comment/30589/","msgid":"<172285772656.372468.11660874225404205761@ping.linuxembedded.co.uk>","date":"2024-08-05T11:35:26","subject":"Re: [PATCH] libcamera: Remove spaces at end of lines","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-08-03 20:55:05)\n> Spaces at end of lines have cropped up in a few places in libcamera.\n> Remove them.\n> \n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> .clang-format | 4 ++--\n> Documentation/coding-style.rst | 2 +-\n> Documentation/environment_variables.rst | 4 ++--\n> src/libcamera/control_ids_core.yaml | 4 ++--\n> 4 files changed, 7 insertions(+), 7 deletions(-)\n> \n> diff --git a/.clang-format b/.clang-format\n> index f2b44e87d4fb..7fc30f614ab1 100644\n> --- a/.clang-format\n> +++ b/.clang-format\n> @@ -80,7 +80,7 @@ IncludeCategories:\n> # Headers in <> with an extension. (+system libraries)\n> - Regex: '<([A-Za-z0-9\\-_])+\\.h>'\n> Priority: 2\n> - # System headers \n> + # System headers\n> - Regex: ''\n> Priority: 2\n> # C++ standard library includes (no extension)\n> @@ -100,7 +100,7 @@ IncludeCategories:\n> # IPA Interfaces\n> - Regex: ''\n> Priority: 7\n> - # libcamera Internal headers in \"\" \n> + # libcamera Internal headers in \"\"\n> - Regex: '\"libcamera/internal/.*\\.h\"'\n> Priority: 8\n> # Other libraries headers with one group per library (.h or .hpp)\n> diff --git a/Documentation/coding-style.rst b/Documentation/coding-style.rst\n> index 72cb28d25189..3352b75c76c8 100644\n> --- a/Documentation/coding-style.rst\n> +++ b/Documentation/coding-style.rst\n> @@ -215,7 +215,7 @@ shall be avoided when possible, but are allowed when required (for instance to\n> implement factories with auto-registration). They shall not depend on any other\n> global variable, should run a minimal amount of code in the constructor and\n> destructor, and code that contains dependencies should be moved to a later\n> -point in time. \n> +point in time.\n> \n> Error Handling\n> ~~~~~~~~~~~~~~\n> diff --git a/Documentation/environment_variables.rst b/Documentation/environment_variables.rst\n> index 7cc13e9f3808..de434c386707 100644\n> --- a/Documentation/environment_variables.rst\n> +++ b/Documentation/environment_variables.rst\n> @@ -39,9 +39,9 @@ LIBCAMERA_IPA_MODULE_PATH\n> \n> LIBCAMERA_IPA_PROXY_PATH\n> Define custom full path for a proxy worker for a given executable name.\n> - \n> +\n> Example value: ``${HOME}/.libcamera/proxy/worker:/opt/libcamera/vendor/proxy/worker``\n> - \n> +\n> LIBCAMERA_PIPELINES_MATCH_LIST\n> Define an ordered list of pipeline names to be used to match the media\n> devices in the system. The pipeline handler names used to populate the\n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index 9d413a94e0ee..cf40771d3896 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -868,8 +868,8 @@ controls:\n> - Gamma:\n> type: float\n> description: |\n> - Specify a fixed gamma value. Default must be 2.2 which closely mimics \n> - sRGB gamma. Note that this is camera gamma, so it is applied as \n> + Specify a fixed gamma value. Default must be 2.2 which closely mimics\n> + sRGB gamma. Note that this is camera gamma, so it is applied as\n> 1.0/gamma.\n> \n> ...\n> \n> base-commit: 19bbca3c0b376ba0183f5db53472c8c46cd402b5\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B37B6C323E\n\tfor ;\n\tMon, 5 Aug 2024 11:35:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5FD1963383;\n\tMon, 5 Aug 2024 13:35:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7EFE56195D\n\tfor ;\n\tMon, 5 Aug 2024 13:35:29 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 34B5D1A2;\n\tMon, 5 Aug 2024 13:34:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dLqgTFDZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722857678;\n\tbh=2p6LU2qQzTtcm5/s6JoszNS7olkpOLwOfGjtwOHSKzE=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=dLqgTFDZsCghY9tNUl6EgNxmv1vi4a6xucVlZFrdAffUmXJY0H5xWkKEhttDhyAJ+\n\toHwuXNKCtjTfCDF0v/FyVCFUYgBwSZu0MhbfR4ltT/LzwFQmZGKaGPySiRc+DJxXeJ\n\t5KH/DmDB9mMGhZDuVg5HdvPdxwBFhIaYQyS7YRKk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240803195505.842-1-laurent.pinchart@ideasonboard.com>","References":"<20240803195505.842-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH] libcamera: Remove spaces at end of lines","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 05 Aug 2024 12:35:26 +0100","Message-ID":"<172285772656.372468.11660874225404205761@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]