[{"id":30534,"web_url":"https://patchwork.libcamera.org/comment/30534/","msgid":"","date":"2024-07-31T19:01:17","subject":"Re: [PATCH v2 4/4] libcamera: software_isp: Remove file seal TODO\n\titem","submitter":{"id":102,"url":"https://patchwork.libcamera.org/api/people/102/","name":"Hans de Goede","email":"hdegoede@redhat.com"},"content":"Hi,\n\nOn 7/31/24 3:59 PM, Laurent Pinchart wrote:\n> The file seal TODO item has been addressed. Remove it.\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Milan Zamazal \n> Reviewed-by: Kieran Bingham \n\nThanks, patch looks good to me:\n\nReviewed-by: Hans de Goede \n\nRegards,\n\nHans\n\n\n\n> ---\n> src/libcamera/software_isp/TODO | 19 -------------------\n> 1 file changed, 19 deletions(-)\n> \n> diff --git a/src/libcamera/software_isp/TODO b/src/libcamera/software_isp/TODO\n> index 6bdc590531ca..9978afc0317b 100644\n> --- a/src/libcamera/software_isp/TODO\n> +++ b/src/libcamera/software_isp/TODO\n> @@ -1,22 +1,3 @@\n> -1. Setting F_SEAL_SHRINK and F_SEAL_GROW after ftruncate()\n> -\n> ->> SharedMem::SharedMem(const std::string &name, std::size_t size)\n> ->> \t: name_(name), size_(size), mem_(nullptr)\n> ->>\n> ->> ...\n> ->>\n> ->> \tif (ftruncate(fd_.get(), size_) < 0)\n> ->> \t\treturn;\n> ->\n> -> Should we set the GROW and SHRINK seals (in a separate patch) ?\n> -\n> -Yes, this can be done.\n> -Setting F_SEAL_SHRINK and F_SEAL_GROW after the ftruncate() call above could catch\n> -some potential errors related to improper access to the shared memory allocated by\n> -the SharedMemObject.\n> -\n> ----\n> -\n> 2. Reconsider stats sharing\n> \n> >>> +void SwStatsCpu::finishFrame(void)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 969E4BDC71\n\tfor ;\n\tWed, 31 Jul 2024 19:01:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 464E963378;\n\tWed, 31 Jul 2024 21:01:24 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 978A863373\n\tfor ;\n\tWed, 31 Jul 2024 21:01:22 +0200 (CEST)","from mail-ed1-f69.google.com (mail-ed1-f69.google.com\n\t[209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-629-625iCG3ZMU64Y2lxI31CQQ-1; Wed, 31 Jul 2024 15:01:19 -0400","by mail-ed1-f69.google.com with SMTP id\n\t4fb4d7f45d1cf-5a3fa8b9151so5317773a12.2\n\tfor ;\n\tWed, 31 Jul 2024 12:01:19 -0700 (PDT)","from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec?\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\t4fb4d7f45d1cf-5ac65783561sm9122541a12.92.2024.07.31.12.01.17\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 31 Jul 2024 12:01:17 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"JRXmNTVr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1722452481;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=wdM5eON1ukg8USqVFYhHrqvDOjohU51aVH0yRKLonPY=;\n\tb=JRXmNTVr/AUBs9Hmry4Na7KR7GlSHBIXE2OiBKzuE7mOeziVS9ms7XCe0WCqclqiXAP1bm\n\t61P9a4mGW2Ygyboc9CaJ1Z81hrKrnnvsv296bZIYl4IJtA3U/mUfsdArjWBIHrhqojkffI\n\tI/wE1cMIie/UaZu2vv9ovWoLJkpTXnI=","X-MC-Unique":"625iCG3ZMU64Y2lxI31CQQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1722452479; x=1723057279;\n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=wdM5eON1ukg8USqVFYhHrqvDOjohU51aVH0yRKLonPY=;\n\tb=hZi8zTTVNAwiKMTxcu8i+P33g9uQpWsEvYdaJUHWH8FltzjeCaN2YEr9A+l/ovnZS9\n\tNngLHORYCg264vIKtycpFEt8iOu6tKilmaQ6x0jJT1Suvko5X2sWdF32JMlKqrnsMGLn\n\torO04UBLzG084BJtjxYxWttZ2XWP3nVkkOT3u9Cl9UpI4hYZwRWNwyHvT860M+xmjj85\n\tZbGJ3mI9Iva+46eYAA02mO1wxt72D3bGAYJsFntvPZU00+hXQUhZEfE4R5+lam07yO3S\n\t1NwcRmvIiZgEn0ot1BA0j/RceR2c/RFuP/oErPbpd9P3RqBcQcI6daEgUsB8O0v99+y8\n\tBJbA==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCXwkjupEq07GsBjBj96XeGFTv1o+tcpxtwu9WPDmZSZ13XJpbsg9EKC+PD5BzIS2/RWFj3c1kC/VfIpy3AJ1IqhXpcpiOC0iAFJ8t/HbtpdOrhfIQ==","X-Gm-Message-State":"AOJu0YzdJd1kqJ4/+2GQadWQMUZ5apGQ1c6KFk0o2vYac3We++Pmxnkw\n\tyejfYUQtw6AMZcO/VSLY5VxI9XSHkIHfodkhw/E046gNVr5cB5ZbFyjnHQI3ivl7sz2a5rzYH0U\n\tKzFi+uujwfjaauipoLLcWDv5Ufb8hms+h+oliVEObhxjftN/w/SmDJmRktcfSqPlQBZlRWWU=","X-Received":["by 2002:a50:a406:0:b0:5a3:3062:36d6 with SMTP id\n\t4fb4d7f45d1cf-5b020101f69mr10567417a12.1.1722452478638; \n\tWed, 31 Jul 2024 12:01:18 -0700 (PDT)","by 2002:a50:a406:0:b0:5a3:3062:36d6 with SMTP id\n\t4fb4d7f45d1cf-5b020101f69mr10567360a12.1.1722452478204; \n\tWed, 31 Jul 2024 12:01:18 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IH664l3cxzCkxSMtOik9XSV4otHVMcmU3sLNx3SKUPApKLaKrQSokhsQTK26ndC+aL6dptygg==","Message-ID":"","Date":"Wed, 31 Jul 2024 21:01:17 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 4/4] libcamera: software_isp: Remove file seal TODO\n\titem","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20240731135936.2105-1-laurent.pinchart@ideasonboard.com>\n\t<20240731135936.2105-5-laurent.pinchart@ideasonboard.com>","From":"Hans de Goede ","In-Reply-To":"<20240731135936.2105-5-laurent.pinchart@ideasonboard.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US, nl","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]