[{"id":30528,"web_url":"https://patchwork.libcamera.org/comment/30528/","msgid":"<172243967849.392292.5833693203566560784@ping.linuxembedded.co.uk>","date":"2024-07-31T15:27:58","subject":"Re: [PATCH v4 1/4] meson: libcamera: Split public and internal\n\tsource arrays","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Daniel Scally (2024-07-31 14:51:58)\n> Meson array variables hold lists of libcamera's source files. To help\n> facilitate the splitting of Doxygen generated documentation into\n> distinct public and internal versions, split those arrays to separate\n> public and internal variables.\n> \n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n> ---\n> Changes in v4:\n> \n>         - Missing comma\n> \n> Changes in v3:\n> \n>         - Didn't swap span.h to private array\n>         - dropped _publically from array name\n> \n> Changes in v2:\n> \n>         - New patch\n> \n>  include/libcamera/internal/meson.build | 21 +++++++++++----\n>  src/libcamera/base/meson.build         | 24 +++++++++++------\n>  src/libcamera/meson.build              | 36 ++++++++++++++++----------\n>  src/libcamera/sensor/meson.build       |  5 ++++\n>  4 files changed, 59 insertions(+), 27 deletions(-)\n> \n> diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\n> index 9713ea1c..76c939bf 100644\n> --- a/include/libcamera/internal/meson.build\n> +++ b/include/libcamera/internal/meson.build\n> @@ -9,13 +9,21 @@ libcamera_tracepoint_header = custom_target(\n>      command : [gen_tracepoints_header, include_build_dir, '@OUTPUT@', '@INPUT@'],\n>  )\n>  \n> -libcamera_internal_headers = files([\n> +# Where libcamera's public API classes have Extensible::Private counterparts we\n> +# need to include them in doxygen's public API run or it will complain that the\n> +# functions defined in the \"public\" source are undeclared.\n> +libcamera_internal_headers_documented = files([\n> +    'camera.h',\n> +    'camera_manager.h',\n> +    'framebuffer.h',\n> +    'request.h',\n> +])\n> +\n> +libcamera_internal_headers_undocumented = files([\n>      'bayer_format.h',\n>      'byte_stream_buffer.h',\n> -    'camera.h',\n>      'camera_controls.h',\n>      'camera_lens.h',\n> -    'camera_manager.h',\n>      'camera_sensor.h',\n>      'camera_sensor_properties.h',\n>      'control_serializer.h',\n> @@ -27,7 +35,6 @@ libcamera_internal_headers = files([\n>      'device_enumerator_udev.h',\n>      'dma_buf_allocator.h',\n>      'formats.h',\n> -    'framebuffer.h',\n>      'ipa_manager.h',\n>      'ipa_module.h',\n>      'ipa_proxy.h',\n> @@ -38,7 +45,6 @@ libcamera_internal_headers = files([\n>      'pipeline_handler.h',\n>      'process.h',\n>      'pub_key.h',\n> -    'request.h',\n>      'shared_mem_object.h',\n>      'source_paths.h',\n>      'sysfs.h',\n> @@ -49,5 +55,10 @@ libcamera_internal_headers = files([\n>      'yaml_parser.h',\n>  ])\n>  \n> +libcamera_internal_headers = [\n> +    libcamera_internal_headers_documented,\n> +    libcamera_internal_headers_undocumented,\n> +]\n> +\n>  subdir('converter')\n>  subdir('software_isp')\n> diff --git a/src/libcamera/base/meson.build b/src/libcamera/base/meson.build\n> index 7a7fd7e4..523c5885 100644\n> --- a/src/libcamera/base/meson.build\n> +++ b/src/libcamera/base/meson.build\n> @@ -1,27 +1,35 @@\n>  # SPDX-License-Identifier: CC0-1.0\n>  \n> -libcamera_base_sources = files([\n> -    'backtrace.cpp',\n> -    'class.cpp',\n> +libcamera_base_public_sources = files([\n>      'bound_method.cpp',\n> +    'class.cpp',\n> +    'flags.cpp',\n> +    'object.cpp',\n> +    'shared_fd.cpp',\n> +    'signal.cpp',\n> +    'unique_fd.cpp',\n> +])\n> +\n> +libcamera_base_internal_sources = files([\n> +    'backtrace.cpp',\n>      'event_dispatcher.cpp',\n>      'event_dispatcher_poll.cpp',\n>      'event_notifier.cpp',\n>      'file.cpp',\n> -    'flags.cpp',\n>      'log.cpp',\n>      'message.cpp',\n>      'mutex.cpp',\n> -    'object.cpp',\n>      'semaphore.cpp',\n> -    'shared_fd.cpp',\n> -    'signal.cpp',\n>      'thread.cpp',\n>      'timer.cpp',\n> -    'unique_fd.cpp',\n>      'utils.cpp',\n>  ])\n>  \n> +libcamera_base_sources = [\n> +       libcamera_base_public_sources,\n> +       libcamera_base_internal_sources\n> +]\n> +\n>  libdw = dependency('libdw', required : false)\n>  libunwind = dependency('libunwind', required : false)\n>  \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 89504cee..9c74241d 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -1,14 +1,26 @@\n>  # SPDX-License-Identifier: CC0-1.0\n>  \n> -libcamera_sources = files([\n> -    'bayer_format.cpp',\n> -    'byte_stream_buffer.cpp',\n> +libcamera_public_sources = files([\n>      'camera.cpp',\n> -    'camera_controls.cpp',\n> -    'camera_lens.cpp',\n>      'camera_manager.cpp',\n>      'color_space.cpp',\n>      'controls.cpp',\n> +    'fence.cpp',\n> +    'framebuffer.cpp',\n> +    'framebuffer_allocator.cpp',\n> +    'geometry.cpp',\n> +    'orientation.cpp',\n> +    'pixel_format.cpp',\n> +    'request.cpp',\n> +    'stream.cpp',\n> +    'transform.cpp',\n> +])\n> +\n> +libcamera_internal_sources = files([\n> +    'bayer_format.cpp',\n> +    'byte_stream_buffer.cpp',\n> +    'camera_controls.cpp',\n> +    'camera_lens.cpp',\n>      'control_serializer.cpp',\n>      'control_validator.cpp',\n>      'converter.cpp',\n> @@ -16,11 +28,7 @@ libcamera_sources = files([\n>      'device_enumerator.cpp',\n>      'device_enumerator_sysfs.cpp',\n>      'dma_buf_allocator.cpp',\n> -    'fence.cpp',\n>      'formats.cpp',\n> -    'framebuffer.cpp',\n> -    'framebuffer_allocator.cpp',\n> -    'geometry.cpp',\n>      'ipa_controls.cpp',\n>      'ipa_data_serializer.cpp',\n>      'ipa_interface.cpp',\n> @@ -33,17 +41,12 @@ libcamera_sources = files([\n>      'mapped_framebuffer.cpp',\n>      'media_device.cpp',\n>      'media_object.cpp',\n> -    'orientation.cpp',\n>      'pipeline_handler.cpp',\n> -    'pixel_format.cpp',\n>      'process.cpp',\n>      'pub_key.cpp',\n> -    'request.cpp',\n>      'shared_mem_object.cpp',\n>      'source_paths.cpp',\n> -    'stream.cpp',\n>      'sysfs.cpp',\n> -    'transform.cpp',\n>      'v4l2_device.cpp',\n>      'v4l2_pixelformat.cpp',\n>      'v4l2_subdevice.cpp',\n> @@ -51,6 +54,11 @@ libcamera_sources = files([\n>      'yaml_parser.cpp',\n>  ])\n>  \n> +libcamera_sources = [\n> +       libcamera_public_sources,\n> +       libcamera_internal_sources\n> +]\n> +\n>  libcamera_sources += libcamera_public_headers\n>  libcamera_sources += libcamera_generated_ipa_headers\n>  libcamera_sources += libcamera_tracepoint_header\n> diff --git a/src/libcamera/sensor/meson.build b/src/libcamera/sensor/meson.build\n> index bf4b131a..1c1fc5a4 100644\n> --- a/src/libcamera/sensor/meson.build\n> +++ b/src/libcamera/sensor/meson.build\n> @@ -1,5 +1,10 @@\n>  # SPDX-License-Identifier: CC0-1.0\n>  \n> +libcamera_internal_sources += files([\n> +    'camera_sensor.cpp',\n> +    'camera_sensor_properties.cpp',\n> +])\n> +\n>  libcamera_sources += files([\n>      'camera_sensor.cpp',\n>      'camera_sensor_properties.cpp',\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20F46C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 31 Jul 2024 15:28:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2612963374;\n\tWed, 31 Jul 2024 17:28:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC2CF6198E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 31 Jul 2024 17:28:01 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ADD5CF85;\n\tWed, 31 Jul 2024 17:27:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"blGPbUwR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722439633;\n\tbh=q/q5pRderfirmSvb8WNfPCRfKMtB0WA4e29HEtyxe6g=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=blGPbUwRLjJmCY+TzC/HwHLUDYXveNEiDdMJzrcLqdmofAyzuneTXQm2Yo7dG3r2z\n\tfz63Yac+NeK7xBubOTv29YEcTlCmv4NGbltBN6hTEwwE87/BuZ9QdFTqOj9EQRRyLR\n\tZ7EQZXcT6hs7U4yvhNgvvlv5AOpIfV0Mk9lzV5iA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240731135201.2866145-2-dan.scally@ideasonboard.com>","References":"<20240731135201.2866145-1-dan.scally@ideasonboard.com>\n\t<20240731135201.2866145-2-dan.scally@ideasonboard.com>","Subject":"Re: [PATCH v4 1/4] meson: libcamera: Split public and internal\n\tsource arrays","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Daniel Scally <dan.scally@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Daniel Scally <dan.scally@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 31 Jul 2024 16:27:58 +0100","Message-ID":"<172243967849.392292.5833693203566560784@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":30566,"web_url":"https://patchwork.libcamera.org/comment/30566/","msgid":"<20240804160200.GA13316@pendragon.ideasonboard.com>","date":"2024-08-04T16:02:00","subject":"Re: [PATCH v4 1/4] meson: libcamera: Split public and internal\n\tsource arrays","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Jul 31, 2024 at 02:51:58PM +0100, Daniel Scally wrote:\n> Meson array variables hold lists of libcamera's source files. To help\n> facilitate the splitting of Doxygen generated documentation into\n> distinct public and internal versions, split those arrays to separate\n> public and internal variables.\n> \n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n> ---\n> Changes in v4:\n> \n> \t- Missing comma\n> \n> Changes in v3:\n> \n> \t- Didn't swap span.h to private array\n> \t- dropped _publically from array name\n> \n> Changes in v2:\n> \n> \t- New patch\n> \n>  include/libcamera/internal/meson.build | 21 +++++++++++----\n>  src/libcamera/base/meson.build         | 24 +++++++++++------\n>  src/libcamera/meson.build              | 36 ++++++++++++++++----------\n>  src/libcamera/sensor/meson.build       |  5 ++++\n>  4 files changed, 59 insertions(+), 27 deletions(-)\n> \n> diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\n> index 9713ea1c..76c939bf 100644\n> --- a/include/libcamera/internal/meson.build\n> +++ b/include/libcamera/internal/meson.build\n> @@ -9,13 +9,21 @@ libcamera_tracepoint_header = custom_target(\n>      command : [gen_tracepoints_header, include_build_dir, '@OUTPUT@', '@INPUT@'],\n>  )\n>  \n> -libcamera_internal_headers = files([\n> +# Where libcamera's public API classes have Extensible::Private counterparts we\n> +# need to include them in doxygen's public API run or it will complain that the\n> +# functions defined in the \"public\" source are undeclared.\n> +libcamera_internal_headers_documented = files([\n> +    'camera.h',\n> +    'camera_manager.h',\n> +    'framebuffer.h',\n> +    'request.h',\n> +])\n> +\n> +libcamera_internal_headers_undocumented = files([\n>      'bayer_format.h',\n>      'byte_stream_buffer.h',\n> -    'camera.h',\n>      'camera_controls.h',\n>      'camera_lens.h',\n> -    'camera_manager.h',\n>      'camera_sensor.h',\n>      'camera_sensor_properties.h',\n>      'control_serializer.h',\n> @@ -27,7 +35,6 @@ libcamera_internal_headers = files([\n>      'device_enumerator_udev.h',\n>      'dma_buf_allocator.h',\n>      'formats.h',\n> -    'framebuffer.h',\n>      'ipa_manager.h',\n>      'ipa_module.h',\n>      'ipa_proxy.h',\n> @@ -38,7 +45,6 @@ libcamera_internal_headers = files([\n>      'pipeline_handler.h',\n>      'process.h',\n>      'pub_key.h',\n> -    'request.h',\n>      'shared_mem_object.h',\n>      'source_paths.h',\n>      'sysfs.h',\n> @@ -49,5 +55,10 @@ libcamera_internal_headers = files([\n>      'yaml_parser.h',\n>  ])\n>  \n> +libcamera_internal_headers = [\n> +    libcamera_internal_headers_documented,\n> +    libcamera_internal_headers_undocumented,\n> +]\n> +\n>  subdir('converter')\n>  subdir('software_isp')\n> diff --git a/src/libcamera/base/meson.build b/src/libcamera/base/meson.build\n> index 7a7fd7e4..523c5885 100644\n> --- a/src/libcamera/base/meson.build\n> +++ b/src/libcamera/base/meson.build\n> @@ -1,27 +1,35 @@\n>  # SPDX-License-Identifier: CC0-1.0\n>  \n> -libcamera_base_sources = files([\n> -    'backtrace.cpp',\n> -    'class.cpp',\n> +libcamera_base_public_sources = files([\n>      'bound_method.cpp',\n> +    'class.cpp',\n> +    'flags.cpp',\n> +    'object.cpp',\n> +    'shared_fd.cpp',\n> +    'signal.cpp',\n> +    'unique_fd.cpp',\n> +])\n> +\n> +libcamera_base_internal_sources = files([\n> +    'backtrace.cpp',\n>      'event_dispatcher.cpp',\n>      'event_dispatcher_poll.cpp',\n>      'event_notifier.cpp',\n>      'file.cpp',\n> -    'flags.cpp',\n>      'log.cpp',\n>      'message.cpp',\n>      'mutex.cpp',\n> -    'object.cpp',\n>      'semaphore.cpp',\n> -    'shared_fd.cpp',\n> -    'signal.cpp',\n>      'thread.cpp',\n>      'timer.cpp',\n> -    'unique_fd.cpp',\n>      'utils.cpp',\n>  ])\n>  \n> +libcamera_base_sources = [\n> +\tlibcamera_base_public_sources,\n> +\tlibcamera_base_internal_sources\n\nWrong indentation, should be 4 spaces, not a tab.\n\n> +]\n> +\n>  libdw = dependency('libdw', required : false)\n>  libunwind = dependency('libunwind', required : false)\n>  \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 89504cee..9c74241d 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -1,14 +1,26 @@\n>  # SPDX-License-Identifier: CC0-1.0\n>  \n> -libcamera_sources = files([\n> -    'bayer_format.cpp',\n> -    'byte_stream_buffer.cpp',\n> +libcamera_public_sources = files([\n>      'camera.cpp',\n> -    'camera_controls.cpp',\n> -    'camera_lens.cpp',\n>      'camera_manager.cpp',\n>      'color_space.cpp',\n>      'controls.cpp',\n> +    'fence.cpp',\n> +    'framebuffer.cpp',\n> +    'framebuffer_allocator.cpp',\n> +    'geometry.cpp',\n> +    'orientation.cpp',\n> +    'pixel_format.cpp',\n> +    'request.cpp',\n> +    'stream.cpp',\n> +    'transform.cpp',\n> +])\n> +\n> +libcamera_internal_sources = files([\n> +    'bayer_format.cpp',\n> +    'byte_stream_buffer.cpp',\n> +    'camera_controls.cpp',\n> +    'camera_lens.cpp',\n>      'control_serializer.cpp',\n>      'control_validator.cpp',\n>      'converter.cpp',\n> @@ -16,11 +28,7 @@ libcamera_sources = files([\n>      'device_enumerator.cpp',\n>      'device_enumerator_sysfs.cpp',\n>      'dma_buf_allocator.cpp',\n> -    'fence.cpp',\n>      'formats.cpp',\n> -    'framebuffer.cpp',\n> -    'framebuffer_allocator.cpp',\n> -    'geometry.cpp',\n>      'ipa_controls.cpp',\n>      'ipa_data_serializer.cpp',\n>      'ipa_interface.cpp',\n> @@ -33,17 +41,12 @@ libcamera_sources = files([\n>      'mapped_framebuffer.cpp',\n>      'media_device.cpp',\n>      'media_object.cpp',\n> -    'orientation.cpp',\n>      'pipeline_handler.cpp',\n> -    'pixel_format.cpp',\n>      'process.cpp',\n>      'pub_key.cpp',\n> -    'request.cpp',\n>      'shared_mem_object.cpp',\n>      'source_paths.cpp',\n> -    'stream.cpp',\n>      'sysfs.cpp',\n> -    'transform.cpp',\n>      'v4l2_device.cpp',\n>      'v4l2_pixelformat.cpp',\n>      'v4l2_subdevice.cpp',\n> @@ -51,6 +54,11 @@ libcamera_sources = files([\n>      'yaml_parser.cpp',\n>  ])\n>  \n> +libcamera_sources = [\n> +\tlibcamera_public_sources,\n> +\tlibcamera_internal_sources\n\nSame here.\n\n> +]\n> +\n>  libcamera_sources += libcamera_public_headers\n>  libcamera_sources += libcamera_generated_ipa_headers\n>  libcamera_sources += libcamera_tracepoint_header\n> diff --git a/src/libcamera/sensor/meson.build b/src/libcamera/sensor/meson.build\n> index bf4b131a..1c1fc5a4 100644\n> --- a/src/libcamera/sensor/meson.build\n> +++ b/src/libcamera/sensor/meson.build\n> @@ -1,5 +1,10 @@\n>  # SPDX-License-Identifier: CC0-1.0\n>  \n> +libcamera_internal_sources += files([\n> +    'camera_sensor.cpp',\n> +    'camera_sensor_properties.cpp',\n> +])\n> +\n>  libcamera_sources += files([\n>      'camera_sensor.cpp',\n>      'camera_sensor_properties.cpp',","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0BA4DC323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun,  4 Aug 2024 16:02:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A1C66195E;\n\tSun,  4 Aug 2024 18:02:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D01CA6192D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun,  4 Aug 2024 18:02:22 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CA9CB1BA;\n\tSun,  4 Aug 2024 18:01:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VL2q/6w8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722787292;\n\tbh=tuJzuPN2v78O3TjLWD4pZn7tMQlZIEGcGekgDHJF9c4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VL2q/6w8Ap+V20EKbfFnOrC3+fP/L96IC+Tfh9fkvyrPu2OlTnTZBiu41cvbKwfJQ\n\tFXclJSgCL56XQp8qDDp9jT13cNVNTxhcyIBwxpE/LmeEWj5K3NE16uqVYVdNz7vicu\n\teKIHR/M7mjtcc4+V+c/63H4rIbMKi69CR1rCjrhw=","Date":"Sun, 4 Aug 2024 19:02:00 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Daniel Scally <dan.scally@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v4 1/4] meson: libcamera: Split public and internal\n\tsource arrays","Message-ID":"<20240804160200.GA13316@pendragon.ideasonboard.com>","References":"<20240731135201.2866145-1-dan.scally@ideasonboard.com>\n\t<20240731135201.2866145-2-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240731135201.2866145-2-dan.scally@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]