[{"id":30510,"web_url":"https://patchwork.libcamera.org/comment/30510/","msgid":"<87msly9g50.fsf@redhat.com>","date":"2024-07-31T07:26:03","subject":"Re: [PATCH 3/3] libcamera: software_isp: Remove file seal TODO item","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Laurent,\n\nthank you for taking care of this.\n\nLaurent Pinchart writes:\n\n> The file seal TODO item has been addressed. Remove it.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/libcamera/software_isp/TODO | 19 -------------------\n> 1 file changed, 19 deletions(-)\n>\n> diff --git a/src/libcamera/software_isp/TODO b/src/libcamera/software_isp/TODO\n> index 6bdc590531ca..9978afc0317b 100644\n> --- a/src/libcamera/software_isp/TODO\n> +++ b/src/libcamera/software_isp/TODO\n> @@ -1,22 +1,3 @@\n> -1. Setting F_SEAL_SHRINK and F_SEAL_GROW after ftruncate()\n> -\n> ->> SharedMem::SharedMem(const std::string &name, std::size_t size)\n> ->> \t: name_(name), size_(size), mem_(nullptr)\n> ->>\n> ->> ...\n> ->>\n> ->> \tif (ftruncate(fd_.get(), size_) < 0)\n> ->> \t\treturn;\n> ->\n> -> Should we set the GROW and SHRINK seals (in a separate patch) ?\n> -\n> -Yes, this can be done.\n> -Setting F_SEAL_SHRINK and F_SEAL_GROW after the ftruncate() call above could catch\n> -some potential errors related to improper access to the shared memory allocated by\n> -the SharedMemObject.\n> -\n> ----\n> -\n> 2. Reconsider stats sharing\n> \n> >>> +void SwStatsCpu::finishFrame(void)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5EEE1C323E\n\tfor ;\n\tWed, 31 Jul 2024 07:26:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 14A7163370;\n\tWed, 31 Jul 2024 09:26:15 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0855F6336F\n\tfor ;\n\tWed, 31 Jul 2024 09:26:12 +0200 (CEST)","from mail-ej1-f71.google.com (mail-ej1-f71.google.com\n\t[209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-138-g1XZwTVAMSO9rDNZFD3OEQ-1; Wed, 31 Jul 2024 03:26:07 -0400","by mail-ej1-f71.google.com with SMTP id\n\ta640c23a62f3a-a7bcaa94892so467090066b.0\n\tfor ;\n\tWed, 31 Jul 2024 00:26:07 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-a7acad911e1sm732546666b.163.2024.07.31.00.26.03\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 31 Jul 2024 00:26:04 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"VFHNiA0b\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1722410771;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=SjEt6jzxHIhr7qF08R2WTEEMG9y++v0gJR+HW1/FXwg=;\n\tb=VFHNiA0bYkTfuXxVaq7Z5nDmq9dwSQ5pOzyUGS75N796AGtJmJRHxDusDjgdnjEqnHEdOE\n\tMHXi2MdWZlJ5yCDJElocq38fFIJyYb6T7z++5ItXYdZus+kVEUuYH15UewtCc14oiVD3ku\n\tSDJ6K3I7klZGk6SD4MKMXRELzX6rDZw=","X-MC-Unique":"g1XZwTVAMSO9rDNZFD3OEQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1722410765; x=1723015565;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=SjEt6jzxHIhr7qF08R2WTEEMG9y++v0gJR+HW1/FXwg=;\n\tb=GP3BfPDIaoFCCWlVQjL5aM9TmX1mrjUgn8NXw3vs4i7OYJWdTTHbAnpj/ImkKduiLj\n\t16CXmYP4/xQO9WXz6K4lAZUiHBa/yu+R2cv0R5OGXoG3rQ8z/oDNRPA6gpWCLitXkn/e\n\tCHqp4v6C5HHcYFnVrTCXZZ2L6BoQiTdtBG9HAgKXKUJS+2l8RCguLg3a5hGugjM42H1R\n\tlZ+pmBClUlCfbRbrw3qLgDNALodEGShnnuOVbQwKNNUqo55PITBeV/UaPk21oH4kYq2X\n\tfAwaCsJF/9Q6bOa3c0MoWLlTKe4R1jLrDys/K1aw0sjQkYVIRySoODLd+/tWoHj7dzkV\n\tzXNw==","X-Gm-Message-State":"AOJu0Yx/1KteDfY2H/w2Hj3OXGicU71j0TKU7ovwa/3sysOBi3G7ND7c\n\tuXNff1EjQkgBAphqU62tuIDTlON1J71cXiuC7w8nBzz701WH8QQeHFIAIHQtHyAy87CUymJ3pn8\n\tlfhUyySm7CxtfCMvfL5ucKqNlYBb6vC41Ijn1smNZn7NN1MulIhOC2pL21MJnR8p5j8Dc5q1XFg\n\tIIxE0LF/8z/Rm6l/uKfE61ok+/cAYwM3fS9ceGDrdO+7JHBLqUv2c07XU=","X-Received":["by 2002:a17:907:97d0:b0:a7a:9f0f:ab14 with SMTP id\n\ta640c23a62f3a-a7d400132e4mr978478966b.33.1722410765286; \n\tWed, 31 Jul 2024 00:26:05 -0700 (PDT)","by 2002:a17:907:97d0:b0:a7a:9f0f:ab14 with SMTP id\n\ta640c23a62f3a-a7d400132e4mr978477166b.33.1722410764708; \n\tWed, 31 Jul 2024 00:26:04 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IFt+V3KBWa+TbFRb300bBuWxaHl4Idh9vQrsrC0Vpr6BW2XVUQ3NxnwWR9DW5ljnJW6ZVR4Zg==","From":"Milan Zamazal ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 3/3] libcamera: software_isp: Remove file seal TODO item","In-Reply-To":"<20240730232708.17399-4-laurent.pinchart@ideasonboard.com>\n\t(Laurent Pinchart's message of \"Wed, 31 Jul 2024 02:27:08 +0300\")","References":"<20240730232708.17399-1-laurent.pinchart@ideasonboard.com>\n\t<20240730232708.17399-4-laurent.pinchart@ideasonboard.com>","Date":"Wed, 31 Jul 2024 09:26:03 +0200","Message-ID":"<87msly9g50.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30513,"web_url":"https://patchwork.libcamera.org/comment/30513/","msgid":"<172241525263.392292.15777669793696618286@ping.linuxembedded.co.uk>","date":"2024-07-31T08:40:52","subject":"Re: [PATCH 3/3] libcamera: software_isp: Remove file seal TODO item","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2024-07-31 08:26:03)\n> Hi Laurent,\n> \n> thank you for taking care of this.\n> \n> Laurent Pinchart writes:\n> \n> > The file seal TODO item has been addressed. Remove it.\n> >\n> > Signed-off-by: Laurent Pinchart \n> \n> Reviewed-by: Milan Zamazal \n\nReviewed-by: Kieran Bingham \n\n> \n> > ---\n> > src/libcamera/software_isp/TODO | 19 -------------------\n> > 1 file changed, 19 deletions(-)\n> >\n> > diff --git a/src/libcamera/software_isp/TODO b/src/libcamera/software_isp/TODO\n> > index 6bdc590531ca..9978afc0317b 100644\n> > --- a/src/libcamera/software_isp/TODO\n> > +++ b/src/libcamera/software_isp/TODO\n> > @@ -1,22 +1,3 @@\n> > -1. Setting F_SEAL_SHRINK and F_SEAL_GROW after ftruncate()\n> > -\n> > ->> SharedMem::SharedMem(const std::string &name, std::size_t size)\n> > ->> : name_(name), size_(size), mem_(nullptr)\n> > ->>\n> > ->> ...\n> > ->>\n> > ->> if (ftruncate(fd_.get(), size_) < 0)\n> > ->> return;\n> > ->\n> > -> Should we set the GROW and SHRINK seals (in a separate patch) ?\n> > -\n> > -Yes, this can be done.\n> > -Setting F_SEAL_SHRINK and F_SEAL_GROW after the ftruncate() call above could catch\n> > -some potential errors related to improper access to the shared memory allocated by\n> > -the SharedMemObject.\n> > -\n> > ----\n> > -\n> > 2. Reconsider stats sharing\n> > \n> > >>> +void SwStatsCpu::finishFrame(void)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DBE9BBDC71\n\tfor ;\n\tWed, 31 Jul 2024 08:40:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 865DF63375;\n\tWed, 31 Jul 2024 10:40:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 658FB6336F\n\tfor ;\n\tWed, 31 Jul 2024 10:40:55 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AA16A7E4;\n\tWed, 31 Jul 2024 10:40:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nSqMeRje\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722415207;\n\tbh=NJ5qNdcuPtfTi4Ajm0r0lM48caREKobxQ9aScz+Tk6o=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=nSqMeRjelNBAOfHSmR5+mBpTXOUyYuB89kttYENzKJ0Nl8udsLyVYVWvb/4xU/FDA\n\tGqfieQNBYQBSAYeeAz6bB4Tq++SlpBQ2e9FDRLtv2RbbXQAsfRfTi37u9wqu7aZA/R\n\t+JUpRDCc+VM4GX12c3i8dzSttnNecn5jelsXlURw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<87msly9g50.fsf@redhat.com>","References":"<20240730232708.17399-1-laurent.pinchart@ideasonboard.com>\n\t<20240730232708.17399-4-laurent.pinchart@ideasonboard.com>\n\t<87msly9g50.fsf@redhat.com>","Subject":"Re: [PATCH 3/3] libcamera: software_isp: Remove file seal TODO item","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Laurent Pinchart ,\n\tMilan Zamazal ","Date":"Wed, 31 Jul 2024 09:40:52 +0100","Message-ID":"<172241525263.392292.15777669793696618286@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]