[{"id":30496,"web_url":"https://patchwork.libcamera.org/comment/30496/","msgid":"<875xsne45o.fsf@redhat.com>","date":"2024-07-30T07:21:23","subject":"Re: [PATCH] apps: qcam: Disable -Wextra-semi","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Laurent Pinchart writes:\n\n> The Qt 6 qkeysequence.h header has an extra semicolon. This causes a\n> build failure with clang:\n>\n> /usr/include/qt6/QtGui/qkeysequence.h:139:26: error: extra ';' after member function definition [-Werror,-Wextra-semi]\n> 139 | Q_ENUM(SequenceMatch);\n> | ^\n>\n> We can't fix the issue, so ignore the warning in qcam.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/apps/qcam/meson.build | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> index c7fcfbeb6f61..f7c140643373 100644\n> --- a/src/apps/qcam/meson.build\n> +++ b/src/apps/qcam/meson.build\n> @@ -36,7 +36,11 @@ qcam_resources = files([\n> 'assets/shader/shaders.qrc',\n> ])\n> \n> -qt6_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> +qt6_cpp_args = [\n> + apps_cpp_args,\n> + '-DQT_NO_KEYWORDS',\n> + '-Wno-extra-semi',\n> +]\n> \n> resources = qt6.preprocess(moc_headers : qcam_moc_headers,\n> qresources : qcam_resources,\n>\n> base-commit: c9152bad5ce905f5a31dbd05b40195f02c0cc2a9","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E71D7BDC71\n\tfor ;\n\tTue, 30 Jul 2024 07:21:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CD80063373;\n\tTue, 30 Jul 2024 09:21:51 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD1AC6198D\n\tfor ;\n\tTue, 30 Jul 2024 09:21:33 +0200 (CEST)","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n\t[209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-634-FIZIbsueNnioIQYZHd9GiQ-1; Tue, 30 Jul 2024 03:21:27 -0400","by mail-wr1-f71.google.com with SMTP id\n\tffacd0b85a97d-369bbbdb5a1so1294249f8f.1\n\tfor ;\n\tTue, 30 Jul 2024 00:21:27 -0700 (PDT)","from nuthatch (nat-pool-brq-t.redhat.com. [213.175.37.10])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-427f937348bsm244622835e9.18.2024.07.30.00.21.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 30 Jul 2024 00:21:24 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"hR1f22R8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1722324092;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=DIiOB8jk1N9S5iJozU5WudagAsqiDWtZuyPEgAiMJLs=;\n\tb=hR1f22R82GT5N/apS3mMKSpMsjIqMj7w3LrYD1Z/xEze0gcXOuFyVk74vj7bB99sv6zjkI\n\t4Hnq2yzYVb6gWx3CEp09tbqazddcj6gakWJ8cBhTY9xZD5WivR2tCAahlZki/IvfSuX/eT\n\tt0nmktgvy8K/ejJErUIQofXGRqFm3qE=","X-MC-Unique":"FIZIbsueNnioIQYZHd9GiQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1722324086; x=1722928886;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=DIiOB8jk1N9S5iJozU5WudagAsqiDWtZuyPEgAiMJLs=;\n\tb=mKZDGC7gJDauItcZlPwi/R0Zi+oSAflRdARb98JIbvhiPsfGOX9QfTfO/e1mFAEt5y\n\tvhQziIwutvzJRePbU+Yvi/4/Xx68QpyiT/3Z9gAHudglnzBN8zIm9TSX6T084Fpa8U+X\n\te9Sua1zeUWW7/4EM9Qb6jH6DYqd1Dd7PlEs7gEqQillG48GSb0tsOfrJPx6uzQwBTDMB\n\tYfLP5DfC0a2Kw6RNYmYt6DmKS9BIMK/Xjib99r5C8n5ViaiOqIko/PbG2lcGgn4//6Ii\n\tAZEmmoSbTW9OVFvBFgTM5ONE6SjKqPVZxyi45jHMoZJ6Nf22XkeV3QKU7m2VrpXF25mD\n\t5E8Q==","X-Gm-Message-State":"AOJu0YzGocTqYWStgxmpXa90axpVvHlGzI0sU01bigmRhqG+jjwlM5MI\n\tf4Mo5vMchyW6r+A/x7aKtV6IkCJko1GF5gx94jWWYvz95AzIC1W8fpa+lbd/yi5Eo4WHv6qnVdj\n\tFnWXZk7e5HoNeMasm471+u9K4axvU1Tx60kftiQ4dcxLWqh5grS9JqR5Og605ZqH7dI67S3Af7I\n\tfYVPMgHG/H0RqcqSVgwtHJ3g8XVPpcWMbWv0tSkFIiG8EjyEUyb54jhXU=","X-Received":["by 2002:a5d:5846:0:b0:363:776:821b with SMTP id\n\tffacd0b85a97d-36b8c745943mr791390f8f.0.1722324086177; \n\tTue, 30 Jul 2024 00:21:26 -0700 (PDT)","by 2002:a5d:5846:0:b0:363:776:821b with SMTP id\n\tffacd0b85a97d-36b8c745943mr791362f8f.0.1722324085589; \n\tTue, 30 Jul 2024 00:21:25 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IHv6LbEZK6a3xOLYYUkZxWr2l7KBzT3wcB1fL9VtcIu0BR/qvVPtBTGYVHaEl3StgDV1Yigkw==","From":"Milan Zamazal ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] apps: qcam: Disable -Wextra-semi","In-Reply-To":"<20240729175559.10512-1-laurent.pinchart@ideasonboard.com>\n\t(Laurent Pinchart's message of \"Mon, 29 Jul 2024 20:55:59 +0300\")","References":"<20240729175559.10512-1-laurent.pinchart@ideasonboard.com>","Date":"Tue, 30 Jul 2024 09:21:23 +0200","Message-ID":"<875xsne45o.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30499,"web_url":"https://patchwork.libcamera.org/comment/30499/","msgid":"<3bxjp6baafclsmgiborqt4jevfol4cfvnztwhisd2ee6zf5cgi@gd5c6l3ucgfc>","date":"2024-07-30T11:14:56","subject":"Re: [PATCH] apps: qcam: Disable -Wextra-semi","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Mon, Jul 29, 2024 at 08:55:59PM GMT, Laurent Pinchart wrote:\n> The Qt 6 qkeysequence.h header has an extra semicolon. This causes a\n> build failure with clang:\n>\n> /usr/include/qt6/QtGui/qkeysequence.h:139:26: error: extra ';' after member function definition [-Werror,-Wextra-semi]\n> 139 | Q_ENUM(SequenceMatch);\n> | ^\n>\n> We can't fix the issue, so ignore the warning in qcam.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/apps/qcam/meson.build | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\n> index c7fcfbeb6f61..f7c140643373 100644\n> --- a/src/apps/qcam/meson.build\n> +++ b/src/apps/qcam/meson.build\n> @@ -36,7 +36,11 @@ qcam_resources = files([\n> 'assets/shader/shaders.qrc',\n> ])\n>\n> -qt6_cpp_args = [apps_cpp_args, '-DQT_NO_KEYWORDS']\n> +qt6_cpp_args = [\n> + apps_cpp_args,\n> + '-DQT_NO_KEYWORDS',\n> + '-Wno-extra-semi',\n> +]\n>\n> resources = qt6.preprocess(moc_headers : qcam_moc_headers,\n> qresources : qcam_resources,\n>\n> base-commit: c9152bad5ce905f5a31dbd05b40195f02c0cc2a9\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 342AAC323E\n\tfor ;\n\tTue, 30 Jul 2024 11:15:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 369AC63374;\n\tTue, 30 Jul 2024 13:15:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A70C061994\n\tfor ;\n\tTue, 30 Jul 2024 13:15:00 +0200 (CEST)","from ideasonboard.com (mob-5-90-63-112.net.vodafone.it\n\t[5.90.63.112])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 56FEA743;\n\tTue, 30 Jul 2024 13:14:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kSuuqHJm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722338053;\n\tbh=AR6kUQ7WhW6NAXN17g8hy4PfiZQoiJwFZRtucLCmPwg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kSuuqHJmoVnfaqEXcX25aFIS5InFDow1niYuR3IjSIpkNn7XpWIWfj2TIEtu66P+5\n\tY+rAWtin4gPkwvnZSCiZUjO5bIu3HviWq1V2BJ3bJj353vZQeMutun/AfHIgewMbvG\n\tC5/MbKSyaPQbMWcNNKNPWpULwAV6/VTMMGYbQc+w=","Date":"Tue, 30 Jul 2024 13:14:56 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] apps: qcam: Disable -Wextra-semi","Message-ID":"<3bxjp6baafclsmgiborqt4jevfol4cfvnztwhisd2ee6zf5cgi@gd5c6l3ucgfc>","References":"<20240729175559.10512-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240729175559.10512-1-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]