[{"id":287,"web_url":"https://patchwork.libcamera.org/comment/287/","msgid":"<3022773.9q91YLUyXD@avalon>","date":"2019-01-11T15:25:09","subject":"Re: [libcamera-devel] [PATCH v2 2/3] test: media_device: Make\n\tMediaDeviceTest a MediaDevicePrintTest","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Friday, 11 January 2019 15:27:04 EET Jacopo Mondi wrote:\n> As a new class for test link handling will be added as a separate test,\n> it makes no sense to have a generic \"MediaDeviceTest\" class. Rename it\n> in \"MediaDevicePrintTest\", and make it run only printing test.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> ...e_test.cpp => media_device_print_test.cpp} | 31 +++++++++----------\n> test/media_device/meson.build | 2 +-\n> 2 files changed, 15 insertions(+), 18 deletions(-)\n> rename test/media_device/{media_device_test.cpp =>\n> media_device_print_test.cpp} (79%)\n> \n> diff --git a/test/media_device/media_device_test.cpp\n> b/test/media_device/media_device_print_test.cpp similarity index 79%\n> rename from test/media_device/media_device_test.cpp\n> rename to test/media_device/media_device_print_test.cpp\n> index c482b2e..9746afa 100644\n> --- a/test/media_device/media_device_test.cpp\n> +++ b/test/media_device/media_device_print_test.cpp\n> @@ -1,10 +1,8 @@\n> /* SPDX-License-Identifier: GPL-2.0-or-later */\n> /*\n> - * Copyright (C) 2018, Google Inc.\n> + * Copyright (C) 2019, Google Inc.\n\n2018-2019. You should use 2019 for new code only, and 2018-2019 for older code \nthat is modified in 2019.\n\nApart from this,\n\nReviewed-by: Laurent Pinchart \n\nI wonder whether this test shouldn't be replaced by something else down the \nroad. Printing a media device graph isn't really a unit test, maybe we should \ninstead create a test that looks up entities, pads and links through various \nmeans based on a known media graph (vimc ?) to test the API.\n\n> *\n> - * media_device_test.cpp - Tests for the media device class.\n> - *\n> - * Test library for the media device class.\n> + * media_device_print_test.cpp - Print out media devices\n> */\n> #include \n> \n> @@ -20,16 +18,16 @@ using namespace libcamera;\n> using namespace std;\n> \n> /*\n> - * MediaDeviceTest object: runs a sequence of tests on all media\n> - * devices found in the system.\n> + * MediaDevicePrintTest takes all media devices found in the system and\n> print\n> + * them out to verify correctness.\n> *\n> * If no accessible media device is found, the test is skipped.\n> */\n> -class MediaDeviceTest : public Test\n> +class MediaDevicePrintTest : public Test\n> {\n> public:\n> -\tMediaDeviceTest() { }\n> -\t~MediaDeviceTest() { }\n> +\tMediaDevicePrintTest() { }\n> +\t~MediaDevicePrintTest() { }\n> \n> protected:\n> \tint init() { return 0; }\n> @@ -44,7 +42,7 @@ private:\n> \tvoid printNode(const MediaPad *pad, ostream &os);\n> };\n> \n> -void MediaDeviceTest::printNode(const MediaPad *pad, ostream &os)\n> +void MediaDevicePrintTest::printNode(const MediaPad *pad, ostream &os)\n> {\n> \tconst MediaEntity *entity = pad->entity();\n> \n> @@ -52,7 +50,7 @@ void MediaDeviceTest::printNode(const MediaPad *pad,\n> ostream &os) << pad->index() << \"]\";\n> }\n> \n> -void MediaDeviceTest::printLinkFlags(const MediaLink *link, ostream &os)\n> +void MediaDevicePrintTest::printLinkFlags(const MediaLink *link, ostream\n> &os) {\n> \tunsigned int flags = link->flags();\n> \n> @@ -68,7 +66,7 @@ void MediaDeviceTest::printLinkFlags(const MediaLink\n> *link, ostream &os) * For each entity in the media graph, printout links\n> directed to its sinks * and source pads.\n> */\n> -void MediaDeviceTest::printMediaGraph(const MediaDevice &media, ostream\n> &os)\n> +void MediaDevicePrintTest::printMediaGraph(const MediaDevice &media, \n> ostream &os) {\n> \tos << \"\\n\" << media.driver() << \" - \" << media.devnode() << \"\\n\\n\";\n> \n> @@ -110,7 +108,7 @@ void MediaDeviceTest::printMediaGraph(const MediaDevice\n> &media, ostream &os) }\n> \n> /* Test a single media device. */\n> -int MediaDeviceTest::testMediaDevice(const string devnode)\n> +int MediaDevicePrintTest::testMediaDevice(const string devnode)\n> {\n> \tMediaDevice dev(devnode);\n> \tint ret;\n> @@ -134,9 +132,8 @@ int MediaDeviceTest::testMediaDevice(const string\n> devnode) if (ret)\n> \t\treturn ret;\n> \n> -\t/* Run tests in sequence. */\n> +\t/* Print out the media graph. */\n> \tprintMediaGraph(dev, cerr);\n> -\t/* TODO: add more tests here. */\n> \n> \tdev.close();\n> \n> @@ -145,7 +142,7 @@ int MediaDeviceTest::testMediaDevice(const string\n> devnode)\n> \n> /* Run tests on all media devices. */\n> #define MAX_MEDIA_DEV 256\n> -int MediaDeviceTest::run()\n> +int MediaDevicePrintTest::run()\n> {\n> \tconst string devnode(\"/dev/media\");\n> \tunsigned int i;\n> @@ -171,4 +168,4 @@ int MediaDeviceTest::run()\n> \treturn ret;\n> }\n> \n> -TEST_REGISTER(MediaDeviceTest);\n> +TEST_REGISTER(MediaDevicePrintTest);\n> diff --git a/test/media_device/meson.build b/test/media_device/meson.build\n> index 40f9ffa..e4bedb7 100644\n> --- a/test/media_device/meson.build\n> +++ b/test/media_device/meson.build\n> @@ -1,5 +1,5 @@\n> media_device_tests = [\n> - ['media_device_test', 'media_device_test.cpp'],\n> + ['media_device_print_test', 'media_device_print_test.cpp'],\n> ]\n> \n> foreach t : media_device_tests","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D716600CC\n\tfor ;\n\tFri, 11 Jan 2019 16:23:58 +0100 (CET)","from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8588C53E;\n\tFri, 11 Jan 2019 16:23:57 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547220237;\n\tbh=JIycQbIMfYY5RFmIBv8UGWzT2/8xinldBlu52r7finw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fD+gtCPK4jV1OBv2PDBVLESVZeVYwBA/VFxQQLmkxrWRKxnIQFCmBaQag4b45Rws4\n\tSnHdxnx3lIwiuHz1IbNwvG8bdkceRQrHf9cJL+z6jBGigu2/zh+oXumLGAWocx0nZ2\n\tIq/kykPxTMC5kvwH8jnFDXRtuw66puqY6+eXOBgw=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 11 Jan 2019 17:25:09 +0200","Message-ID":"<3022773.9q91YLUyXD@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"<20190111132705.19329-3-jacopo@jmondi.org>","References":"<20190111132705.19329-1-jacopo@jmondi.org>\n\t<20190111132705.19329-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] test: media_device: Make\n\tMediaDeviceTest a MediaDevicePrintTest","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 11 Jan 2019 15:23:59 -0000"}}]