[{"id":30457,"web_url":"https://patchwork.libcamera.org/comment/30457/","msgid":"<19aee092-824c-4de5-9267-701456a51e7a@cherry.de>","date":"2024-07-23T15:04:39","subject":"Re: [PATCH v2] libipa: camera_sensor_helper: Add OV5675 black level","submitter":{"id":202,"url":"https://patchwork.libcamera.org/api/people/202/","name":"Quentin Schulz","email":"quentin.schulz@cherry.de"},"content":"Hi Daniel,\n\nOn 7/23/24 4:56 PM, Daniel Semkowicz wrote:\n> Add black level value for OV5675 camera sensor.\n> According to datasheet, default value is 0x10, 10 bits width.\n> However, Linux kernel driver initializes black level target value\n> to 0x40. Set the value to the same as in kernel driver, but scaled\n> to 16 bits.\n> \n> Signed-off-by: Daniel Semkowicz \n\nReviewed-by: Quentin Schulz \n\nConsidering that this value can change over time, c.f. \nhttps://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=99cd12425dfe9a400b672f112512a3678dfd1eb6 \nfor ov5670, we should probably think of having the kernel expose this \nvalue as Kieran suggested in v1. I don't think this should be a blocker \nfor this patch though (especially since the upstream kernel has had this \nvalue since the introducing commit).\n\nThanks!\nQuentin","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 493B9BDB1C\n\tfor ;\n\tTue, 23 Jul 2024 15:04:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2DD7F63370;\n\tTue, 23 Jul 2024 17:04:47 +0200 (CEST)","from AS8PR04CU009.outbound.protection.outlook.com\n\t(mail-westeuropeazlp170110003.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:c201::3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 98AA0619A3\n\tfor ;\n\tTue, 23 Jul 2024 17:04:45 +0200 (CEST)","from AM9PR04MB8906.eurprd04.prod.outlook.com (2603:10a6:20b:409::9)\n\tby DU2PR04MB8855.eurprd04.prod.outlook.com (2603:10a6:10:2e2::18)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.17;\n\tTue, 23 Jul 2024 15:04:42 +0000","from AM9PR04MB8906.eurprd04.prod.outlook.com\n\t([fe80::d379:5378:b1:cea]) by AM9PR04MB8906.eurprd04.prod.outlook.com\n\t([fe80::d379:5378:b1:cea%3]) with mapi id 15.20.7784.016;\n\tTue, 23 Jul 2024 15:04:41 +0000"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=cherry.de header.i=@cherry.de\n\theader.b=\"aIQT/vxY\"; dkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=cherry.de;"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=c6XCo3J1flrT1HvBaZjP2GXxZGLbRK0eApOHEXrAhmJu2VuV4uOdNoBzcFPf9rD1UFSZLl/I+IqxURkFGMH7vqoKaJS+NW3aNtyJ1e1s8PeIV8XTtddD5OioeKBIlxZcfaszBHmYCLmb2GVOc2Grje1X8QvhGsYHfDnv5n2P7HrLM5akGJUCsWkYzRLQc4VpKcANpsdn1lI/EMZkl5iV6GqTDIDixLmwieamzR83v2v9VgPiOeWzt58jl0LWXPuSoOv7LuVfbqMYrdUHuAj9qCqFgUdQWHpCRwl4QtYNLlVjqE6IzsgFOGKbPUzY/bxYGwLOX2AzuvzDQZckcsSiqg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=h2o0uIQ0xfLfVDCKKtbrMBjh4zi7SVSok6QTETyYz+k=;\n\tb=HVDJWyDyJex1/o74xDXs/8bqC1nU3chdG7RmMLnKyTua1fNX+uf6wl483UQLm7y5suRw/Y9RKbFFi0CXPrPDM0PnHeOdCFY9+tYTDD0vNYyHPylrp/S5zZ+SLWWVH8UVxDGPO36YzLsj10qr/hlRIRXViUfG2FvUm2MWlfbm5ThMK/AkOuf7XXzKyyD055j1L35R3oq+dfG/zJZI1G4f0AruINKHVyysMENX+Gc1q79rb1d3uzpSiD7gkD4VxGb8XDRxue6BTs4/zZ0gDmeFlCW1fHSEq/iHVz+Q2xi5CD7j0KoDm8Bv601VJ6IwRCqlm6P/7hk0RxFQWAhiNaCZ1A==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=cherry.de; dmarc=pass action=none header.from=cherry.de;\n\tdkim=pass header.d=cherry.de; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=cherry.de;\n\ts=selector1; \n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=h2o0uIQ0xfLfVDCKKtbrMBjh4zi7SVSok6QTETyYz+k=;\n\tb=aIQT/vxYtdQrtjfiVShAh1IMdPBi0Q53EMJsSXA7R0lQex0auwsDJyHLTzZmMrtSSq+s5Jk1O5Lxwgs5/zCJusDePBVPibGcjWtkDhyMra9p74tT+8YgmBDvIWPa5VW0v5SqAhYWLX/pgLtG0LSAnTv+GAS0DvRt9nycq5oC6g8=","Message-ID":"<19aee092-824c-4de5-9267-701456a51e7a@cherry.de>","Date":"Tue, 23 Jul 2024 17:04:39 +0200","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2] libipa: camera_sensor_helper: Add OV5675 black level","To":"Daniel Semkowicz , libcamera-devel@lists.libcamera.org","References":"<20240723145736.81241-1-dse@thaumatec.com>","Content-Language":"en-US","From":"Quentin Schulz ","In-Reply-To":"<20240723145736.81241-1-dse@thaumatec.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"BE1P281CA0481.DEUP281.PROD.OUTLOOK.COM\n\t(2603:10a6:b10:7e::14) To AM9PR04MB8906.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:409::9)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AM9PR04MB8906:EE_|DU2PR04MB8855:EE_","X-MS-Office365-Filtering-Correlation-Id":"826a9f0b-dddd-4704-6da0-08dcab28c778","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;ARA:13230040|1800799024|366016|376014;","X-Microsoft-Antispam-Message-Info":"=?utf-8?q?7OJdvSlwmk2OupHtHm26qnRBXK6k?=\n\t=?utf-8?q?N9TRPOiRNyLX5nj4nH37fXqLvxWUOu4eWAuurl0hsgO5K78cvgQ+eAoC?=\n\t=?utf-8?q?fQUx8mo/EwAveGfgSH05Wbrl8mxoqAwpL84/bC+4kJVsruw9jhwN1cbD?=\n\t=?utf-8?q?LYAjXF3Mh3PcYRqfXncIWp4Iy9j0uLawBkco2sP8KL48ZvgJEILkpJde?=\n\t=?utf-8?q?5XHLCbKdH/MNzjgZF8iLQFnk1IRb7ulgarCpsbrqY6ZX/D6VkOhlnrP2?=\n\t=?utf-8?q?qnidZMcXwa/r8x0Cd9leS+zHjlOsHAaNkhdVGS5aUwzzSBy1W1V3qU/Q?=\n\t=?utf-8?q?f1lgcqKEY/J42UH/MCzquB7WXNE0bxEdH1SxV7sUYSV/ISsDAflakM65?=\n\t=?utf-8?q?rrW+pItzuctVQbflhDF6DftVuc2vQIicTd8kwHkSIE25DFRgpqbl533+?=\n\t=?utf-8?q?89CKPqXQGZuAIZYDyC9tyKI2e6YGcsL2u+p80hXFb0100oESW1PPyU+R?=\n\t=?utf-8?q?KA4OhpV3l31qB643zcZdxV4EYiFMcMtAcoa0NRXDtg+Rawwo+i+gn3oE?=\n\t=?utf-8?q?mbg+NL4iDZRLbmcVk8HjzPSvg8ABAibjmMQODS8MIUP7UcJiKCoevPsb?=\n\t=?utf-8?q?V0YyacLbfONzhsHLXVCm5AYI6NnNXMR3nyEKzTso6/otcuQSBL7H124H?=\n\t=?utf-8?q?9b93gVDiszCbB5a08/LiW9B7quHIJC/w585GeeqlnW7NXJK6jsMpnjWg?=\n\t=?utf-8?q?xfuUNwUYFdk7bmfWcJHjo7QhgIbaquy5cm0y+zrRUjyvRDx4CR0cinyV?=\n\t=?utf-8?q?qaOSjcWIM6g8xSAcs/CXDvmcg47KnubMMyuejqDs2d27Aeg7WNfPJTws?=\n\t=?utf-8?q?ua0taVBJlcDEpsMiuSbxsS9aQ3UJRJsR8PFsMR4RU3nkwVaT1K+fqSC2?=\n\t=?utf-8?q?rXdCe2XNHgO2zuyAUb5wuLbDXIz6U7GCkv3EqRisL3jv3rg5We4l8SUr?=\n\t=?utf-8?q?fbCZstrqF9j/UYGDC4TBtOtd59XQMM9gue1MqBx5S/T7wiqe6MIvWtFh?=\n\t=?utf-8?q?S8eu5RvQJ+wI65hMXYpYOdh4T1C91jIm3K16gKj/kvqLy8Fw1l/5Gbt2?=\n\t=?utf-8?q?/ZJpTu1J7VlVX5hGUtz/SubnNJZ8yhAufYMg4fS4SqQUkgQ1i/xROm9t?=\n\t=?utf-8?q?CP55J7w/n49BpI9k9oCqfypfxm+BJQ6Kafmpg6w4o6x/nGmBRJolLRok?=\n\t=?utf-8?q?3KJpUEwuR92cTVefzRmuduHR738F8A7bc6+xLRUJboQNNJZZsci4svCy?=\n\t=?utf-8?q?Fo3Ugow7WxTvcmRo5NoE9k4sPAxyN6xJjWYYY5vtWgVBJaaOtIECNXAZ?=\n\t=?utf-8?q?A06jQgDZaUwgzdUffhWcQRkXdCtFtb4xnygONf7r/LXQ0kyZvFyNCqek?=\n\t=?utf-8?q?ZWUvx8A=3D?=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:AM9PR04MB8906.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; ","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?64w6GgMw/xBD6ux3aI+YHxh3L?=\n\t=?utf-8?q?cssItB+A7fRtki0eeIC5lELtp74LeMvEcI/bxMQBQ4eBbp4lB15Z9AD9?=\n\t=?utf-8?q?JyIXE0Z8I6ZaZBwT9mHLaaWpl+fZfzEL+ZiFKYy6FzzQ2fZ5k3QWM4JB?=\n\t=?utf-8?q?wQdusG5uPeBPhTmuWLHPuk3QCcJcZj/A27QkNMT/ziXk342L+nRpttSU?=\n\t=?utf-8?q?vxx9HyImca6aTHgSKdQ28NEqEyTFnfL03U/RQDZuKREp1IFetKCI/HBw?=\n\t=?utf-8?q?P1LcxsxRPtc98y1r1DFVaMqLKstMAeGYTm33Kf2+1jH9Hs62PaIPCf/w?=\n\t=?utf-8?q?ujTx6NsACKxf/6iyP1kSsJA/1IUHxb52myKAaQcgMRmgORrsdiig96SW?=\n\t=?utf-8?q?VXfDMBKJgjIhmmmpENZffB18P4J1INIDvLZhbx3JPZBtW4LLZ9lZ245n?=\n\t=?utf-8?q?73zJH/kygjbDOK3jcgYI9HEuUZCX5O1f/UiLhsBlF6JM/E+cMRkjSKlj?=\n\t=?utf-8?q?317kuY5di5rAo8k6rGiTAPnV3ltq+B1Ux7/W1779dNtk5xkFxFKDpDkR?=\n\t=?utf-8?q?kgkpSKps6nCXya5jXEZYDbl4l6GK92DXY1nsYmuboP9FyzIWMHkCyy3m?=\n\t=?utf-8?q?WvV0ctdXDx6x5dfvPYzu+10acUVMWO8cNGr0WJJ/Il7qbPbLuNP+dWPT?=\n\t=?utf-8?q?5Zyy3ctlZNAhlNvpsbhEhZetkQAmja4+woZebtmoihEtF0l+w8OBxqn3?=\n\t=?utf-8?q?2Iy4CUSnc0qjKDYVHQ678vr5K1VhIWDPQtgpY5xlpAAPMSVJIOTw76PC?=\n\t=?utf-8?q?0oFZy967gmscVMfnL8a7+hnTPg7qW44xX/dnODeA1I8PwgeqjzOp8FYf?=\n\t=?utf-8?q?XxHVQhhs9aWpb8LFM2sJF1xD+JMVlbFXGkc3JCUROFKolWRmksyqP5ov?=\n\t=?utf-8?q?8iXhrbubMJslhyjN3vrfklX5//qnjZcC5NY8vL0XlXwmB5Bf0LictyQQ?=\n\t=?utf-8?q?f0Yjay3Tnn9HMz9DTSEUBnyoVtkOPCK7w3KLUkHfPPeyqjqW1q7SHZHu?=\n\t=?utf-8?q?gWuj4ktJleRG2HYC9nK6SorMetIFW+mghAnHrRDugycNIfw+q7/TBo3J?=\n\t=?utf-8?q?/z8Iq5lGCT4eh7Tf7SVf9riV9VjQmBp8Q8/7rUkzJkv8cO0uMWqqGxYt?=\n\t=?utf-8?q?/vh+9xmdmtpRALRmVBovGJeVWmLWAVZYCt+SWecgVBYT0Uuf5p3uscF2?=\n\t=?utf-8?q?cOm4LsiFEG64jiJ6zQz3Mhwh+s4VtAj9zjSGIpAdb7Fr23NaxUpw2yTC?=\n\t=?utf-8?q?1VkzogP1n76ZNcbRWuZxN54PkAYT/oGmWvlbpzhKxQ8U8xfghXCjhj1i?=\n\t=?utf-8?q?FWaFdnE1ZdfGeSmUNifLzPnyXcN8DawFBqeoGRCUE58DtHBHxSF8et4C?=\n\t=?utf-8?q?GOTxI/NaLPD9Ukt7j7+WV15wvnyhbidDuJ7yrQ3W5ePeXZLpkOqHpmb4?=\n\t=?utf-8?q?j2SsuYeBKmLbn+0xsDIcGdcN/hhbGgqLhuIx5uycCcPZbY4m9iFCerkW?=\n\t=?utf-8?q?Nxdj1GCxY/J8FTUQuI/N36QUSvaqLUlT5HRFLtvyXU516wbpp1YN9dm/?=\n\t=?utf-8?q?qEZ5oPJX+V0hQavWs0Ej6KUsLqGX2amevcFIhc3zj37JpR2sLwSWsnN0?=\n\t=?utf-8?q?xEjbs/7YB3RrLW4ugSYbpdc/hdQpOVNcqGOezTVVnL/3/FCaSL5KuZHN?=\n\t=?utf-8?q?b8GvKvj612iodoWsZ0dGQM8rPxslg=3D=3D?=","X-OriginatorOrg":"cherry.de","X-MS-Exchange-CrossTenant-Network-Message-Id":"826a9f0b-dddd-4704-6da0-08dcab28c778","X-MS-Exchange-CrossTenant-AuthSource":"AM9PR04MB8906.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"23 Jul 2024 15:04:41.5093\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"5e0e1b52-21b5-4e7b-83bb-514ec460677e","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"JezLuRhS03ID8h6c3yn14Qx++RPxFgxXt3yHuxNpGw34PmABy4AsfBARJfIUYMVTQWlmUWhlGweHUYqxqGGybtgop9qJp5poIoEpvunZbmQ=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DU2PR04MB8855","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30458,"web_url":"https://patchwork.libcamera.org/comment/30458/","msgid":"<172174751411.392292.13044865230744019695@ping.linuxembedded.co.uk>","date":"2024-07-23T15:11:54","subject":"Re: [PATCH v2] libipa: camera_sensor_helper: Add OV5675 black level","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Quentin Schulz (2024-07-23 16:04:39)\n> Hi Daniel,\n> \n> On 7/23/24 4:56 PM, Daniel Semkowicz wrote:\n> > Add black level value for OV5675 camera sensor.\n> > According to datasheet, default value is 0x10, 10 bits width.\n> > However, Linux kernel driver initializes black level target value\n> > to 0x40. Set the value to the same as in kernel driver, but scaled\n> > to 16 bits.\n> > \n> > Signed-off-by: Daniel Semkowicz \n> \n> Reviewed-by: Quentin Schulz \n> \n> Considering that this value can change over time, c.f. \n> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=99cd12425dfe9a400b672f112512a3678dfd1eb6 \n> for ov5670, we should probably think of having the kernel expose this \n> value as Kieran suggested in v1. I don't think this should be a blocker \n> for this patch though (especially since the upstream kernel has had this \n> value since the introducing commit).\n\nAgreed,\n\nThis value matches what upstream kernels will configure the device so\nit's appropriate now.\n\nBut we need to resolve this in the future - ideally for all camera\nsensors in a consistent manner. That's far more tricky :D\n\nbut for this v2 patch ...\n\n\n\nReviewed-by: Kieran Bingham \n\n> \n> Thanks!\n> Quentin","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3993C323E\n\tfor ;\n\tTue, 23 Jul 2024 15:11:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 01F016336F;\n\tTue, 23 Jul 2024 17:11:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 762AF619A1\n\tfor ;\n\tTue, 23 Jul 2024 17:11:57 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DE6E57E2;\n\tTue, 23 Jul 2024 17:11:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nhHqvXFb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1721747475;\n\tbh=hOS/kqnT4J1DSwwGBPiNW/CTZ8TZcIt3C8CV+ygCu2Q=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=nhHqvXFbPyX3h8xyloxrIbOjaxafYhfWDsUl+eD9pj4RsbL6c8oxyt3c7zADkWbWK\n\taonvrSALfPDuVxIdHZI0Xsh3mKh2qjmMeTMp95an6WImMfafECAaqfXdSU+zLpV5T0\n\tYys25kJA+SqE1Tf5odqZJid1irF3cu5fFIGpVWmc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<19aee092-824c-4de5-9267-701456a51e7a@cherry.de>","References":"<20240723145736.81241-1-dse@thaumatec.com>\n\t<19aee092-824c-4de5-9267-701456a51e7a@cherry.de>","Subject":"Re: [PATCH v2] libipa: camera_sensor_helper: Add OV5675 black level","From":"Kieran Bingham ","To":"Daniel Semkowicz ,\n\tQuentin Schulz ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 23 Jul 2024 16:11:54 +0100","Message-ID":"<172174751411.392292.13044865230744019695@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]