[{"id":30422,"web_url":"https://patchwork.libcamera.org/comment/30422/","msgid":"<7ad51020-4796-41e2-9b93-74619738c65f@ideasonboard.com>","date":"2024-07-17T12:50:22","subject":"Re: [RFC 8/9] dw100: fixup","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"On 17/07/24 3:39 pm, Jacopo Mondi wrote:\n> Signed-off-by: Jacopo Mondi \n> ---\n> .../libcamera/internal/converter/converter_dw100.h | 2 +-\n> src/libcamera/converter/converter_dw100.cpp | 11 +++++++++--\n> 2 files changed, 10 insertions(+), 3 deletions(-)\n>\n> diff --git a/include/libcamera/internal/converter/converter_dw100.h b/include/libcamera/internal/converter/converter_dw100.h\n> index dc41f365b5c7..ee82b99e8d9d 100644\n> --- a/include/libcamera/internal/converter/converter_dw100.h\n> +++ b/include/libcamera/internal/converter/converter_dw100.h\n> @@ -18,7 +18,7 @@ class Stream;\n> class ConverterDW100 : public V4L2M2MConverter\n> {\n> public:\n> -\tConverterDW100(std::shared_ptr media);\n> +\tConverterDW100(MediaDevice *media, Converter::Features features);\n> };\n> \n> } /* namespace libcamera */\n> diff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp\n> index 3061fc71dd80..09ede8d0c216 100644\n> --- a/src/libcamera/converter/converter_dw100.cpp\n> +++ b/src/libcamera/converter/converter_dw100.cpp\n> @@ -29,9 +29,16 @@ LOG_DECLARE_CATEGORY(Converter)\n> * \\brief Construct a ConverterDW100 instance\n> * \\param[in] media The media device implementing the converter\n> */\n> -ConverterDW100::ConverterDW100(std::shared_ptr media)\n> -\t: V4L2M2MConverter(media.get(), Feature::Crop)\n> +ConverterDW100::ConverterDW100(MediaDevice *media, Converter::Features features)\n> +\t: V4L2M2MConverter(media, features)\n> {\n> }\n> \n> +static std::initializer_list compatibles = {\n> +\t\"dw100\",\n> +};\n\nWhat I was thinking here is to have\n\n+\t\"dw100\", Converter::Feature::Crop\n....\n\nHere it doesn't makes much sense, but I think looking at \nv4l2_m2m_converter(s), I think each compatible string needs to have its \nown set of features, no ?\n> +\n> +REGISTER_CONVERTER(\"dw100\", ConverterDW100, compatibles,\n> +\t\t Converter::Feature::Crop)\n> +\n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 18AECC323E\n\tfor ;\n\tWed, 17 Jul 2024 12:50:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D3EA06336F;\n\tWed, 17 Jul 2024 14:50:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5FB0619AB\n\tfor ;\n\tWed, 17 Jul 2024 14:50:26 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 08D8A667;\n\tWed, 17 Jul 2024 14:49:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IDcd6FAK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1721220588;\n\tbh=8v/WRFqpyDz1r2Rz+3btRbtOuQ9LHh02exEQS8iU68I=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=IDcd6FAKUGk4gTRgKCwK+IOX6vi9mcC24C6wgUNOip1OsVw7+HhJUsquMoAE9TTuG\n\twWzYT29rHZCqYsW9NHjGkvgAkCIRgnFZvDoG53eONPLln3rwOaBz48FnrpmFiCzU1R\n\tAt2R86aFWBxBx/k4bqldFiR/yPufHoWZODGwwGTM=","Message-ID":"<7ad51020-4796-41e2-9b93-74619738c65f@ideasonboard.com>","Date":"Wed, 17 Jul 2024 18:20:22 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [RFC 8/9] dw100: fixup","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20240717100913.16640-1-jacopo.mondi@ideasonboard.com>\n\t<20240717100913.16640-9-jacopo.mondi@ideasonboard.com>","Content-Language":"en-US","From":"Umang Jain ","In-Reply-To":"<20240717100913.16640-9-jacopo.mondi@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]