{"id":20678,"url":"https://patchwork.libcamera.org/api/patches/20678/?format=json","web_url":"https://patchwork.libcamera.org/patch/20678/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240717085444.289997-18-mzamazal@redhat.com>","date":"2024-07-17T08:54:38","name":"[v3,17/23] libcamera: software_isp: Call Algorithm::process","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bcbd0718763595f3e2fceb6e7a249c6db13ddd50","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20678/mbox/","series":[{"id":4454,"url":"https://patchwork.libcamera.org/api/series/4454/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4454","date":"2024-07-17T08:54:21","name":"Software ISP refactoring","version":3,"mbox":"https://patchwork.libcamera.org/series/4454/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20678/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20678/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7BFB7C3243\n\tfor ;\n\tWed, 17 Jul 2024 08:55:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D832263382;\n\tWed, 17 Jul 2024 10:55:44 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 950A06337D\n\tfor ;\n\tWed, 17 Jul 2024 10:55:26 +0200 (CEST)","from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-127-_r68-9QIMWuG8Nkd5teXyg-1;\n\tWed, 17 Jul 2024 04:55:23 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id D770A19560B0; Wed, 17 Jul 2024 08:55:22 +0000 (UTC)","from nuthatch.brq.redhat.com (unknown [10.43.17.37])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id AD7D61955F40; Wed, 17 Jul 2024 08:55:21 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"YloxIE1C\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1721206525;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=4hV4b5d4r5tluBuDfRLjYL2/sZ2ASvb3/U6oMGSkWjQ=;\n\tb=YloxIE1COXtODPGd2W6XJaPtnh4nZJKLe/gDHrN9acKuy/miU4xzAWa0Md1as+RjUupLp3\n\tWWFPkCX0oibyS/JzgbSMiH5PwQ/Lcw88rQzcLy3XZyI07T3tNqjL6A9rnLOL9bpq+02koj\n\tHm6w6lGCfjMTWRpj9GSHK74u9/AAN5s=","X-MC-Unique":"_r68-9QIMWuG8Nkd5teXyg-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tUmang Jain ","Subject":"[PATCH v3 17/23] libcamera: software_isp: Call Algorithm::process","Date":"Wed, 17 Jul 2024 10:54:38 +0200","Message-ID":"<20240717085444.289997-18-mzamazal@redhat.com>","In-Reply-To":"<20240717085444.289997-1-mzamazal@redhat.com>","References":"<20240717085444.289997-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This patch adds Algorithm::process call for the defined algorithms.\nThis is preparation only since there are currently no Algorithm based\nalgorithms defined.\n\nAs software ISP currently doesn't produce any metadata, a dummy and\nunused metadata instance is created to satisfy Algorithm::process API.\nThis should be changed in future.\n\nSigned-off-by: Milan Zamazal \nReviewed-by: Umang Jain \n---\n src/ipa/simple/soft_simple.cpp | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex f4a6bdf4..a8499f29 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -287,10 +287,21 @@ void IPASoftSimple::prepare(const uint32_t frame)\n }\n \n void IPASoftSimple::processStats(\n-\t[[maybe_unused]] const uint32_t frame,\n+\tconst uint32_t frame,\n \t[[maybe_unused]] const uint32_t bufferId,\n \tconst ControlList &sensorControls)\n {\n+\tIPAFrameContext &frameContext = context_.frameContexts.get(frame);\n+\t/*\n+\t * Software ISP currently does not produce any metadata. Use an empty\n+\t * ControlList for now.\n+\t *\n+\t * \\todo Implement proper metadata handling\n+\t */\n+\tControlList metadata(controls::controls);\n+\tfor (auto const &algo : algorithms())\n+\t\talgo->process(context_, frame, frameContext, stats_, metadata);\n+\n \tSwIspStats::Histogram histogram = stats_->yHistogram;\n \tif (ignoreUpdates_ > 0)\n \t\tblackLevel_.update(histogram);\n","prefixes":["v3","17/23"]}