[{"id":30779,"web_url":"https://patchwork.libcamera.org/comment/30779/","msgid":"<5cc2172d-016d-412f-a246-6697c808be78@ideasonboard.com>","date":"2024-08-13T08:50:25","subject":"Re: [PATCH v3 15/23] libcamera: software_isp: Call\n\tAlgorithm::queueRequest","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Milan\n\nOn 17/07/2024 09:54, Milan Zamazal wrote:\n> This patch adds Algorithm::queueRequest call for the defined algorithms.\n> As there are currently no control knobs in software ISP nor the\n> corresponding queueRequest call chain, the patch also introduces the\n> queueRequest methods and calls from the pipeline to the IPA.\n>\n> This is preparation only since there are currently no Algorithm based\n> algorithms defined and no current software ISP algorithms support\n> control knobs.\n>\n> Signed-off-by: Milan Zamazal \n> Reviewed-by: Umang Jain \n> ---\n> include/libcamera/internal/software_isp/software_isp.h | 1 +\n> include/libcamera/ipa/soft.mojom | 1 +\n> src/ipa/simple/soft_simple.cpp | 9 +++++++++\n> src/libcamera/pipeline/simple/simple.cpp | 2 ++\n> src/libcamera/software_isp/software_isp.cpp | 10 ++++++++++\n> 5 files changed, 23 insertions(+)\n>\n> diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\n> index c5d5a46f..a3e3a9da 100644\n> --- a/include/libcamera/internal/software_isp/software_isp.h\n> +++ b/include/libcamera/internal/software_isp/software_isp.h\n> @@ -73,6 +73,7 @@ public:\n> \tint start();\n> \tvoid stop();\n> \n> +\tvoid queueRequest(const uint32_t frame, const ControlList &controls);\n\nAs mentioned before, I think we should move away from calling this variable \"frame\". It's not the \nframe number from the driver, in most implementations (including this one) it's the request sequence \nnumber, so I think naming it after that somehow is the better approach.\n\n\nOther than the variable name, patch looks fine to me:\n\n\nReviewed-by: Daniel Scally \n\n> \tint queueBuffers(uint32_t frame, FrameBuffer *input,\n> \t\t\t const std::map &outputs);\n> \n> diff --git a/include/libcamera/ipa/soft.mojom b/include/libcamera/ipa/soft.mojom\n> index 5e124016..34b91657 100644\n> --- a/include/libcamera/ipa/soft.mojom\n> +++ b/include/libcamera/ipa/soft.mojom\n> @@ -23,6 +23,7 @@ interface IPASoftInterface {\n> \tconfigure(IPAConfigInfo configInfo)\n> \t\t=> (int32 ret);\n> \n> +\t[async] queueRequest(uint32 frame, libcamera.ControlList sensorControls);\n> \t[async] processStats(uint32 frame, uint32 bufferId, libcamera.ControlList sensorControls);\n> };\n> \n> diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\n> index 49fff312..bd0dea5f 100644\n> --- a/src/ipa/simple/soft_simple.cpp\n> +++ b/src/ipa/simple/soft_simple.cpp\n> @@ -77,6 +77,7 @@ public:\n> \tint start() override;\n> \tvoid stop() override;\n> \n> +\tvoid queueRequest(const uint32_t frame, const ControlList &controls) override;\n> \tvoid processStats(const uint32_t frame, const uint32_t bufferId,\n> \t\t\t const ControlList &sensorControls) override;\n> \n> @@ -269,6 +270,14 @@ void IPASoftSimple::stop()\n> {\n> }\n> \n> +void IPASoftSimple::queueRequest(const uint32_t frame, const ControlList &controls)\n> +{\n> +\tIPAFrameContext &frameContext = context_.frameContexts.alloc(frame);\n> +\n> +\tfor (auto const &algo : algorithms())\n> +\t\talgo->queueRequest(context_, frame, frameContext, controls);\n> +}\n> +\n> void IPASoftSimple::processStats(\n> \t[[maybe_unused]] const uint32_t frame,\n> \t[[maybe_unused]] const uint32_t bufferId,\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 4326d14c..984c3a77 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -1429,6 +1429,8 @@ int SimplePipelineHandler::queueRequestDevice(Camera *camera, Request *request)\n> \tif (data->useConversion_)\n> \t\tdata->conversionQueue_.push(std::move(buffers));\n> \n> +\tdata->swIsp_->queueRequest(request->sequence(), request->controls());\n> +\n> \treturn 0;\n> }\n> \n> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> index 9793df18..0b9c5fdf 100644\n> --- a/src/libcamera/software_isp/software_isp.cpp\n> +++ b/src/libcamera/software_isp/software_isp.cpp\n> @@ -279,6 +279,16 @@ int SoftwareIsp::exportBuffers(const Stream *stream, unsigned int count,\n> \treturn count;\n> }\n> \n> +/**\n> + * \\brief Queue a request and process the control list from the application\n> + * \\param[in] frame The number of the frame which will be processed next\n> + * \\param[in] controls The controls for the \\a frame\n> + */\n> +void SoftwareIsp::queueRequest(const uint32_t frame, const ControlList &controls)\n> +{\n> +\tipa_->queueRequest(frame, controls);\n> +}\n> +\n> /**\n> * \\brief Queue buffers to Software ISP\n> * \\param[in] frame The frame number","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 76B86BDB13\n\tfor ;\n\tTue, 13 Aug 2024 08:50:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87BFF633BA;\n\tTue, 13 Aug 2024 10:50:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5BE4263398\n\tfor ;\n\tTue, 13 Aug 2024 10:50:28 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D363827\n\tfor ;\n\tTue, 13 Aug 2024 10:49:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KBsUHU5q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723538971;\n\tbh=fS1Jko/5v1hYv79Rwg6U4I57/x32hDFSoo7mVLu/vOk=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=KBsUHU5qAHvuzy/cDQximBQDxy1mGyPd8TKzEp9WPQ2wSbllFAox7gwrJDFABihc0\n\tjTu4CYn2MH1Y1cj15BYam3a2G9o9utW6weWNhcV73kHewqu6zoeuJcGkNe8lWcCUuD\n\tYNoCyaWrP0ciwDqjCrrtsAzDoyjrk+U70GqHpSEI=","Message-ID":"<5cc2172d-016d-412f-a246-6697c808be78@ideasonboard.com>","Date":"Tue, 13 Aug 2024 09:50:25 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 15/23] libcamera: software_isp: Call\n\tAlgorithm::queueRequest","To":"libcamera-devel@lists.libcamera.org","References":"<20240717085444.289997-1-mzamazal@redhat.com>\n\t<20240717085444.289997-16-mzamazal@redhat.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240717085444.289997-16-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30785,"web_url":"https://patchwork.libcamera.org/comment/30785/","msgid":"<87le10y9iy.fsf@redhat.com>","date":"2024-08-13T10:58:13","subject":"Re: [PATCH v3 15/23] libcamera: software_isp: Call\n\tAlgorithm::queueRequest","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Dan,\n\nthank you for review.\n\nDan Scally writes:\n\n> Hi Milan\n>\n> On 17/07/2024 09:54, Milan Zamazal wrote:\n>> This patch adds Algorithm::queueRequest call for the defined algorithms.\n>> As there are currently no control knobs in software ISP nor the\n>> corresponding queueRequest call chain, the patch also introduces the\n>> queueRequest methods and calls from the pipeline to the IPA.\n>>\n>> This is preparation only since there are currently no Algorithm based\n>> algorithms defined and no current software ISP algorithms support\n>> control knobs.\n>>\n>> Signed-off-by: Milan Zamazal \n>> Reviewed-by: Umang Jain \n>> ---\n>> include/libcamera/internal/software_isp/software_isp.h | 1 +\n>> include/libcamera/ipa/soft.mojom | 1 +\n>> src/ipa/simple/soft_simple.cpp | 9 +++++++++\n>> src/libcamera/pipeline/simple/simple.cpp | 2 ++\n>> src/libcamera/software_isp/software_isp.cpp | 10 ++++++++++\n>> 5 files changed, 23 insertions(+)\n>>\n>> diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\n>> index c5d5a46f..a3e3a9da 100644\n>> --- a/include/libcamera/internal/software_isp/software_isp.h\n>> +++ b/include/libcamera/internal/software_isp/software_isp.h\n>> @@ -73,6 +73,7 @@ public:\n>> \tint start();\n>> \tvoid stop();\n>> +\tvoid queueRequest(const uint32_t frame, const ControlList &controls);\n>\n> As mentioned before, I think we should move away from calling this variable \"frame\". It's not the frame number from the driver, in most\n> implementations (including this one) it's the request sequence number, so I think naming it after that somehow is the better approach.\n\nI agree but I wouldn't like to diverge from the other pipelines. Is it\npreferable to change the variable name in this series and possibly later\nalso in the other pipelines, or to keep `frame' here for now and then\nto make mass-rename everywhere?\n\n> Other than the variable name, patch looks fine to me:\n>\n>\n> Reviewed-by: Daniel Scally \n>\n>> \tint queueBuffers(uint32_t frame, FrameBuffer *input,\n>> \t\t\t const std::map &outputs);\n>> diff --git a/include/libcamera/ipa/soft.mojom b/include/libcamera/ipa/soft.mojom\n>> index 5e124016..34b91657 100644\n>> --- a/include/libcamera/ipa/soft.mojom\n>> +++ b/include/libcamera/ipa/soft.mojom\n>> @@ -23,6 +23,7 @@ interface IPASoftInterface {\n>> \tconfigure(IPAConfigInfo configInfo)\n>> \t\t=> (int32 ret);\n>> +\t[async] queueRequest(uint32 frame, libcamera.ControlList sensorControls);\n>> \t[async] processStats(uint32 frame, uint32 bufferId, libcamera.ControlList sensorControls);\n>> };\n>> diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\n>> index 49fff312..bd0dea5f 100644\n>> --- a/src/ipa/simple/soft_simple.cpp\n>> +++ b/src/ipa/simple/soft_simple.cpp\n>> @@ -77,6 +77,7 @@ public:\n>> \tint start() override;\n>> \tvoid stop() override;\n>> +\tvoid queueRequest(const uint32_t frame, const ControlList &controls) override;\n>> \tvoid processStats(const uint32_t frame, const uint32_t bufferId,\n>> \t\t\t const ControlList &sensorControls) override;\n>> @@ -269,6 +270,14 @@ void IPASoftSimple::stop()\n>> {\n>> }\n>> +void IPASoftSimple::queueRequest(const uint32_t frame, const ControlList &controls)\n>> +{\n>> +\tIPAFrameContext &frameContext = context_.frameContexts.alloc(frame);\n>> +\n>> +\tfor (auto const &algo : algorithms())\n>> +\t\talgo->queueRequest(context_, frame, frameContext, controls);\n>> +}\n>> +\n>> void IPASoftSimple::processStats(\n>> \t[[maybe_unused]] const uint32_t frame,\n>> \t[[maybe_unused]] const uint32_t bufferId,\n>> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n>> index 4326d14c..984c3a77 100644\n>> --- a/src/libcamera/pipeline/simple/simple.cpp\n>> +++ b/src/libcamera/pipeline/simple/simple.cpp\n>> @@ -1429,6 +1429,8 @@ int SimplePipelineHandler::queueRequestDevice(Camera *camera, Request *request)\n>> \tif (data->useConversion_)\n>> \t\tdata->conversionQueue_.push(std::move(buffers));\n>> +\tdata->swIsp_->queueRequest(request->sequence(), request->controls());\n>> +\n>> \treturn 0;\n>> }\n>> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n>> index 9793df18..0b9c5fdf 100644\n>> --- a/src/libcamera/software_isp/software_isp.cpp\n>> +++ b/src/libcamera/software_isp/software_isp.cpp\n>> @@ -279,6 +279,16 @@ int SoftwareIsp::exportBuffers(const Stream *stream, unsigned int count,\n>> \treturn count;\n>> }\n>> +/**\n>> + * \\brief Queue a request and process the control list from the application\n>> + * \\param[in] frame The number of the frame which will be processed next\n>> + * \\param[in] controls The controls for the \\a frame\n>> + */\n>> +void SoftwareIsp::queueRequest(const uint32_t frame, const ControlList &controls)\n>> +{\n>> +\tipa_->queueRequest(frame, controls);\n>> +}\n>> +\n>> /**\n>> * \\brief Queue buffers to Software ISP\n>> * \\param[in] frame The frame number","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 60306BDB13\n\tfor ;\n\tTue, 13 Aug 2024 10:58:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2694563382;\n\tTue, 13 Aug 2024 12:58:23 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D4DC163382\n\tfor ;\n\tTue, 13 Aug 2024 12:58:20 +0200 (CEST)","from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n\t[209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-682-HjcMGOp4Ni-gVY5D0Cx0TQ-1; Tue, 13 Aug 2024 06:58:16 -0400","by mail-wm1-f71.google.com with SMTP id\n\t5b1f17b1804b1-427b7a2052bso61613175e9.2\n\tfor ;\n\tTue, 13 Aug 2024 03:58:16 -0700 (PDT)","from nuthatch (nat-pool-brq-t.redhat.com. [213.175.37.10])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4290c738e0csm224583685e9.16.2024.08.13.03.58.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 13 Aug 2024 03:58:13 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"cg0SNF5Q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1723546699;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=yFyEIDs2MdFQa8Yh3dnGPcGjsbNn8LYmVj8TRs/GP3k=;\n\tb=cg0SNF5QNAigZqwJGw+vAMymKFhA2Fl1/om5NDL9yS3Ah7pA3Id2I9rZUX0LaywS3dYnAI\n\ty+DQuRCtPD1qEkUWciHyBqBFKViYVUb0n4FBdIt2HB/H2x4RB5nkwl87eYTT5TisOo/rIZ\n\t+ObqPteqq4o/87HPqQgc7+XzeeTXd4M=","X-MC-Unique":"HjcMGOp4Ni-gVY5D0Cx0TQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1723546695; x=1724151495;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=yFyEIDs2MdFQa8Yh3dnGPcGjsbNn8LYmVj8TRs/GP3k=;\n\tb=UhK1Hcz20Xo4U42yCh62K0U2Lg552AsDMTRsyTBWdCBVY/iFrMlIsP69IzisxEge4J\n\t3SqAFuAGPTT/RTp+UwVbH0NmOz4wQuXyRSm2rMv2/LB1Z36bWf+OVrTTTSWhk58gJNoP\n\tjWhPwtnzIJ1fzlYYmAKPkGR7sLr9lnCOZMBLG+pjanNa6nOo3DtphZiCescuqQViUmS+\n\teaG8nvpeJk8lvhW/lsY4MtbpAL5IFzDmoHAXdH9VKby+ornKx2+OcooDUXLMEX0QER+x\n\tVOjSbia6aFgoQ3S0qkAMte4FuYt5GzCnsXbO5AApEjpQxCNFQbpTkvquPX7n9pzpDX3z\n\tzOJQ==","X-Gm-Message-State":"AOJu0YzIBg93zqA56/pGGnbp29gEAQWVB+nT4zvAGI9cY2Iutfme8FZV\n\t99Nb+qgVMsyoOCcAfcIeFpwpKE28ewXm9eCA7e+/AIzDwqM/J3jc9M3fQfIY1q4pBsoupyIiKHY\n\tG01fSYe6A/sM1bWYblbyl0KapvYp47IzgOsbLUS1NdIutOSCsdTL8ecZ/YDKgkSoe1OLmNP3ih8\n\t6M3mpDAQfYXvWBv5v12tO46oxTrXIaijZBlwAUgvApmg7PJPJbkOpe384=","X-Received":["by 2002:a05:600c:19c9:b0:428:f0a:3f92 with SMTP id\n\t5b1f17b1804b1-429d481c9b4mr28390845e9.21.1723546694676; \n\tTue, 13 Aug 2024 03:58:14 -0700 (PDT)","by 2002:a05:600c:19c9:b0:428:f0a:3f92 with SMTP id\n\t5b1f17b1804b1-429d481c9b4mr28390665e9.21.1723546694124; \n\tTue, 13 Aug 2024 03:58:14 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IEtMBAIude9MTCKHl0vaRipWpGaZ6z2NoQwqD5mb539eOhX66t4qKIUm7j1ZHI81nOpk4lPqw==","From":"Milan Zamazal ","To":"Dan Scally ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 15/23] libcamera: software_isp: Call\n\tAlgorithm::queueRequest","In-Reply-To":"<5cc2172d-016d-412f-a246-6697c808be78@ideasonboard.com> (Dan\n\tScally's message of \"Tue, 13 Aug 2024 09:50:25 +0100\")","References":"<20240717085444.289997-1-mzamazal@redhat.com>\n\t<20240717085444.289997-16-mzamazal@redhat.com>\n\t<5cc2172d-016d-412f-a246-6697c808be78@ideasonboard.com>","Date":"Tue, 13 Aug 2024 12:58:13 +0200","Message-ID":"<87le10y9iy.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]