[{"id":2760,"web_url":"https://patchwork.libcamera.org/comment/2760/","msgid":"<20191003194844.GO1322@bigcity.dyn.berto.se>","date":"2019-10-03T19:48:44","subject":"Re: [libcamera-devel] [PATCH v2 12/13] libcamera: Add\n\tControlValidator implementation for Camera","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your effort.\n\nOn 2019-09-29 22:02:53 +0300, Laurent Pinchart wrote:\n> Add a new CameraControlValidator class that implements the\n> ControlValidator interface for a Camera object.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/camera_controls.cpp | 53 +++++++++++++++++++++++++\n> src/libcamera/include/camera_controls.h | 30 ++++++++++++++\n> src/libcamera/include/meson.build | 1 +\n> src/libcamera/meson.build | 1 +\n> 4 files changed, 85 insertions(+)\n> create mode 100644 src/libcamera/camera_controls.cpp\n> create mode 100644 src/libcamera/include/camera_controls.h\n> \n> diff --git a/src/libcamera/camera_controls.cpp b/src/libcamera/camera_controls.cpp\n> new file mode 100644\n> index 000000000000..341da56019f7\n> --- /dev/null\n> +++ b/src/libcamera/camera_controls.cpp\n> @@ -0,0 +1,53 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2019, Google Inc.\n> + *\n> + * camera_controls.cpp - Camera controls\n> + */\n> +\n> +#include \"camera_controls.h\"\n> +\n> +#include \n> +#include \n> +\n> +/**\n> + * \\file camera_controls.h\n> + * \\brief Controls for Camera instances\n> + */\n> +\n> +namespace libcamera {\n> +\n> +/**\n> + * \\class CameraControlValidator\n> + * \\brief A control validator for Camera instances\n> + *\n> + * This ControlValidator specialisation validates that controls exist in the\n> + * Camera associated with the validator.\n> + */\n> +\n> +/**\n> + * \\brief Construst a CameraControlValidator for the \\a camera\n> + * \\param[in] camera The camera\n> + */\n> +CameraControlValidator::CameraControlValidator(Camera *camera)\n> +\t: camera_(camera)\n> +{\n> +}\n> +\n> +const std::string &CameraControlValidator::name() const\n> +{\n> +\treturn camera_->name();\n> +}\n> +\n> +/**\n> + * \\brief Validate a control\n> + * \\param[in] id The control ID\n> + * \\return True if the control is valid, false otherwise\n> + */\n> +bool CameraControlValidator::validate(const ControlId &id) const\n> +{\n> +\tconst ControlInfoMap &controls = camera_->controls();\n> +\treturn controls.find(&id) != controls.end();\n> +}\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/libcamera/include/camera_controls.h b/src/libcamera/include/camera_controls.h\n> new file mode 100644\n> index 000000000000..998a2d155a44\n> --- /dev/null\n> +++ b/src/libcamera/include/camera_controls.h\n> @@ -0,0 +1,30 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2019, Google Inc.\n> + *\n> + * camera_controls.h - Camera controls\n> + */\n> +#ifndef __LIBCAMERA_CAMERA_CONTROLS_H__\n> +#define __LIBCAMERA_CAMERA_CONTROLS_H__\n> +\n> +#include \"control_validator.h\"\n> +\n> +namespace libcamera {\n> +\n> +class Camera;\n> +\n> +class CameraControlValidator final : public ControlValidator\n> +{\n> +public:\n> +\tCameraControlValidator(Camera *camera);\n> +\n> +\tconst std::string &name() const override;\n> +\tbool validate(const ControlId &id) const override;\n> +\n> +private:\n> +\tCamera *camera_;\n> +};\n> +\n> +} /* namespace libcamera */\n> +\n> +#endif /* __LIBCAMERA_CAMERA_CONTROLS_H__ */\n> diff --git a/src/libcamera/include/meson.build b/src/libcamera/include/meson.build\n> index 1cf47204f2b5..2c74d29bd925 100644\n> --- a/src/libcamera/include/meson.build\n> +++ b/src/libcamera/include/meson.build\n> @@ -1,4 +1,5 @@\n> libcamera_headers = files([\n> + 'camera_controls.h',\n> 'camera_sensor.h',\n> 'control_validator.h',\n> 'device_enumerator.h',\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index c8a66cfc93d5..3a3b388a6a34 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -2,6 +2,7 @@ libcamera_sources = files([\n> 'bound_method.cpp',\n> 'buffer.cpp',\n> 'camera.cpp',\n> + 'camera_controls.cpp',\n> 'camera_manager.cpp',\n> 'camera_sensor.cpp',\n> 'controls.cpp',\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2ECD160BE8\n\tfor ;\n\tThu, 3 Oct 2019 21:48:46 +0200 (CEST)","by mail-lf1-x141.google.com with SMTP id u28so2758992lfc.5\n\tfor ;\n\tThu, 03 Oct 2019 12:48:46 -0700 (PDT)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tk13sm756363ljc.96.2019.10.03.12.48.44\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 03 Oct 2019 12:48:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=Ygbq5psrxCEYLtc3qLWGaniJoM8i5H6orOQPApfUvEA=;\n\tb=qEZ8yixt28xiIqqiOIq0ye+mm04g94UggfQw4ym68o9wtlp2LRoxNslQv3PTWBuJ3O\n\txAuxRqtdQ6IfMWEEpwMnllODcV1eNqwK0nL5lLDx24sIy3upTIwEedpBc/8wGZZWcekq\n\tAHQeaJNKDvjLlQN5JHIi/ppuuxY8L3ZpTQjygLVpklP0tT2W3hmWyFLpB3TgdOc3PUes\n\tE8GNRD8+9qMkDxo1mMVkXlNhqq9j0vzmmDnMbFHTEdWWndwYn7UGjFAYpOTdRSRvaFKT\n\ti/Z4bn1smKCxyCIF9CnSlYq/FWa4v7aCg59gV3mnvaiGVEF8FayB8SaCKGddyPnn66VY\n\tjRyQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=Ygbq5psrxCEYLtc3qLWGaniJoM8i5H6orOQPApfUvEA=;\n\tb=KkAzDfbf6mKOJNi3vClSxSoUOAhLK79DDr9JJXE2PlaaH73d89Qc8TpqOB0RGN+cgu\n\tkIPS8SiP74/+J9+OaTkaZUDuQM+LjtdyR5rtLz/8ZHfgodemfhQ5nal9z9vzk/fYHEKU\n\tc5B3WxTnYl4YgKNYwMAqSUsu8PGokKqkRwWRWxKTgZ+n9zCJqxpk28sFLrMhbbnbsuJC\n\txdbADURduc1g+Ha62Esh8IzJAFeRu2J5w+SRm+As/zJOKHvIiMyB6xJdXexrx9ZwuCj+\n\tzad3uppOSSHsL46Q84F6qnwFQ6Iw83csbpys62gqe6VCQgWize0LqpUEOEcvhnnL9228\n\tDxcw==","X-Gm-Message-State":"APjAAAVAtkZlENJuGn1XA4ouiAwj3nLQIJxTG4edhF/3Do3LmItJWb5a\n\tWnnKkL45yyCVPCbhqb1xwFGQ6SX1XrE=","X-Google-Smtp-Source":"APXvYqxZ8Quc8gCNkjfm0FcPVqi0NcRbKkoY/jeoNotqbAxoPjQXyz+YZp094GUq+QjIHcMb+jCS2w==","X-Received":"by 2002:ac2:48af:: with SMTP id u15mr6839246lfg.75.1570132125555;\n\tThu, 03 Oct 2019 12:48:45 -0700 (PDT)","Date":"Thu, 3 Oct 2019 21:48:44 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191003194844.GO1322@bigcity.dyn.berto.se>","References":"<20190929190254.18920-1-laurent.pinchart@ideasonboard.com>\n\t<20190929190254.18920-13-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190929190254.18920-13-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v2 12/13] libcamera: Add\n\tControlValidator implementation for Camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 03 Oct 2019 19:48:46 -0000"}}]