[{"id":30740,"web_url":"https://patchwork.libcamera.org/comment/30740/","msgid":"<20240812123716.GG16961@pendragon.ideasonboard.com>","date":"2024-08-12T12:37:16","subject":"Re: [PATCH v3 06/23] libcamera: software_isp: Move BlackLevel to\n\tlibcamera::ipa::soft","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Wed, Jul 17, 2024 at 10:54:27AM +0200, Milan Zamazal wrote:\n> To be in the same namespace as the other software ISP IPA stuff.\n\nThe commit message body should be readable by itself, not as a\ncontinuation of the subject line. You could write\n\nIPA modules use custom namespaces for all their internal components to\navoid namespace clashes. The simple IPA module for the software ISP uses\nlibcamera::ipa::soft for this purpose. It however defines an internal\nclass named BlackLevel in the root of the libcamera namespace, making it\nprone to clashes. Move it to the ipa::soft namespace along with the rest\nof the code.\n\n\nThere's no need to resubmit just for this, and I would be fine merging\nthe patch even without the updated commit message, but let's keep this\nin mind for future patches.\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: Milan Zamazal \n> Reviewed-by: Umang Jain \n> ---\n> src/ipa/simple/black_level.cpp | 5 +++++\n> src/ipa/simple/black_level.h | 4 ++++\n> 2 files changed, 9 insertions(+)\n> \n> diff --git a/src/ipa/simple/black_level.cpp b/src/ipa/simple/black_level.cpp\n> index cc490eb5..37e0109c 100644\n> --- a/src/ipa/simple/black_level.cpp\n> +++ b/src/ipa/simple/black_level.cpp\n> @@ -15,6 +15,8 @@ namespace libcamera {\n> \n> LOG_DEFINE_CATEGORY(IPASoftBL)\n> \n> +namespace ipa::soft {\n> +\n> /**\n> * \\class BlackLevel\n> * \\brief Object providing black point level for software ISP\n> @@ -85,4 +87,7 @@ void BlackLevel::update(SwIspStats::Histogram &yHistogram)\n> \t\t}\n> \t};\n> }\n> +\n> +} /* namespace ipa::soft */\n> +\n> } /* namespace libcamera */\n> diff --git a/src/ipa/simple/black_level.h b/src/ipa/simple/black_level.h\n> index 5e032f9f..a04230c9 100644\n> --- a/src/ipa/simple/black_level.h\n> +++ b/src/ipa/simple/black_level.h\n> @@ -14,6 +14,8 @@\n> \n> namespace libcamera {\n> \n> +namespace ipa::soft {\n> +\n> class BlackLevel\n> {\n> public:\n> @@ -26,4 +28,6 @@ private:\n> \tbool blackLevelSet_;\n> };\n> \n> +} /* namespace ipa::soft */\n> +\n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8ADC4C323E\n\tfor ;\n\tMon, 12 Aug 2024 12:37:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C66FA63398;\n\tMon, 12 Aug 2024 14:37:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CA2D63369\n\tfor ;\n\tMon, 12 Aug 2024 14:37:40 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 84E6E6B5;\n\tMon, 12 Aug 2024 14:36:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hEI+dG07\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723466203;\n\tbh=8hHHb9eXRvpMvUMORyjICFQB9w5CYoV/NylKS0jKCV8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hEI+dG07FGy6rUc61be7r+eHqZOfq3dpXc29fkjWe8Ce6n8COqVNPQKNXr/t7w8J0\n\thlQxGSpdZy17nhgEBiocUqm61LnQyrAVWSnPvhzVxq4ZE5iru8eybSJEjAtxhAanaX\n\tDEQBubU5AKsUpYA15rrSrIzdSqKMvjfYpFVjWkHY=","Date":"Mon, 12 Aug 2024 15:37:16 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org,\n\tUmang Jain ","Subject":"Re: [PATCH v3 06/23] libcamera: software_isp: Move BlackLevel to\n\tlibcamera::ipa::soft","Message-ID":"<20240812123716.GG16961@pendragon.ideasonboard.com>","References":"<20240717085444.289997-1-mzamazal@redhat.com>\n\t<20240717085444.289997-7-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240717085444.289997-7-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30748,"web_url":"https://patchwork.libcamera.org/comment/30748/","msgid":"<9144e789-2ff8-4241-bc9f-7a91e76b2158@ideasonboard.com>","date":"2024-08-12T13:10:24","subject":"Re: [PATCH v3 06/23] libcamera: software_isp: Move BlackLevel to\n\tlibcamera::ipa::soft","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"On 17/07/2024 09:54, Milan Zamazal wrote:\n> To be in the same namespace as the other software ISP IPA stuff.\n>\n> Signed-off-by: Milan Zamazal \n> Reviewed-by: Umang Jain \n> ---\nReviewed-by: Daniel Scally \n> src/ipa/simple/black_level.cpp | 5 +++++\n> src/ipa/simple/black_level.h | 4 ++++\n> 2 files changed, 9 insertions(+)\n>\n> diff --git a/src/ipa/simple/black_level.cpp b/src/ipa/simple/black_level.cpp\n> index cc490eb5..37e0109c 100644\n> --- a/src/ipa/simple/black_level.cpp\n> +++ b/src/ipa/simple/black_level.cpp\n> @@ -15,6 +15,8 @@ namespace libcamera {\n> \n> LOG_DEFINE_CATEGORY(IPASoftBL)\n> \n> +namespace ipa::soft {\n> +\n> /**\n> * \\class BlackLevel\n> * \\brief Object providing black point level for software ISP\n> @@ -85,4 +87,7 @@ void BlackLevel::update(SwIspStats::Histogram &yHistogram)\n> \t\t}\n> \t};\n> }\n> +\n> +} /* namespace ipa::soft */\n> +\n> } /* namespace libcamera */\n> diff --git a/src/ipa/simple/black_level.h b/src/ipa/simple/black_level.h\n> index 5e032f9f..a04230c9 100644\n> --- a/src/ipa/simple/black_level.h\n> +++ b/src/ipa/simple/black_level.h\n> @@ -14,6 +14,8 @@\n> \n> namespace libcamera {\n> \n> +namespace ipa::soft {\n> +\n> class BlackLevel\n> {\n> public:\n> @@ -26,4 +28,6 @@ private:\n> \tbool blackLevelSet_;\n> };\n> \n> +} /* namespace ipa::soft */\n> +\n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4D3B0C323E\n\tfor ;\n\tMon, 12 Aug 2024 13:10:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DD9DA633BE;\n\tMon, 12 Aug 2024 15:10:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB323633B3\n\tfor ;\n\tMon, 12 Aug 2024 15:10:27 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C5617CC\n\tfor ;\n\tMon, 12 Aug 2024 15:09:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JcNbCayB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723468171;\n\tbh=LP2RAs/nk039v1dB0X4fkGBD9635BnkpCik+NR+hzdQ=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=JcNbCayB4+s1pkgMnAGcbDTLVhw05a67Mx7rk4Zlae2vjaayUdEaVMWrtpPh6evTH\n\tGjvsCuWXczpru6X/I1TOsOUatY55bC3DUOXVPoUsrcJuKnKVl7EVzt70N/0UumJUFe\n\tOzUWHm/e51gYK5gQlQnq/LldMUGSafw5HNyfgxTo=","Message-ID":"<9144e789-2ff8-4241-bc9f-7a91e76b2158@ideasonboard.com>","Date":"Mon, 12 Aug 2024 14:10:24 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 06/23] libcamera: software_isp: Move BlackLevel to\n\tlibcamera::ipa::soft","To":"libcamera-devel@lists.libcamera.org","References":"<20240717085444.289997-1-mzamazal@redhat.com>\n\t<20240717085444.289997-7-mzamazal@redhat.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240717085444.289997-7-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]