[{"id":30737,"web_url":"https://patchwork.libcamera.org/comment/30737/","msgid":"<20240812122743.GD16961@pendragon.ideasonboard.com>","date":"2024-08-12T12:27:43","subject":"Re: [PATCH v3 03/23] libcamera: vimc: Drop ipa_interface.h header","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Jul 17, 2024 at 10:54:24AM +0200, Milan Zamazal wrote:\n> From: Umang Jain \n> \n> The ipa_interface.h header is already included in vimc_ipa_interface.h\n> generated from module_ipa_interface.h.tmpl. Drop it from the vimc IPA\n> and pipeline handler as deemed redundant.\n\nAs for 01/23, the first hunk should be dropped, and the commit message\nshould be updated.\n\n> Signed-off-by: Umang Jain \n> ---\n> src/ipa/vimc/vimc.cpp | 1 -\n> src/libcamera/pipeline/vimc/vimc.cpp | 1 -\n> 2 files changed, 2 deletions(-)\n> \n> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> index ebd63fa6..766e9c9c 100644\n> --- a/src/ipa/vimc/vimc.cpp\n> +++ b/src/ipa/vimc/vimc.cpp\n> @@ -16,7 +16,6 @@\n> #include \n> #include \n> \n> -#include \n> #include \n> \n> #include \"libcamera/internal/mapped_framebuffer.h\"\n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index 0ec9928e..838a9355 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -24,7 +24,6 @@\n> #include \n> #include \n> \n> -#include \n> #include \n> #include \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A770AC323E\n\tfor ;\n\tMon, 12 Aug 2024 12:28:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4FFB3633BD;\n\tMon, 12 Aug 2024 14:28:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 34D4F63369\n\tfor ;\n\tMon, 12 Aug 2024 14:28:06 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B9D9A6B5;\n\tMon, 12 Aug 2024 14:27:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i/SahDCn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723465630;\n\tbh=KWJ8E2tjKd++N/+eUM90ANWuaNFfza6Rbjh14T9fSMA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=i/SahDCnoPr2FwpjaflLh2r3POTgyH02FmrgQTaAkCQVBnp/sYRZd1/cvAnsOBgdz\n\tVKwad7JrOGMbD/uHoYyBlyt4gd3Gops46C8tUvtOoT7NdO0iA65IGeV6mAe8YlZJ9v\n\tGWUiVzvc+uv+fp9PtIeUquENNtr5pc8VA9XjECpg=","Date":"Mon, 12 Aug 2024 15:27:43 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org,\n\tUmang Jain ","Subject":"Re: [PATCH v3 03/23] libcamera: vimc: Drop ipa_interface.h header","Message-ID":"<20240812122743.GD16961@pendragon.ideasonboard.com>","References":"<20240717085444.289997-1-mzamazal@redhat.com>\n\t<20240717085444.289997-4-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240717085444.289997-4-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]