[{"id":30738,"web_url":"https://patchwork.libcamera.org/comment/30738/","msgid":"<20240812122858.GE16961@pendragon.ideasonboard.com>","date":"2024-08-12T12:28:58","subject":"Re: [PATCH v3 04/23] libcamera: ipa: soft_simple: Drop\n\tipa_interface.h header","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Jul 17, 2024 at 10:54:25AM +0200, Milan Zamazal wrote:\n> From: Umang Jain \n> \n> The ipa_interface.h header is already included in soft_ipa_interface.h\n> generated from module_ipa_interface.h.tmpl. Drop it from software-isp\n> IPA as deemed redundant.\n\nFor the reason explained in 01/23, this patch should be dropped.\n\n> Signed-off-by: Umang Jain \n> ---\n> src/ipa/simple/soft_simple.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\n> index b7746ce0..3cc873a2 100644\n> --- a/src/ipa/simple/soft_simple.cpp\n> +++ b/src/ipa/simple/soft_simple.cpp\n> @@ -19,7 +19,6 @@\n> #include \n> #include \n> \n> -#include \n> #include \n> #include \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2FE4EC323E\n\tfor ;\n\tMon, 12 Aug 2024 12:29:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C3476633BF;\n\tMon, 12 Aug 2024 14:29:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 75FC5633B3\n\tfor ;\n\tMon, 12 Aug 2024 14:29:21 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0CD5D6B5;\n\tMon, 12 Aug 2024 14:28:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SZ3Gr/XZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723465705;\n\tbh=TW4jBNUERkFkTkiqq72ZoUBIzhQk1XJFPjtjxnt25QY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SZ3Gr/XZdPWYXi//J6iEVPY10zQ7Uq3B9OXB3dsUWiYLEYoAY/DZ/6JNDYj9Q7UiQ\n\tc8hi0i3cuxVpVXfZTnUC6nImLjR/ThX8QYoXIBz9rKBZx4hSDR6VFUyLphtF5dgg7M\n\td7MpTYA6M2nT9JcLiPASrg0k8nejPsEj3rxkjkbQ=","Date":"Mon, 12 Aug 2024 15:28:58 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org,\n\tUmang Jain ","Subject":"Re: [PATCH v3 04/23] libcamera: ipa: soft_simple: Drop\n\tipa_interface.h header","Message-ID":"<20240812122858.GE16961@pendragon.ideasonboard.com>","References":"<20240717085444.289997-1-mzamazal@redhat.com>\n\t<20240717085444.289997-5-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240717085444.289997-5-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]