[{"id":30736,"web_url":"https://patchwork.libcamera.org/comment/30736/","msgid":"<20240812122606.GC16961@pendragon.ideasonboard.com>","date":"2024-08-12T12:26:06","subject":"Re: [PATCH v3 02/23] libcamera: ipa: ipu3: Drop ipa_interface.h\n\theader","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Jul 17, 2024 at 10:54:23AM +0200, Milan Zamazal wrote:\n> From: Umang Jain \n> \n> The ipa_interface.h header is already included in ipu3_ipa_interface.h\n> generated from module_ipa_interface.h.tmpl. Drop it as deemed redundant.\n\nFor the reason explained in the review of 01/23, this patch should be\ndropped.\n\n> Signed-off-by: Umang Jain \n> ---\n> src/ipa/ipu3/ipu3.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index cdcdf1fb..dca07970 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -24,7 +24,6 @@\n> \n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DA0F6C323E\n\tfor ;\n\tMon, 12 Aug 2024 12:26:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 91C21633B3;\n\tMon, 12 Aug 2024 14:26:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C24C663369\n\tfor ;\n\tMon, 12 Aug 2024 14:26:29 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 613866B5;\n\tMon, 12 Aug 2024 14:25:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GcM0+KTN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723465533;\n\tbh=OAPsE2v0/P0wueJPS97ti5K4jsl7sxIytvB5j1/Q7NY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GcM0+KTNWwqi0ILhx4pmR9/lSmd1S0GOEkHEtX2Fb17pZbHFfMI9hhg1hv49vTqYX\n\tViNDN7uWks8KqNEybxLF35aLin0s2FKtSduynOXRPtXmwo0/9Aigneg72aeJPOYLSc\n\tOT9i8kMRXCDHVK9gsyQeM7IUxs8rfLmkzprIqcNE=","Date":"Mon, 12 Aug 2024 15:26:06 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org,\n\tUmang Jain ","Subject":"Re: [PATCH v3 02/23] libcamera: ipa: ipu3: Drop ipa_interface.h\n\theader","Message-ID":"<20240812122606.GC16961@pendragon.ideasonboard.com>","References":"<20240717085444.289997-1-mzamazal@redhat.com>\n\t<20240717085444.289997-3-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240717085444.289997-3-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]