[{"id":30735,"web_url":"https://patchwork.libcamera.org/comment/30735/","msgid":"<20240812122507.GB16961@pendragon.ideasonboard.com>","date":"2024-08-12T12:25:07","subject":"Re: [PATCH v3 01/23] libcamera: rkisp1: Drop base IPA headers\n\tinclusion","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Jul 17, 2024 at 10:54:22AM +0200, Milan Zamazal wrote:\n> From: Umang Jain \n> \n> The IPA headers ipa_interface.h and core_ipa_interface.h are\n> included as part of the rkisp1_ipa_interface.h generated from\n> module_ipa_interface.h.tmpl. Drop them as deemed redundant.\n\nlibcamera/ipa/ipa_interface.h defines the interface exposed by the IPA\nmodule binary. That's the top-level ipaCreate() function, and the base\nIPAInterface class.\n\nThe file is included in rkisp1_ipa_interface.h for the definition of the\nIPAInterface class, as IPARkISP1Interface derives from it. rkisp1.cpp\ndoesn't make use of the base IPAInterface class, so there's no need to\ninclude ipa_interface.h for that.\n\nThe ipaCreate() function declaration, however, is needed by rkisp1.cpp.\nAs it's declared by ipa_interface.h, we include the header in the\ntop-level .cpp file of each IPA module, and I think it should stay\nthere, following the \"include what you use\" principle, to avoid\ndepending on indirect includes.\n\nCan you drop the first hunk of this patch and update the commit message\n?\n\n> Signed-off-by: Umang Jain \n> ---\n> src/ipa/rkisp1/rkisp1.cpp | 1 -\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 -\n> 2 files changed, 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 23e0826c..c5c85c8d 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -19,7 +19,6 @@\n> \n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 4cbf105d..97cd78a7 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -27,7 +27,6 @@\n> #include \n> #include \n> \n> -#include \n> #include \n> #include \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7159FBE173\n\tfor ;\n\tMon, 12 Aug 2024 12:25:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 96C24633B5;\n\tMon, 12 Aug 2024 14:25:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5153763369\n\tfor ;\n\tMon, 12 Aug 2024 14:25:31 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AD1186B5;\n\tMon, 12 Aug 2024 14:24:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bnDwyphL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723465474;\n\tbh=1lNbIlAeuliFDmzhzDni27ppPh+I9OrMmkbbzY6OJGg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bnDwyphL7KHz/9JU2qf8IwLvynkxunfgIq6+EnGLohqQefAIQAxt59s5Pe+87GUfG\n\tXtSvcGt5mlmG35d0mc9nLjLi7rkelFtTm+29MyZB6ViiWGbh4fpNX+JDJHE7/idpdi\n\tYSYo53W8acGYcPiV1mUJgchFDwf1vYYxQixphc1M=","Date":"Mon, 12 Aug 2024 15:25:07 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org,\n\tUmang Jain ","Subject":"Re: [PATCH v3 01/23] libcamera: rkisp1: Drop base IPA headers\n\tinclusion","Message-ID":"<20240812122507.GB16961@pendragon.ideasonboard.com>","References":"<20240717085444.289997-1-mzamazal@redhat.com>\n\t<20240717085444.289997-2-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240717085444.289997-2-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30743,"web_url":"https://patchwork.libcamera.org/comment/30743/","msgid":"<87wmklvray.fsf@redhat.com>","date":"2024-08-12T12:50:13","subject":"Re: [PATCH v3 01/23] libcamera: rkisp1: Drop base IPA headers\n\tinclusion","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Laurent,\n\nLaurent Pinchart writes:\n\n> On Wed, Jul 17, 2024 at 10:54:22AM +0200, Milan Zamazal wrote:\n>> From: Umang Jain \n>> \n>\n>> The IPA headers ipa_interface.h and core_ipa_interface.h are\n>> included as part of the rkisp1_ipa_interface.h generated from\n>> module_ipa_interface.h.tmpl. Drop them as deemed redundant.\n>\n> libcamera/ipa/ipa_interface.h defines the interface exposed by the IPA\n> module binary. That's the top-level ipaCreate() function, and the base\n> IPAInterface class.\n>\n> The file is included in rkisp1_ipa_interface.h for the definition of the\n> IPAInterface class, as IPARkISP1Interface derives from it. rkisp1.cpp\n> doesn't make use of the base IPAInterface class, so there's no need to\n> include ipa_interface.h for that.\n>\n> The ipaCreate() function declaration, however, is needed by rkisp1.cpp.\n> As it's declared by ipa_interface.h, we include the header in the\n> top-level .cpp file of each IPA module, and I think it should stay\n> there, following the \"include what you use\" principle, to avoid\n> depending on indirect includes.\n>\n> Can you drop the first hunk of this patch and update the commit message\n> ?\n\nOops, the first four patches by Umang were included by mistake, due to a\nwrong rebase, sorry about it.\n\nAnyway, maybe Umang would like to fix and resubmit this patch as\nexplained above? (If not, I can handle it as a penance for my\nmistake :-), separately from this series.)\n\n>> Signed-off-by: Umang Jain \n>> ---\n>> src/ipa/rkisp1/rkisp1.cpp | 1 -\n>> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 -\n>> 2 files changed, 2 deletions(-)\n>> \n>> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n>> index 23e0826c..c5c85c8d 100644\n>> --- a/src/ipa/rkisp1/rkisp1.cpp\n>> +++ b/src/ipa/rkisp1/rkisp1.cpp\n>> @@ -19,7 +19,6 @@\n>> \n>> #include \n>> #include \n>> -#include \n>> #include \n>> #include \n>> #include \n>> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>> index 4cbf105d..97cd78a7 100644\n>> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>> @@ -27,7 +27,6 @@\n>> #include \n>> #include \n>> \n>> -#include \n>> #include \n>> #include \n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 66F11C323E\n\tfor ;\n\tMon, 12 Aug 2024 12:50:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92EC6633B9;\n\tMon, 12 Aug 2024 14:50:20 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9566263398\n\tfor ;\n\tMon, 12 Aug 2024 14:50:18 +0200 (CEST)","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n\t[209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-171-FLZDxB8jPIWoPIsoQ65Ixw-1; Mon, 12 Aug 2024 08:50:16 -0400","by mail-wr1-f71.google.com with SMTP id\n\tffacd0b85a97d-36863648335so2347804f8f.0\n\tfor ;\n\tMon, 12 Aug 2024 05:50:16 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4290c7a6d15sm186717175e9.45.2024.08.12.05.50.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 12 Aug 2024 05:50:14 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Od4Ch/35\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1723467017;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=oKpIpMMeO7WEE/brFH19jC4dVBwYWfBw5JinQhzmEJY=;\n\tb=Od4Ch/35RUd1APjddanCbG99K8/08xindeqBWHDmafifBJKvhmqS+K3mJQ3Y7AWHXObW4D\n\tKLgPoCTD1oNjvnnDTWy3uI2FprrEyeFDoDMaXKXNlJsIzr66kAARzc1X40RGuGe1ADjqfz\n\td0qESUrKVFD6He49cQT2LjdsYhkyshQ=","X-MC-Unique":"FLZDxB8jPIWoPIsoQ65Ixw-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1723467015; x=1724071815;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=oKpIpMMeO7WEE/brFH19jC4dVBwYWfBw5JinQhzmEJY=;\n\tb=GKki6NXV8695Tn7/fJDqtX1z/zxdmuvWMXlG1B5Cm1QXuZbGRm1ItlDghgeWDJG2Go\n\tbUa5Ge+fHZHwewVa85ZrLtybImEPtwLx0XggQJrkuwksNzVbScMezz3c68s9QEC/f9cD\n\tLvOfNIM0YV1tRcr900PmZJKGZYbrhCN+d1m/zVknicYPPTCCPa9jxXppkWMzR9Fxz891\n\t6vPKBQGrF5GO50MQKSTv1x1+dRSsEBQjFHm1M9bZzEj764gICN+hvPHf7RKIVUUPQt9c\n\tErhays5iTimlyaSGECbOmJfZC+ZTbQArm5sPVE1+cNpPZiKi/6TLNO/U9lsake7dyXYF\n\tthMQ==","X-Gm-Message-State":"AOJu0YytL2e/+nPY/BCiN6QTp4ukCdP443TARj0KBVd9PJS+OLQlQAfN\n\tYjoYmpm80NI/+OiBujays0r1ALmx2KET5bgSzys4j49KtnKzpVXVIpOmpuKEybxkk/kpGcGYxMi\n\tPFjydEFlUn8IN0LPLI++T+xYHSrzW2pVy4rZwEWKut5m/UioB4l43MuAk6YTs9sJ5ITjNhDweN6\n\td4EKY=","X-Received":["by 2002:a05:6000:1a8d:b0:368:71bc:2b0c with SMTP id\n\tffacd0b85a97d-3716ccd6e42mr194695f8f.10.1723467014985; \n\tMon, 12 Aug 2024 05:50:14 -0700 (PDT)","by 2002:a05:6000:1a8d:b0:368:71bc:2b0c with SMTP id\n\tffacd0b85a97d-3716ccd6e42mr194672f8f.10.1723467014480; \n\tMon, 12 Aug 2024 05:50:14 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IGazyYLxrJbyN/5M4TdRVfgQx7I5vpVv5eJdnTae1TSIDjG+srcceTRI5TpvvJcgoMJZd2yvQ==","From":"Milan Zamazal ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, Umang Jain\n\t","Subject":"Re: [PATCH v3 01/23] libcamera: rkisp1: Drop base IPA headers\n\tinclusion","In-Reply-To":"<20240812122507.GB16961@pendragon.ideasonboard.com> (Laurent\n\tPinchart's message of \"Mon, 12 Aug 2024 15:25:07 +0300\")","References":"<20240717085444.289997-1-mzamazal@redhat.com>\n\t<20240717085444.289997-2-mzamazal@redhat.com>\n\t<20240812122507.GB16961@pendragon.ideasonboard.com>","Date":"Mon, 12 Aug 2024 14:50:13 +0200","Message-ID":"<87wmklvray.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30984,"web_url":"https://patchwork.libcamera.org/comment/30984/","msgid":"<87ttf2pc03.fsf@redhat.com>","date":"2024-08-30T09:59:24","subject":"Re: [PATCH v3 01/23] libcamera: rkisp1: Drop base IPA headers\n\tinclusion","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Milan Zamazal writes:\n\n> Hi Laurent,\n>\n> Laurent Pinchart writes:\n>\n>> On Wed, Jul 17, 2024 at 10:54:22AM +0200, Milan Zamazal wrote:\n>>> From: Umang Jain \n>>> \n>>\n>>> The IPA headers ipa_interface.h and core_ipa_interface.h are\n>>> included as part of the rkisp1_ipa_interface.h generated from\n>>> module_ipa_interface.h.tmpl. Drop them as deemed redundant.\n>>\n>> libcamera/ipa/ipa_interface.h defines the interface exposed by the IPA\n>> module binary. That's the top-level ipaCreate() function, and the base\n>> IPAInterface class.\n>>\n>> The file is included in rkisp1_ipa_interface.h for the definition of the\n>> IPAInterface class, as IPARkISP1Interface derives from it. rkisp1.cpp\n>> doesn't make use of the base IPAInterface class, so there's no need to\n>> include ipa_interface.h for that.\n>>\n>> The ipaCreate() function declaration, however, is needed by rkisp1.cpp.\n>> As it's declared by ipa_interface.h, we include the header in the\n>> top-level .cpp file of each IPA module, and I think it should stay\n>> there, following the \"include what you use\" principle, to avoid\n>> depending on indirect includes.\n>>\n>> Can you drop the first hunk of this patch and update the commit message\n>> ?\n>\n> Oops, the first four patches by Umang were included by mistake, due to a\n> wrong rebase, sorry about it.\n>\n> Anyway, maybe Umang would like to fix and resubmit this patch as\n> explained above? (If not, I can handle it as a penance for my\n> mistake :-), separately from this series.)\n\nAfter closer look, I can see the other include is also needed, so the\npatch can be dropped completely.\n\nFWIW LSP does a good job to indicate really unused headers. I'm trying\nto clean up the includes based on that. There may be some pitfalls but\nI suppose it's worth to attempt.\n\n>>> Signed-off-by: Umang Jain \n>>> ---\n>>> src/ipa/rkisp1/rkisp1.cpp | 1 -\n>>> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 -\n>>> 2 files changed, 2 deletions(-)\n>>> \n>>> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n>>> index 23e0826c..c5c85c8d 100644\n>>> --- a/src/ipa/rkisp1/rkisp1.cpp\n>>> +++ b/src/ipa/rkisp1/rkisp1.cpp\n>>> @@ -19,7 +19,6 @@\n>>> \n>>> #include \n>>> #include \n>>> -#include \n>>> #include \n>>> #include \n>>> #include \n>>> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>>> index 4cbf105d..97cd78a7 100644\n>>> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>>> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>>> @@ -27,7 +27,6 @@\n>>> #include \n>>> #include \n>>> \n>>> -#include \n>>> #include \n>>> #include \n>>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 89871C324C\n\tfor ;\n\tFri, 30 Aug 2024 09:59:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5CC8663466;\n\tFri, 30 Aug 2024 11:59:32 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B5EB633CD\n\tfor ;\n\tFri, 30 Aug 2024 11:59:31 +0200 (CEST)","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n\t[209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-342-d2QUr67SOH21UbB9e3-c0A-1; Fri, 30 Aug 2024 05:59:28 -0400","by mail-wm1-f69.google.com with SMTP id\n\t5b1f17b1804b1-4280d8e685eso15351735e9.1\n\tfor ;\n\tFri, 30 Aug 2024 02:59:28 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-42bb6df100csm40852765e9.20.2024.08.30.02.59.25\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 30 Aug 2024 02:59:25 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"NzBfmppn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725011970;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=bTA2NvMq7dp4BaPdPHFNDQvMachxTZZ+srnwPm9xuTU=;\n\tb=NzBfmppn6yQcvrSdNLegiA7gr2YRdhu0P7S5QIrIqlerDwP3GH35sX2ucH3Q82srit5s5Q\n\tbDYU9NHAo2hA6U9DwfiHUNVzXXqBbZfQ8eFZ5AqIE/MXxVZ+mLYs9zLccQGDAk94LuMJBb\n\tWzl06zIrN4064xtdM4GJm4oGTwBXhzc=","X-MC-Unique":"d2QUr67SOH21UbB9e3-c0A-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1725011967; x=1725616767;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=bTA2NvMq7dp4BaPdPHFNDQvMachxTZZ+srnwPm9xuTU=;\n\tb=Wm8DSQ55vhXVLfpR71wxY8QglE0yDtSs8qHuZF8qiox1JP7uTUM2qkLZ/iyu6bIDh/\n\t/sKJfplyuQnsY8pSwHjhAbAZq3bEnNM60hbOhxwXFrx3P7YQ46HPUaG3k+Q4d4T7Twve\n\tKvmsyaGm4cYXwOUWdikaJFdqaaNWRMl1LWyvQL7BHzwhoA8kk8wBNiFenNHZ1RR7yyKv\n\tucn0B6MoAPkjTo42aAKBYQtAt5QOQD4NiH3HQ3jscGDZyJ6vzb5M7FV1tl6VBdn7txqL\n\tkmhXftXIu+KYv4drP1BzkdguBnJiPMmhX23bXwKzDqpqUq/NKjunTwrGmmDupBX5Jw0V\n\t8kmw==","X-Gm-Message-State":"AOJu0Yzua4jjA0PmZ2vdA8dRc8kJVnaUiOTKcLiYM48LV5aMJk05nyLy\n\tsysZjt8MghIZMSv2WV0Q8rSTD3FUsyJZsugEEkUhk9b3n4CHjwWNJ2+/fRyCZjT5hR1xi7vPNFZ\n\t2/1gBrTQVD+fjx7FpFUyPvC6ZvOwX1s+sG9YBPYFgbKP80qZHaPrhtOhMkX+/ZKgUdB+AaLqdSM\n\tHE1zQ=","X-Received":["by 2002:a05:600c:3ba7:b0:426:622d:9e6b with SMTP id\n\t5b1f17b1804b1-42bb032c949mr46240845e9.23.1725011966890; \n\tFri, 30 Aug 2024 02:59:26 -0700 (PDT)","by 2002:a05:600c:3ba7:b0:426:622d:9e6b with SMTP id\n\t5b1f17b1804b1-42bb032c949mr46240725e9.23.1725011966376; \n\tFri, 30 Aug 2024 02:59:26 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IE2aqGGB+m5qePTKmAztXHSxZibIBDLvYtjyIGLyomzhOtDlKNxzVSi86MRHcAsalBTArjxLg==","From":"Milan Zamazal ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, Umang Jain\n\t","Subject":"Re: [PATCH v3 01/23] libcamera: rkisp1: Drop base IPA headers\n\tinclusion","In-Reply-To":"<87wmklvray.fsf@redhat.com> (Milan Zamazal's message of \"Mon, 12\n\tAug 2024 14:50:13 +0200\")","References":"<20240717085444.289997-1-mzamazal@redhat.com>\n\t<20240717085444.289997-2-mzamazal@redhat.com>\n\t<20240812122507.GB16961@pendragon.ideasonboard.com>\n\t<87wmklvray.fsf@redhat.com>","Date":"Fri, 30 Aug 2024 11:59:24 +0200","Message-ID":"<87ttf2pc03.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]