[{"id":30392,"web_url":"https://patchwork.libcamera.org/comment/30392/","msgid":"","date":"2024-07-12T15:30:00","subject":"Re: [PATCH v1 4/5] ipa: rkisp1: ccm: Fix ccm metadata output","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Stefan\n\nOn 12/07/2024 15:32, Stefan Klug wrote:\n> Only the first three entries of the matrix were set. Fix that.\n>\n> Fixes: cbfdfa42cacc (\"ipa: rkisp1: algorithms: Add crosstalk algorithm\")\n> Signed-off-by: Stefan Klug \n> ---\n\n\nReviewed-by: Daniel Scally \n\n> src/ipa/rkisp1/algorithms/ccm.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\n> index c1f5403a8ab2..4c4e3f5029a4 100644\n> --- a/src/ipa/rkisp1/algorithms/ccm.cpp\n> +++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n> @@ -135,7 +135,7 @@ void Ccm::process([[maybe_unused]] IPAContext &context,\n> \tfloat m[9];\n> \tfor (unsigned int i = 0; i < 3; i++) {\n> \t\tfor (unsigned int j = 0; j < 3; j++)\n> -\t\t\tm[i] = frameContext.ccm.ccm[i][j];\n> +\t\t\tm[i * 3 + j] = frameContext.ccm.ccm[i][j];\n> \t}\n> \tmetadata.set(controls::ColourCorrectionMatrix, m);\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E2AFBD87C\n\tfor ;\n\tFri, 12 Jul 2024 15:30:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 98BF363372;\n\tFri, 12 Jul 2024 17:30:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33CA962E17\n\tfor ;\n\tFri, 12 Jul 2024 17:30:04 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A67AD735\n\tfor ;\n\tFri, 12 Jul 2024 17:29:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vR0dFkgV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720798169;\n\tbh=NQ20XYUsxl/MAK+Ry8cIMKFdBqcnvF1SXlOQ/dctNQU=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=vR0dFkgVK/RfDiA5cy5eToF9onq4CgQ/j1wyBtetC8FckT+YoqZO3Lfx26oXi9mzH\n\t8LWcmgCvHa5+aO8/zui0MiCJ8uMyAsWroOM4RfRwmPD4zaH25wWyCq+tNaebUFon/Y\n\tOZ1j8OfN6kAybORg1GiJrYgmo0NwCl27lZmUTw/g=","Message-ID":"","Date":"Fri, 12 Jul 2024 16:30:00 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 4/5] ipa: rkisp1: ccm: Fix ccm metadata output","To":"libcamera-devel@lists.libcamera.org","References":"<20240712143227.3036702-1-stefan.klug@ideasonboard.com>\n\t<20240712143227.3036702-5-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240712143227.3036702-5-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30408,"web_url":"https://patchwork.libcamera.org/comment/30408/","msgid":"<172101152652.269677.16983773870409902696@ping.linuxembedded.co.uk>","date":"2024-07-15T02:45:26","subject":"Re: [PATCH v1 4/5] ipa: rkisp1: ccm: Fix ccm metadata output","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2024-07-12 15:32:05)\n> Only the first three entries of the matrix were set. Fix that.\n> \n> Fixes: cbfdfa42cacc (\"ipa: rkisp1: algorithms: Add crosstalk algorithm\")\n> Signed-off-by: Stefan Klug \n> ---\n> src/ipa/rkisp1/algorithms/ccm.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\n> index c1f5403a8ab2..4c4e3f5029a4 100644\n> --- a/src/ipa/rkisp1/algorithms/ccm.cpp\n> +++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n> @@ -135,7 +135,7 @@ void Ccm::process([[maybe_unused]] IPAContext &context,\n> float m[9];\n> for (unsigned int i = 0; i < 3; i++) {\n> for (unsigned int j = 0; j < 3; j++)\n> - m[i] = frameContext.ccm.ccm[i][j];\n> + m[i * 3 + j] = frameContext.ccm.ccm[i][j];\n> }\n\nOoops.\n\nI wonder if we'll ever expose a const data() accessor to just read out\nthe underlying array. That would imply/expose the knoweledge of the\nstorage here though, But for now ...\n\nReviewed-by: Kieran Bingham \n\n> metadata.set(controls::ColourCorrectionMatrix, m);\n> }\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BCDF8BDB1C\n\tfor ;\n\tMon, 15 Jul 2024 02:45:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9A0BF619A3;\n\tMon, 15 Jul 2024 04:45:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D58C1619A3\n\tfor ;\n\tMon, 15 Jul 2024 04:45:29 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 400FF465;\n\tMon, 15 Jul 2024 04:44:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"c2exKDw/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1721011493;\n\tbh=K7bxX1xvz2dr2kCPLLR1LxLoCzLpsMmBkrMjtmbAcvE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=c2exKDw/1DPMGdOzkau8t8aKzlRi+IqeTQnuYe284fdXTFfBevjeNFM/eeHhZimGp\n\tW3DAe1CB6BhEAh9xfOiIU3XTRP8xKWiPk/jZ2FRT35XAfnoT9JicoiQ4qctPdyiamA\n\tPBXwwVHipfo1vsLEeS0PHMJete0upbdULYLBpi/c=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240712143227.3036702-5-stefan.klug@ideasonboard.com>","References":"<20240712143227.3036702-1-stefan.klug@ideasonboard.com>\n\t<20240712143227.3036702-5-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v1 4/5] ipa: rkisp1: ccm: Fix ccm metadata output","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 15 Jul 2024 03:45:26 +0100","Message-ID":"<172101152652.269677.16983773870409902696@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30436,"web_url":"https://patchwork.libcamera.org/comment/30436/","msgid":"","date":"2024-07-19T07:20:55","subject":"Re: [PATCH v1 4/5] ipa: rkisp1: ccm: Fix ccm metadata output","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Fri, Jul 12, 2024 at 04:32:05PM +0200, Stefan Klug wrote:\n> Only the first three entries of the matrix were set. Fix that.\n> \n> Fixes: cbfdfa42cacc (\"ipa: rkisp1: algorithms: Add crosstalk algorithm\")\n> Signed-off-by: Stefan Klug \n\nOops...\n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/rkisp1/algorithms/ccm.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\n> index c1f5403a8ab2..4c4e3f5029a4 100644\n> --- a/src/ipa/rkisp1/algorithms/ccm.cpp\n> +++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n> @@ -135,7 +135,7 @@ void Ccm::process([[maybe_unused]] IPAContext &context,\n> \tfloat m[9];\n> \tfor (unsigned int i = 0; i < 3; i++) {\n> \t\tfor (unsigned int j = 0; j < 3; j++)\n> -\t\t\tm[i] = frameContext.ccm.ccm[i][j];\n> +\t\t\tm[i * 3 + j] = frameContext.ccm.ccm[i][j];\n> \t}\n> \tmetadata.set(controls::ColourCorrectionMatrix, m);\n> }\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7002C323E\n\tfor ;\n\tFri, 19 Jul 2024 07:21:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7134863373;\n\tFri, 19 Jul 2024 09:21:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8CF486336D\n\tfor ;\n\tFri, 19 Jul 2024 09:21:01 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-024.catv02.itscom.jp\n\t[175.177.49.24])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 85C1D471;\n\tFri, 19 Jul 2024 09:20:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZHWe+eHd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1721373622;\n\tbh=fSdqRz9uhjTF+GATUXrGuv3dobOTccQlNHgL56egJLk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZHWe+eHdlwzMNnFAiJ7vq95AejYEtAjucCPZRCDWToTXxv2YtgGzdACOov4ORuKtF\n\tc8lGAcj5ywG5iO3AV71yGWA6DRlduV9YO3lgbVZ+TAB/nmJz7Gq54LyboSFT5byDxa\n\teMPswjqUCGKCp0qPQQvLs525idLi6jr8s1BYqjqY=","Date":"Fri, 19 Jul 2024 16:20:55 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 4/5] ipa: rkisp1: ccm: Fix ccm metadata output","Message-ID":"","References":"<20240712143227.3036702-1-stefan.klug@ideasonboard.com>\n\t<20240712143227.3036702-5-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240712143227.3036702-5-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]