[{"id":30391,"web_url":"https://patchwork.libcamera.org/comment/30391/","msgid":"<00b1d954-18d1-4b69-aadf-244eb21b4905@ideasonboard.com>","date":"2024-07-12T15:26:52","subject":"Re: [PATCH v1 2/5] ipa rkisp1: Remove temperatureK from FrameContext","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Stefan\n\nOn 12/07/2024 15:32, Stefan Klug wrote:\n> The frame context is used to store data used for processing that frame.\n> It is later used to either act as input for other algorithms or to fill\n> the metadata. For the colour temperature this is not needed, as the\n> meatadata shall not contain the value that was active when the image was\n> processed, but the value that was calculated based on the statistics for\n> that image. This is no functional change.\n>\n> Signed-off-by: Stefan Klug \nReviewed-by: Daniel Scally \n> ---\n> src/ipa/rkisp1/algorithms/awb.cpp | 7 ++-----\n> src/ipa/rkisp1/ipa_context.h | 1 -\n> 2 files changed, 2 insertions(+), 6 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index 1a5d4776970a..18f750207793 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -277,7 +277,6 @@ void Awb::process(IPAContext &context,\n> \t */\n> \tif (redMean < kMeanMinThreshold && greenMean < kMeanMinThreshold &&\n> \t blueMean < kMeanMinThreshold) {\n> -\t\tframeContext.awb.temperatureK = activeState.awb.temperatureK;\n> \t\treturn;\n> \t}\n> \n> @@ -309,21 +308,19 @@ void Awb::process(IPAContext &context,\n> \tactiveState.awb.gains.automatic.blue = blueGain;\n> \tactiveState.awb.gains.automatic.green = 1.0;\n> \n> -\tframeContext.awb.temperatureK = activeState.awb.temperatureK;\n> -\n> \tmetadata.set(controls::AwbEnable, frameContext.awb.autoEnabled);\n> \tmetadata.set(controls::ColourGains, {\n> \t\t\tstatic_cast(frameContext.awb.gains.red),\n> \t\t\tstatic_cast(frameContext.awb.gains.blue)\n> \t\t});\n> -\tmetadata.set(controls::ColourTemperature, frameContext.awb.temperatureK);\n> +\tmetadata.set(controls::ColourTemperature, activeState.awb.temperatureK);\n> \n> \tLOG(RkISP1Awb, Debug) << std::showpoint\n> \t\t<< \"Means [\" << redMean << \", \" << greenMean << \", \" << blueMean\n> \t\t<< \"], gains [\" << activeState.awb.gains.automatic.red << \", \"\n> \t\t<< activeState.awb.gains.automatic.green << \", \"\n> \t\t<< activeState.awb.gains.automatic.blue << \"], temp \"\n> -\t\t<< frameContext.awb.temperatureK << \"K\";\n> +\t\t<< activeState.awb.temperatureK << \"K\";\n> }\n> \n> REGISTER_IPA_ALGORITHM(Awb, \"Awb\")\n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index 1d0e9030af1c..27a9bf62fc16 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -136,7 +136,6 @@ struct IPAFrameContext : public FrameContext {\n> \t\t\tdouble blue;\n> \t\t} gains;\n> \n> -\t\tunsigned int temperatureK;\n> \t\tbool autoEnabled;\n> \t} awb;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62189BD87C\n\tfor ;\n\tFri, 12 Jul 2024 15:27:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EF4246336F;\n\tFri, 12 Jul 2024 17:26:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4756962E17\n\tfor ;\n\tFri, 12 Jul 2024 17:26:56 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FC3D735\n\tfor ;\n\tFri, 12 Jul 2024 17:26:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ejo+QZ+7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720797981;\n\tbh=1DWDsaHox4Du9EebfAnZ6c4SOwdBcFc6uhVbCnfndTo=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=Ejo+QZ+7GewUK2OklHfrAny7eKUSA9jrnHdmboZzwkTRrRlWU1FY2pRn0R7NS+dFU\n\tcpHZl3wETJmByRQwCU5sAJLWnJHYVzUmV/msey9/YmAhZUbpdkEjKKwOvY2r1rh54A\n\tP8SE3BnFYSIZf/3e1pXH/TNk1bwSUoUryahKp6fs=","Message-ID":"<00b1d954-18d1-4b69-aadf-244eb21b4905@ideasonboard.com>","Date":"Fri, 12 Jul 2024 16:26:52 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 2/5] ipa rkisp1: Remove temperatureK from FrameContext","To":"libcamera-devel@lists.libcamera.org","References":"<20240712143227.3036702-1-stefan.klug@ideasonboard.com>\n\t<20240712143227.3036702-3-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240712143227.3036702-3-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30406,"web_url":"https://patchwork.libcamera.org/comment/30406/","msgid":"<172100084338.4121597.1485407596823174948@ping.linuxembedded.co.uk>","date":"2024-07-14T23:47:23","subject":"Re: [PATCH v1 2/5] ipa rkisp1: Remove temperatureK from FrameContext","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2024-07-12 15:32:03)\n> The frame context is used to store data used for processing that frame.\n> It is later used to either act as input for other algorithms or to fill\n> the metadata. For the colour temperature this is not needed, as the\n> meatadata shall not contain the value that was active when the image was\n> processed, but the value that was calculated based on the statistics for\n> that image. This is no functional change.\n\nDoes any other algo want to know the current colour temperature though?\n\nOh, I see - they would get that from the activestate ... ? which would\nthen always be the most recently calculated \n\n> Signed-off-by: Stefan Klug \n> ---\n> src/ipa/rkisp1/algorithms/awb.cpp | 7 ++-----\n> src/ipa/rkisp1/ipa_context.h | 1 -\n> 2 files changed, 2 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index 1a5d4776970a..18f750207793 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -277,7 +277,6 @@ void Awb::process(IPAContext &context,\n> */\n> if (redMean < kMeanMinThreshold && greenMean < kMeanMinThreshold &&\n> blueMean < kMeanMinThreshold) {\n> - frameContext.awb.temperatureK = activeState.awb.temperatureK;\n> return;\n> }\n\nThe braces then become redundant here if this is a simple return ...\n\nBut other than that..\n\nReviewed-by: Kieran Bingham \n\n> \n> @@ -309,21 +308,19 @@ void Awb::process(IPAContext &context,\n> activeState.awb.gains.automatic.blue = blueGain;\n> activeState.awb.gains.automatic.green = 1.0;\n> \n> - frameContext.awb.temperatureK = activeState.awb.temperatureK;\n> -\n> metadata.set(controls::AwbEnable, frameContext.awb.autoEnabled);\n> metadata.set(controls::ColourGains, {\n> static_cast(frameContext.awb.gains.red),\n> static_cast(frameContext.awb.gains.blue)\n> });\n> - metadata.set(controls::ColourTemperature, frameContext.awb.temperatureK);\n> + metadata.set(controls::ColourTemperature, activeState.awb.temperatureK);\n> \n> LOG(RkISP1Awb, Debug) << std::showpoint\n> << \"Means [\" << redMean << \", \" << greenMean << \", \" << blueMean\n> << \"], gains [\" << activeState.awb.gains.automatic.red << \", \"\n> << activeState.awb.gains.automatic.green << \", \"\n> << activeState.awb.gains.automatic.blue << \"], temp \"\n> - << frameContext.awb.temperatureK << \"K\";\n> + << activeState.awb.temperatureK << \"K\";\n> }\n> \n> REGISTER_IPA_ALGORITHM(Awb, \"Awb\")\n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index 1d0e9030af1c..27a9bf62fc16 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -136,7 +136,6 @@ struct IPAFrameContext : public FrameContext {\n> double blue;\n> } gains;\n> \n> - unsigned int temperatureK;\n> bool autoEnabled;\n> } awb;\n> \n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A051CBDB1C\n\tfor ;\n\tSun, 14 Jul 2024 23:47:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C200C6336F;\n\tMon, 15 Jul 2024 01:47:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 96F9B63364\n\tfor ;\n\tMon, 15 Jul 2024 01:47:26 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4D94C496;\n\tMon, 15 Jul 2024 01:46:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"I+PoOg4+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1721000810;\n\tbh=wo0I6/GaiGYft0/NIgbqpNZITfI6hIA3w6fIioaEHw0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=I+PoOg4+F0aMDTRMwwg86qYoRPNFjpDq9zjNsMEqbFCfZ9GZiY5k/gHUvKOTvtTyJ\n\tD3keVHSNNZDyJcjtxL2wwD/Qsk7guxADjW4jxWgJxkehaCNpmS6Iwse5l/72MRxD+J\n\tdLsVw31aQ0bnwWdjld1qWBfTL+y/s2Qx1+PsrQEg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240712143227.3036702-3-stefan.klug@ideasonboard.com>","References":"<20240712143227.3036702-1-stefan.klug@ideasonboard.com>\n\t<20240712143227.3036702-3-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v1 2/5] ipa rkisp1: Remove temperatureK from FrameContext","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 15 Jul 2024 00:47:23 +0100","Message-ID":"<172100084338.4121597.1485407596823174948@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30434,"web_url":"https://patchwork.libcamera.org/comment/30434/","msgid":"","date":"2024-07-19T07:17:45","subject":"Re: [PATCH v1 2/5] ipa rkisp1: Remove temperatureK from FrameContext","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Fri, Jul 12, 2024 at 04:32:03PM +0200, Stefan Klug wrote:\n> The frame context is used to store data used for processing that frame.\n> It is later used to either act as input for other algorithms or to fill\n> the metadata. For the colour temperature this is not needed, as the\n> meatadata shall not contain the value that was active when the image was\n> processed, but the value that was calculated based on the statistics for\n> that image. This is no functional change.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/rkisp1/algorithms/awb.cpp | 7 ++-----\n> src/ipa/rkisp1/ipa_context.h | 1 -\n> 2 files changed, 2 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index 1a5d4776970a..18f750207793 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -277,7 +277,6 @@ void Awb::process(IPAContext &context,\n> \t */\n> \tif (redMean < kMeanMinThreshold && greenMean < kMeanMinThreshold &&\n> \t blueMean < kMeanMinThreshold) {\n> -\t\tframeContext.awb.temperatureK = activeState.awb.temperatureK;\n> \t\treturn;\n> \t}\n> \n> @@ -309,21 +308,19 @@ void Awb::process(IPAContext &context,\n> \tactiveState.awb.gains.automatic.blue = blueGain;\n> \tactiveState.awb.gains.automatic.green = 1.0;\n> \n> -\tframeContext.awb.temperatureK = activeState.awb.temperatureK;\n> -\n> \tmetadata.set(controls::AwbEnable, frameContext.awb.autoEnabled);\n> \tmetadata.set(controls::ColourGains, {\n> \t\t\tstatic_cast(frameContext.awb.gains.red),\n> \t\t\tstatic_cast(frameContext.awb.gains.blue)\n> \t\t});\n> -\tmetadata.set(controls::ColourTemperature, frameContext.awb.temperatureK);\n> +\tmetadata.set(controls::ColourTemperature, activeState.awb.temperatureK);\n> \n> \tLOG(RkISP1Awb, Debug) << std::showpoint\n> \t\t<< \"Means [\" << redMean << \", \" << greenMean << \", \" << blueMean\n> \t\t<< \"], gains [\" << activeState.awb.gains.automatic.red << \", \"\n> \t\t<< activeState.awb.gains.automatic.green << \", \"\n> \t\t<< activeState.awb.gains.automatic.blue << \"], temp \"\n> -\t\t<< frameContext.awb.temperatureK << \"K\";\n> +\t\t<< activeState.awb.temperatureK << \"K\";\n> }\n> \n> REGISTER_IPA_ALGORITHM(Awb, \"Awb\")\n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index 1d0e9030af1c..27a9bf62fc16 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -136,7 +136,6 @@ struct IPAFrameContext : public FrameContext {\n> \t\t\tdouble blue;\n> \t\t} gains;\n> \n> -\t\tunsigned int temperatureK;\n> \t\tbool autoEnabled;\n> \t} awb;\n> \n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99111C323E\n\tfor ;\n\tFri, 19 Jul 2024 07:17:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 22A9963372;\n\tFri, 19 Jul 2024 09:17:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 64082619A3\n\tfor ;\n\tFri, 19 Jul 2024 09:17:52 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-024.catv02.itscom.jp\n\t[175.177.49.24])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D31F471;\n\tFri, 19 Jul 2024 09:17:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uAJfEu2Q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1721373433;\n\tbh=udcaTkYJW8wiFBQR5PcpBz8z4IYK+gc+Pj2pL5y4Y4E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uAJfEu2QHgij3E+nfXPI0MLFlwot6qqzJFUyVQCu9oN397U7SnlZFzEaIahqDyUC8\n\tBOYqpEV6MUBw0z8GVJvKRJxzTDDYO1NHvpRTSiZi1gYLOtV12D+Gig4Ap9eu6wYUyA\n\to3SSaUb+iQ2bUBiSSxvzHXkvbeTGAP6oGz9U5ud0=","Date":"Fri, 19 Jul 2024 16:17:45 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 2/5] ipa rkisp1: Remove temperatureK from FrameContext","Message-ID":"","References":"<20240712143227.3036702-1-stefan.klug@ideasonboard.com>\n\t<20240712143227.3036702-3-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240712143227.3036702-3-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]