[{"id":30417,"web_url":"https://patchwork.libcamera.org/comment/30417/","msgid":"","date":"2024-07-17T10:05:10","subject":"Re: [PATCH v5 4/5] libcamera: converter: Add DW100 converter class","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Umang\n\nOn Wed, Jul 10, 2024 at 01:51:50AM GMT, Umang Jain wrote:\n> DW100 Dewarp engine is present on i.MX8MP SoC. This patch\n> provides a converter class (inherited from V4L2M2MConverter).\n>\n> The DW100 dewarp engine has scaling capabilites and can be used\n> to set crop rectangles in the rkisp1 pipeline handler. Plumbing\n> in the RkISP1 pipeline-handler is done in the subsequent patch.\n>\n> The ConverterDW100 class can be extended later (as additional\n> development) to support the dewarping by setting a dewarp vertex\n> map as well.\n>\n> Signed-off-by: Umang Jain \n> ---\n> .../internal/converter/converter_dw100.h | 24 ++++++++++++\n> .../libcamera/internal/converter/meson.build | 1 +\n> src/libcamera/converter/converter_dw100.cpp | 37 +++++++++++++++++++\n> src/libcamera/converter/meson.build | 1 +\n> 4 files changed, 63 insertions(+)\n> create mode 100644 include/libcamera/internal/converter/converter_dw100.h\n> create mode 100644 src/libcamera/converter/converter_dw100.cpp\n>\n> diff --git a/include/libcamera/internal/converter/converter_dw100.h b/include/libcamera/internal/converter/converter_dw100.h\n> new file mode 100644\n> index 00000000..dc41f365\n> --- /dev/null\n> +++ b/include/libcamera/internal/converter/converter_dw100.h\n> @@ -0,0 +1,24 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2024, Ideas On Board Oy\n> + *\n> + * i.MX8MP Dewarp Engine integration\n> + */\n> +\n> +#pragma once\n> +\n> +#include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n> +\n> +namespace libcamera {\n> +\n> +class MediaDevice;\n> +class Rectangle;\n> +class Stream;\n> +\n> +class ConverterDW100 : public V4L2M2MConverter\n> +{\n> +public:\n> +\tConverterDW100(std::shared_ptr media);\n> +};\n> +\n> +} /* namespace libcamera */\n> diff --git a/include/libcamera/internal/converter/meson.build b/include/libcamera/internal/converter/meson.build\n> index 891e79e7..85007a4b 100644\n> --- a/include/libcamera/internal/converter/meson.build\n> +++ b/include/libcamera/internal/converter/meson.build\n> @@ -1,5 +1,6 @@\n> # SPDX-License-Identifier: CC0-1.0\n>\n> libcamera_internal_headers += files([\n> + 'converter_dw100.h',\n> 'converter_v4l2_m2m.h',\n> ])\n> diff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp\n> new file mode 100644\n> index 00000000..3061fc71\n> --- /dev/null\n> +++ b/src/libcamera/converter/converter_dw100.cpp\n> @@ -0,0 +1,37 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2024, Ideas On Board Oy\n> + *\n> + * i.MX8MP Dewarp Engine integration\n> + */\n> +\n> +#include \"libcamera/internal/converter/converter_dw100.h\"\n> +\n> +#include \n> +\n> +#include \n> +\n> +#include \"libcamera/internal/media_device.h\"\n> +#include \"libcamera/internal/v4l2_videodevice.h\"\n> +\n> +namespace libcamera {\n> +\n> +LOG_DECLARE_CATEGORY(Converter)\n> +\n> +/**\n> + * \\class libcamera::ConverterDW100\n> + * \\brief The i.MX8MP dewarp converter implements the converter interface based\n> + * on V4L2 M2M device.\n> +*/\n> +\n> +/**\n> + * \\fn ConverterDW100::ConverterDW100\n> + * \\brief Construct a ConverterDW100 instance\n> + * \\param[in] media The media device implementing the converter\n> + */\n> +ConverterDW100::ConverterDW100(std::shared_ptr media)\n> +\t: V4L2M2MConverter(media.get(), Feature::Crop)\n> +{\n> +}\n> +\n\nI might have missed where the matching compatible is added.\n\n> +} /* namespace libcamera */\n> diff --git a/src/libcamera/converter/meson.build b/src/libcamera/converter/meson.build\n> index 2aa72fe4..175581b8 100644\n> --- a/src/libcamera/converter/meson.build\n> +++ b/src/libcamera/converter/meson.build\n> @@ -1,5 +1,6 @@\n> # SPDX-License-Identifier: CC0-1.0\n>\n> libcamera_sources += files([\n> + 'converter_dw100.cpp',\n> 'converter_v4l2_m2m.cpp'\n> ])\n> --\n> 2.45.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8739C323E\n\tfor ;\n\tWed, 17 Jul 2024 10:05:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87DC963372;\n\tWed, 17 Jul 2024 12:05:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB48763369\n\tfor ;\n\tWed, 17 Jul 2024 12:05:14 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B9241836;\n\tWed, 17 Jul 2024 12:04:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fsZtsnWW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1721210676;\n\tbh=7S3Pdem6aMncTzx4yqkJQ5grteqXzZ7UDfSNsploR/M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fsZtsnWWpaw3DTPN9dyZT4MtbylVLp1Hk17y/eSHghMYncwg3n8+oxYmfwhLDOxA6\n\tqpxFpo0S4fivJNL+1hOWvFl5Hd6+e9SO0XECDyAVwOj0J4TkvERlaBBSAp0kZs58lK\n\tHB9XB0bNY9oLI+nD6E7LIp5cD32t7XZZ2Q/I64co=","Date":"Wed, 17 Jul 2024 12:05:10 +0200","From":"Jacopo Mondi ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v5 4/5] libcamera: converter: Add DW100 converter class","Message-ID":"","References":"<20240709202151.152289-1-umang.jain@ideasonboard.com>\n\t<20240709202151.152289-5-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240709202151.152289-5-umang.jain@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30420,"web_url":"https://patchwork.libcamera.org/comment/30420/","msgid":"<75bd9b85-50f0-46db-b977-313c23ed2e59@ideasonboard.com>","date":"2024-07-17T11:07:32","subject":"Re: [PATCH v5 4/5] libcamera: converter: Add DW100 converter class","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"On 17/07/24 3:35 pm, Jacopo Mondi wrote:\n> Hi Umang\n>\n> On Wed, Jul 10, 2024 at 01:51:50AM GMT, Umang Jain wrote:\n>> DW100 Dewarp engine is present on i.MX8MP SoC. This patch\n>> provides a converter class (inherited from V4L2M2MConverter).\n>>\n>> The DW100 dewarp engine has scaling capabilites and can be used\n>> to set crop rectangles in the rkisp1 pipeline handler. Plumbing\n>> in the RkISP1 pipeline-handler is done in the subsequent patch.\n>>\n>> The ConverterDW100 class can be extended later (as additional\n>> development) to support the dewarping by setting a dewarp vertex\n>> map as well.\n>>\n>> Signed-off-by: Umang Jain \n>> ---\n>> .../internal/converter/converter_dw100.h | 24 ++++++++++++\n>> .../libcamera/internal/converter/meson.build | 1 +\n>> src/libcamera/converter/converter_dw100.cpp | 37 +++++++++++++++++++\n>> src/libcamera/converter/meson.build | 1 +\n>> 4 files changed, 63 insertions(+)\n>> create mode 100644 include/libcamera/internal/converter/converter_dw100.h\n>> create mode 100644 src/libcamera/converter/converter_dw100.cpp\n>>\n>> diff --git a/include/libcamera/internal/converter/converter_dw100.h b/include/libcamera/internal/converter/converter_dw100.h\n>> new file mode 100644\n>> index 00000000..dc41f365\n>> --- /dev/null\n>> +++ b/include/libcamera/internal/converter/converter_dw100.h\n>> @@ -0,0 +1,24 @@\n>> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n>> +/*\n>> + * Copyright (C) 2024, Ideas On Board Oy\n>> + *\n>> + * i.MX8MP Dewarp Engine integration\n>> + */\n>> +\n>> +#pragma once\n>> +\n>> +#include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n>> +\n>> +namespace libcamera {\n>> +\n>> +class MediaDevice;\n>> +class Rectangle;\n>> +class Stream;\n>> +\n>> +class ConverterDW100 : public V4L2M2MConverter\n>> +{\n>> +public:\n>> +\tConverterDW100(std::shared_ptr media);\n>> +};\n>> +\n>> +} /* namespace libcamera */\n>> diff --git a/include/libcamera/internal/converter/meson.build b/include/libcamera/internal/converter/meson.build\n>> index 891e79e7..85007a4b 100644\n>> --- a/include/libcamera/internal/converter/meson.build\n>> +++ b/include/libcamera/internal/converter/meson.build\n>> @@ -1,5 +1,6 @@\n>> # SPDX-License-Identifier: CC0-1.0\n>>\n>> libcamera_internal_headers += files([\n>> + 'converter_dw100.h',\n>> 'converter_v4l2_m2m.h',\n>> ])\n>> diff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp\n>> new file mode 100644\n>> index 00000000..3061fc71\n>> --- /dev/null\n>> +++ b/src/libcamera/converter/converter_dw100.cpp\n>> @@ -0,0 +1,37 @@\n>> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n>> +/*\n>> + * Copyright (C) 2024, Ideas On Board Oy\n>> + *\n>> + * i.MX8MP Dewarp Engine integration\n>> + */\n>> +\n>> +#include \"libcamera/internal/converter/converter_dw100.h\"\n>> +\n>> +#include \n>> +\n>> +#include \n>> +\n>> +#include \"libcamera/internal/media_device.h\"\n>> +#include \"libcamera/internal/v4l2_videodevice.h\"\n>> +\n>> +namespace libcamera {\n>> +\n>> +LOG_DECLARE_CATEGORY(Converter)\n>> +\n>> +/**\n>> + * \\class libcamera::ConverterDW100\n>> + * \\brief The i.MX8MP dewarp converter implements the converter interface based\n>> + * on V4L2 M2M device.\n>> +*/\n>> +\n>> +/**\n>> + * \\fn ConverterDW100::ConverterDW100\n>> + * \\brief Construct a ConverterDW100 instance\n>> + * \\param[in] media The media device implementing the converter\n>> + */\n>> +ConverterDW100::ConverterDW100(std::shared_ptr media)\n>> +\t: V4L2M2MConverter(media.get(), Feature::Crop)\n>> +{\n>> +}\n>> +\n> I might have missed where the matching compatible is added.\n\nCurrently I have not, since compatible string is only for simple \npipeline handlers\n\nConverterDW100 present on I.MX8MP can be tested with ISI and simple \npipeline handler (with YUV sensor).\n\nI don't have a YUV sensor to test this particular use-case. Hence, I \nadded a \\todo to extend compatibles and REGISTER_CONVERTER macro to be \nadjusted at a later stage.\n\n>\n>> +} /* namespace libcamera */\n>> diff --git a/src/libcamera/converter/meson.build b/src/libcamera/converter/meson.build\n>> index 2aa72fe4..175581b8 100644\n>> --- a/src/libcamera/converter/meson.build\n>> +++ b/src/libcamera/converter/meson.build\n>> @@ -1,5 +1,6 @@\n>> # SPDX-License-Identifier: CC0-1.0\n>>\n>> libcamera_sources += files([\n>> + 'converter_dw100.cpp',\n>> 'converter_v4l2_m2m.cpp'\n>> ])\n>> --\n>> 2.45.2\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05B21C323E\n\tfor ;\n\tWed, 17 Jul 2024 11:07:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D987363370;\n\tWed, 17 Jul 2024 13:07:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 381E6619AB\n\tfor ;\n\tWed, 17 Jul 2024 13:07:37 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8DD1166F;\n\tWed, 17 Jul 2024 13:06:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aCi+RMCZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1721214419;\n\tbh=BM3NTicJSbKO0hYL7z+d50mmSnBUS7+hE725Jmp6XhA=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=aCi+RMCZSbHtyy9gS711Ysagd3+FUvn+MO9+WtbVsBYSYkjOwM+m2evygmrThIExg\n\tTf7BcwgkO25YzVdbFEnBhM1aEF8mvm9oHYRXoDpFVtK2Y17pzHzCqsRj3DOqMWOEGE\n\t8IILjKu5GRr8b8ZPSjy7DtBJknR9KEHm/zCbPSFM=","Message-ID":"<75bd9b85-50f0-46db-b977-313c23ed2e59@ideasonboard.com>","Date":"Wed, 17 Jul 2024 16:37:32 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v5 4/5] libcamera: converter: Add DW100 converter class","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20240709202151.152289-1-umang.jain@ideasonboard.com>\n\t<20240709202151.152289-5-umang.jain@ideasonboard.com>\n\t","Content-Language":"en-US","From":"Umang Jain ","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30431,"web_url":"https://patchwork.libcamera.org/comment/30431/","msgid":"","date":"2024-07-19T07:06:50","subject":"Re: [PATCH v5 4/5] libcamera: converter: Add DW100 converter class","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Jul 10, 2024 at 01:51:50AM +0530, Umang Jain wrote:\n> DW100 Dewarp engine is present on i.MX8MP SoC. This patch\n> provides a converter class (inherited from V4L2M2MConverter).\n> \n> The DW100 dewarp engine has scaling capabilites and can be used\n> to set crop rectangles in the rkisp1 pipeline handler. Plumbing\n> in the RkISP1 pipeline-handler is done in the subsequent patch.\n> \n> The ConverterDW100 class can be extended later (as additional\n> development) to support the dewarping by setting a dewarp vertex\n> map as well.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Paul Elder \n\n> ---\n> .../internal/converter/converter_dw100.h | 24 ++++++++++++\n> .../libcamera/internal/converter/meson.build | 1 +\n> src/libcamera/converter/converter_dw100.cpp | 37 +++++++++++++++++++\n> src/libcamera/converter/meson.build | 1 +\n> 4 files changed, 63 insertions(+)\n> create mode 100644 include/libcamera/internal/converter/converter_dw100.h\n> create mode 100644 src/libcamera/converter/converter_dw100.cpp\n> \n> diff --git a/include/libcamera/internal/converter/converter_dw100.h b/include/libcamera/internal/converter/converter_dw100.h\n> new file mode 100644\n> index 00000000..dc41f365\n> --- /dev/null\n> +++ b/include/libcamera/internal/converter/converter_dw100.h\n> @@ -0,0 +1,24 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2024, Ideas On Board Oy\n> + *\n> + * i.MX8MP Dewarp Engine integration\n> + */\n> +\n> +#pragma once\n> +\n> +#include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n> +\n> +namespace libcamera {\n> +\n> +class MediaDevice;\n> +class Rectangle;\n> +class Stream;\n> +\n> +class ConverterDW100 : public V4L2M2MConverter\n> +{\n> +public:\n> +\tConverterDW100(std::shared_ptr media);\n> +};\n> +\n> +} /* namespace libcamera */\n> diff --git a/include/libcamera/internal/converter/meson.build b/include/libcamera/internal/converter/meson.build\n> index 891e79e7..85007a4b 100644\n> --- a/include/libcamera/internal/converter/meson.build\n> +++ b/include/libcamera/internal/converter/meson.build\n> @@ -1,5 +1,6 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> libcamera_internal_headers += files([\n> + 'converter_dw100.h',\n> 'converter_v4l2_m2m.h',\n> ])\n> diff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp\n> new file mode 100644\n> index 00000000..3061fc71\n> --- /dev/null\n> +++ b/src/libcamera/converter/converter_dw100.cpp\n> @@ -0,0 +1,37 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2024, Ideas On Board Oy\n> + *\n> + * i.MX8MP Dewarp Engine integration\n> + */\n> +\n> +#include \"libcamera/internal/converter/converter_dw100.h\"\n> +\n> +#include \n> +\n> +#include \n> +\n> +#include \"libcamera/internal/media_device.h\"\n> +#include \"libcamera/internal/v4l2_videodevice.h\"\n> +\n> +namespace libcamera {\n> +\n> +LOG_DECLARE_CATEGORY(Converter)\n> +\n> +/**\n> + * \\class libcamera::ConverterDW100\n> + * \\brief The i.MX8MP dewarp converter implements the converter interface based\n> + * on V4L2 M2M device.\n> +*/\n> +\n> +/**\n> + * \\fn ConverterDW100::ConverterDW100\n> + * \\brief Construct a ConverterDW100 instance\n> + * \\param[in] media The media device implementing the converter\n> + */\n> +ConverterDW100::ConverterDW100(std::shared_ptr media)\n> +\t: V4L2M2MConverter(media.get(), Feature::Crop)\n> +{\n> +}\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/libcamera/converter/meson.build b/src/libcamera/converter/meson.build\n> index 2aa72fe4..175581b8 100644\n> --- a/src/libcamera/converter/meson.build\n> +++ b/src/libcamera/converter/meson.build\n> @@ -1,5 +1,6 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> libcamera_sources += files([\n> + 'converter_dw100.cpp',\n> 'converter_v4l2_m2m.cpp'\n> ])\n> -- \n> 2.45.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E946BDB1C\n\tfor ;\n\tFri, 19 Jul 2024 07:06:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B831A63372;\n\tFri, 19 Jul 2024 09:06:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 007F7619A3\n\tfor ;\n\tFri, 19 Jul 2024 09:06:56 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-024.catv02.itscom.jp\n\t[175.177.49.24])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F29AB2B3;\n\tFri, 19 Jul 2024 09:06:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QTQnigS+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1721372777;\n\tbh=1lhH4lQx+a9s5Rds39f3Nvfv+jnJCMjFbC2xLiKuf/8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QTQnigS+Cnbhz/qe5sCuQCLNe7GzOt9knRDrxrbX8L4wl4DufLQ4ZyGRwDfOYhbau\n\t1EPiYr/Ap5MXtcc3YGICzEXe+6ywvNQDDa2GWdnFz6EsNrsa1P3MU0988bRtxC0QaW\n\tEsfNcpRDhQb4flzd/Jnqar2Kx0VpdyTTRDFEPG10=","Date":"Fri, 19 Jul 2024 16:06:50 +0900","From":"Paul Elder ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v5 4/5] libcamera: converter: Add DW100 converter class","Message-ID":"","References":"<20240709202151.152289-1-umang.jain@ideasonboard.com>\n\t<20240709202151.152289-5-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240709202151.152289-5-umang.jain@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]