[{"id":31649,"web_url":"https://patchwork.libcamera.org/comment/31649/","msgid":"<172848577222.532453.4312206086954644211@ping.linuxembedded.co.uk>","date":"2024-10-09T14:56:12","subject":"Re: [PATCH v4 11/13] libcamera: mali-c55: Enable links between\n\tresizer and video node","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Daniel Scally (2024-07-09 15:39:11)\n> The mali-c55 driver now expects links to video devices to be enabled\n> in order for those devices to be streamed from / to. Enable the media\n> link between the resizers and their associated video device to fulfil\n> the requirement.\n> \n> Signed-off-by: Daniel Scally \n> ---\n> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> index c456a798..512a7489 100644\n> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> @@ -827,6 +827,17 @@ int PipelineHandlerMaliC55::configure(Camera *camera,\n> Stream *stream = streamConfig.stream();\n> MaliC55Pipe *pipe = pipeFromStream(data, stream);\n> \n> + /*\n> + * Enable the media link between the pipe's resizer and the\n> + * capture video device\n> + */\n> + const MediaEntity *rszEntity = pipe->resizer->entity();\n> + ret = rszEntity->getPadByIndex(1)->links()[0]->setEnabled(true);\n\nI'll be curious where this is in the pipeline and if we need to later\nhandle routes or other complexities - but for now I think it's fine.\n\nReviewed-by: Kieran Bingham \n\n> + if (ret) {\n> + LOG(MaliC55, Error) << \"Couldn't enable resizer's link\";\n> + return ret;\n> + }\n> +\n> if (isFormatRaw(streamConfig.pixelFormat))\n> ret = configureRawStream(data, streamConfig, subdevFormat);\n> else\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79F13C32DE\n\tfor ;\n\tWed, 9 Oct 2024 14:56:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3065C618C9;\n\tWed, 9 Oct 2024 16:56:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B026618C5\n\tfor ;\n\tWed, 9 Oct 2024 16:56:15 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ADAB32EC;\n\tWed, 9 Oct 2024 16:54:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aTMvtywM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728485677;\n\tbh=ihKMUNXqAWWra/5CUt0HEsVeWy+XzwnaP9n+O3CN9Bg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=aTMvtywMm0/OBcHi94kHCf+eKfs2DIXH3D4/mjrorW3xUUlK/7Nr2rxFgRCTBdVBW\n\tbA0LIeKjQyfQYMwHCnUuEVZ2mjNhVVwqEr4KhaH+0c1moI6Og6o9Jhy8Fvok6aS7bd\n\t9BhBSYX9JMR8kvzYLjT5d9SivlkbBbhU/DR1Ipq4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240709143913.3276983-12-dan.scally@ideasonboard.com>","References":"<20240709143913.3276983-1-dan.scally@ideasonboard.com>\n\t<20240709143913.3276983-12-dan.scally@ideasonboard.com>","Subject":"Re: [PATCH v4 11/13] libcamera: mali-c55: Enable links between\n\tresizer and video node","From":"Kieran Bingham ","Cc":"Daniel Scally ","To":"Daniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 09 Oct 2024 15:56:12 +0100","Message-ID":"<172848577222.532453.4312206086954644211@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]