[{"id":30516,"web_url":"https://patchwork.libcamera.org/comment/30516/","msgid":"<172241758648.392292.10457581421396871823@ping.linuxembedded.co.uk>","date":"2024-07-31T09:19:46","subject":"Re: [PATCH v2 2/3] libcamera: ipa_proxy: Unify configurationFile\n\targument name","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2024-07-08 13:38:02)\n> The argument name is different in the declaration and the definition.\n> Let's use the same one in both, namely `name'.\n> \n> Signed-off-by: Milan Zamazal \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/internal/ipa_proxy.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\n> index ed6a5bcf..5240f69f 100644\n> --- a/include/libcamera/internal/ipa_proxy.h\n> +++ b/include/libcamera/internal/ipa_proxy.h\n> @@ -31,7 +31,7 @@ public:\n> \n> bool isValid() const { return valid_; }\n> \n> - std::string configurationFile(const std::string &file) const;\n> + std::string configurationFile(const std::string &name) const;\n> \n> protected:\n> std::string resolvePath(const std::string &file) const;\n> -- \n> 2.44.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0422BDC71\n\tfor ;\n\tWed, 31 Jul 2024 09:19:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 94EE763374;\n\tWed, 31 Jul 2024 11:19:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 841B36336B\n\tfor ;\n\tWed, 31 Jul 2024 11:19:49 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9231EF85;\n\tWed, 31 Jul 2024 11:19:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YYdUEOBV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722417541;\n\tbh=5mWZrf/I3wg5+t7xdisVwd3fTd8i+dxLH4/amn9DnNk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=YYdUEOBVrJ6ka5/g0xtUdvR3IxE8hVr5zGm0I++/kOp5yLtsivmwE1LRz7bSHsQyV\n\t+8J57br1X0L+eOaf3dGZCRJqWPFqYS4fVktOmqQBko444P8YKxWok9RA74Bbhmal59\n\tmWNWy/IqOhVfFPg3BT29Qjqcb2ENiHzBpxV81vro=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240708123803.1006689-3-mzamazal@redhat.com>","References":"<20240708123803.1006689-1-mzamazal@redhat.com>\n\t<20240708123803.1006689-3-mzamazal@redhat.com>","Subject":"Re: [PATCH v2 2/3] libcamera: ipa_proxy: Unify configurationFile\n\targument name","From":"Kieran Bingham ","Cc":"Milan Zamazal ,\n\tLaurent Pinchart ","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Wed, 31 Jul 2024 10:19:46 +0100","Message-ID":"<172241758648.392292.10457581421396871823@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30518,"web_url":"https://patchwork.libcamera.org/comment/30518/","msgid":"<20240731092526.GP8146@pendragon.ideasonboard.com>","date":"2024-07-31T09:25:26","subject":"Re: [PATCH v2 2/3] libcamera: ipa_proxy: Unify configurationFile\n\targument name","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Jul 31, 2024 at 10:19:46AM +0100, Kieran Bingham wrote:\n> Quoting Milan Zamazal (2024-07-08 13:38:02)\n> > The argument name is different in the declaration and the definition.\n> > Let's use the same one in both, namely `name'.\n> > \n> > Signed-off-by: Milan Zamazal \n> \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> > ---\n> > include/libcamera/internal/ipa_proxy.h | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\n> > index ed6a5bcf..5240f69f 100644\n> > --- a/include/libcamera/internal/ipa_proxy.h\n> > +++ b/include/libcamera/internal/ipa_proxy.h\n> > @@ -31,7 +31,7 @@ public:\n> > \n> > bool isValid() const { return valid_; }\n> > \n> > - std::string configurationFile(const std::string &file) const;\n> > + std::string configurationFile(const std::string &name) const;\n> > \n> > protected:\n> > std::string resolvePath(const std::string &file) const;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D206C323E\n\tfor ;\n\tWed, 31 Jul 2024 09:25:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C3D263375;\n\tWed, 31 Jul 2024 11:25:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB6C36336F\n\tfor ;\n\tWed, 31 Jul 2024 11:25:47 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CFA42842;\n\tWed, 31 Jul 2024 11:24:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i1YMmu9b\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722417900;\n\tbh=QvxE6o470xybJ9F0UkK38VTyD8ldWJZTMigsPmEtvYk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=i1YMmu9b6HAaG1vZH+v7xDAKEdcHQkLqTq55zq7nTsxrmHEjRXX5cYYqKl+pCSERu\n\tyIrOqFIbjHGkLTvpvG2ok1KJm0kHFVzV8i0Ejw9gxqvJSpXIn94e66W9CDGrME0hDm\n\t3ZMjrTx0FyL8yvDlm9QBH5kY4j3FWToIS9ZCCM+w=","Date":"Wed, 31 Jul 2024 12:25:26 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 2/3] libcamera: ipa_proxy: Unify configurationFile\n\targument name","Message-ID":"<20240731092526.GP8146@pendragon.ideasonboard.com>","References":"<20240708123803.1006689-1-mzamazal@redhat.com>\n\t<20240708123803.1006689-3-mzamazal@redhat.com>\n\t<172241758648.392292.10457581421396871823@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<172241758648.392292.10457581421396871823@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]