[{"id":30366,"web_url":"https://patchwork.libcamera.org/comment/30366/","msgid":"<2a3eef47-649f-47be-9197-3feabd0ad97e@ideasonboard.com>","date":"2024-07-05T16:01:39","subject":"Re: [PATCH v4 12/23] libtuning: Be a bit more verbose","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Stefan\n\nOn 05/07/2024 15:41, Stefan Klug wrote:\n> Print a info on every image that gets processed and a warning on every\n> image that gets ignored.\n>\n> Signed-off-by: Stefan Klug \n> Reviewed-by: Paul Elder \n> ---\n> utils/tuning/libtuning/utils.py | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/utils/tuning/libtuning/utils.py b/utils/tuning/libtuning/utils.py\n> index 93c6c94ea2b0..dacda11312a2 100644\n> --- a/utils/tuning/libtuning/utils.py\n> +++ b/utils/tuning/libtuning/utils.py\n> @@ -92,7 +92,9 @@ def load_images(input_dir: str, config: dict, load_nonlsc: bool, load_lsc: bool)\n> images = []\n> for f in files:\n> color, lux, lsc_only = _parse_image_filename(f)\n> + logger.info(f'Process image \"{f.name}\" (color={color}, lux={lux}, lsc_only={lsc_only})')\n> if color is None:\n> + logger.warning(f'Ignoring \"{f.name}\" as it has no associated color temperature')\n> continue\n\n\nPersonally I think print the info line after the continue so that a file we're ignoring doesn't get \nboth, but either way:\n\n\nReviewed-by: Daniel Scally \n\n> \n> # Skip lsc image if we don't need it","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64A1FBEFBE\n\tfor ;\n\tFri, 5 Jul 2024 16:01:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A25262E24;\n\tFri, 5 Jul 2024 18:01:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A620B619BF\n\tfor ;\n\tFri, 5 Jul 2024 18:01:42 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2873F4CC\n\tfor ;\n\tFri, 5 Jul 2024 18:01:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Az+GMhrV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720195273;\n\tbh=sFaME/46gWRU66htDC/tPAQSCiYdYgdT+3fsKBjkigo=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=Az+GMhrVuSwZYsxpl+nsNn/3lSYeiB80ttcQlCdM0Cl+6luc6eLCT3k4QOVD63E++\n\t74NwfqrsrtLjsrDwDIFx5W7bFSAzC5FrlRNLuEAO+s+uQKndG/f1qvL/ZS/rEHnTrj\n\trcNl1oHxCxMwZeB2Z11LulUvtFYTvPn/2stRrjig=","Message-ID":"<2a3eef47-649f-47be-9197-3feabd0ad97e@ideasonboard.com>","Date":"Fri, 5 Jul 2024 17:01:39 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 12/23] libtuning: Be a bit more verbose","To":"libcamera-devel@lists.libcamera.org","References":"<20240705144209.418906-1-stefan.klug@ideasonboard.com>\n\t<20240705144209.418906-13-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240705144209.418906-13-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30368,"web_url":"https://patchwork.libcamera.org/comment/30368/","msgid":"","date":"2024-07-05T19:06:54","subject":"Re: [PATCH v4 12/23] libtuning: Be a bit more verbose","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Dan,\n\nThanks for the review.\n\nOn Fri, Jul 05, 2024 at 05:01:39PM +0100, Dan Scally wrote:\n> Hi Stefan\n> \n> On 05/07/2024 15:41, Stefan Klug wrote:\n> > Print a info on every image that gets processed and a warning on every\n> > image that gets ignored.\n> > \n> > Signed-off-by: Stefan Klug \n> > Reviewed-by: Paul Elder \n> > ---\n> > utils/tuning/libtuning/utils.py | 2 ++\n> > 1 file changed, 2 insertions(+)\n> > \n> > diff --git a/utils/tuning/libtuning/utils.py b/utils/tuning/libtuning/utils.py\n> > index 93c6c94ea2b0..dacda11312a2 100644\n> > --- a/utils/tuning/libtuning/utils.py\n> > +++ b/utils/tuning/libtuning/utils.py\n> > @@ -92,7 +92,9 @@ def load_images(input_dir: str, config: dict, load_nonlsc: bool, load_lsc: bool)\n> > images = []\n> > for f in files:\n> > color, lux, lsc_only = _parse_image_filename(f)\n> > + logger.info(f'Process image \"{f.name}\" (color={color}, lux={lux}, lsc_only={lsc_only})')\n> > if color is None:\n> > + logger.warning(f'Ignoring \"{f.name}\" as it has no associated color temperature')\n> > continue\n> \n> \n> Personally I think print the info line after the continue so that a file\n> we're ignoring doesn't get both, but either way:\n>\n\nAck. I'll fix that when merging.\n\nRegards,\nStefan\n\n\n> \n> Reviewed-by: Daniel Scally \n> \n> > # Skip lsc image if we don't need it","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7ABDABD87C\n\tfor ;\n\tFri, 5 Jul 2024 19:06:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 20049619BF;\n\tFri, 5 Jul 2024 21:06:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 020E3619BF\n\tfor ;\n\tFri, 5 Jul 2024 21:06:58 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:60b6:33a3:3a20:6030])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 46C554CC;\n\tFri, 5 Jul 2024 21:06:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oc+i5htl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720206388;\n\tbh=rTJBluzVsVv7xDfQ/XDPkTK2+yBhxvwqDj52QUry//k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oc+i5htliGtyksJjUYMFZPTyyu++vCiJvzVHol1FguiIa2bMtaXMrjPBo+FPjBJQy\n\tB0CadZx5scCmlCMtxeLwE2xxIh2/8MXeVZDr6HCXoJz/o8zZkAImzOP7uuVG1n3TkD\n\t3MpVZP5L5LxQ0qh6FBu/FEh9x1l+1qoWzSKCsYAE=","Date":"Fri, 5 Jul 2024 21:06:54 +0200","From":"Stefan Klug ","To":"Dan Scally ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v4 12/23] libtuning: Be a bit more verbose","Message-ID":"","References":"<20240705144209.418906-1-stefan.klug@ideasonboard.com>\n\t<20240705144209.418906-13-stefan.klug@ideasonboard.com>\n\t<2a3eef47-649f-47be-9197-3feabd0ad97e@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<2a3eef47-649f-47be-9197-3feabd0ad97e@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]