{"id":20597,"url":"https://patchwork.libcamera.org/api/patches/20597/?format=json","web_url":"https://patchwork.libcamera.org/patch/20597/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240705144209.418906-9-stefan.klug@ideasonboard.com>","date":"2024-07-05T14:41:44","name":"[v4,08/23] libtuning: Fix visualize_macbeth_chart()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"47082e02291a600f2ecc202b5308a0ab095c04e4","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20597/mbox/","series":[{"id":4446,"url":"https://patchwork.libcamera.org/api/series/4446/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4446","date":"2024-07-05T14:41:36","name":"Add ccm calibration to libtuning","version":4,"mbox":"https://patchwork.libcamera.org/series/4446/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20597/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20597/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01299C3240\n\tfor ;\n\tFri, 5 Jul 2024 14:42:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 964CB619C7;\n\tFri, 5 Jul 2024 16:42:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A53BF619C7\n\tfor ;\n\tFri, 5 Jul 2024 16:42:34 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:60b6:33a3:3a20:6030])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 260147F3;\n\tFri, 5 Jul 2024 16:42:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"u43/5xMF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720190525;\n\tbh=dTqRfHvl3XMGum+nbZJgo4z99tFr+h4U19miy1r5r2o=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=u43/5xMF7h/B96Itvbh6ADkOvTzDHYTePg0Bl9bX4cdgJoOoGiCxgr8fhPDyw2/zr\n\tmlL690/CuLfmKzmQE7127E16w0ow3DTRsekfO1rr4Gvomnvmpl612btWDQvDRaR5YC\n\tq051D6OBzX7n3/DUj4+/vlMrGIFb4v2VnfjsH86Y=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tPaul Elder ,\n\tLaurent Pinchart ","Subject":"[PATCH v4 08/23] libtuning: Fix visualize_macbeth_chart()","Date":"Fri, 5 Jul 2024 16:41:44 +0200","Message-ID":"<20240705144209.418906-9-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20240705144209.418906-1-stefan.klug@ideasonboard.com>","References":"<20240705144209.418906-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The old function uses PIL to save the image, which is not in the\nrequirements file. As we are already requiring opencv, use that to save\nimages instead of an additional dependency\n\nSigned-off-by: Stefan Klug \nReviewed-by: Paul Elder \nReviewed-by: Laurent Pinchart \n---\n utils/tuning/libtuning/utils.py | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/utils/tuning/libtuning/utils.py b/utils/tuning/libtuning/utils.py\nindex 872341407b7b..90fd7072a0fd 100644\n--- a/utils/tuning/libtuning/utils.py\n+++ b/utils/tuning/libtuning/utils.py\n@@ -5,6 +5,7 @@\n #\n # Utilities for libtuning\n \n+import cv2\n import decimal\n import math\n import numpy as np\n@@ -162,6 +163,6 @@ def visualise_macbeth_chart(macbeth_rgb, original_rgb, new_rgb, output_filename)\n for g in range(100):\n image[xlocation + i, ylocation + g] = new_rgb[colorindex]\n \n- img = Image.fromarray(image, 'RGB')\n- img.save(str(output_filename) + 'Generated Macbeth Chart.png')\n+ im_bgr = cv2.cvtColor(image, cv2.COLOR_RGB2BGR)\n+ cv2.imwrite(f'{output_filename} Generated Macbeth Chart.png', im_bgr)\n \n","prefixes":["v4","08/23"]}