{"id":20593,"url":"https://patchwork.libcamera.org/api/patches/20593/?format=json","web_url":"https://patchwork.libcamera.org/patch/20593/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240705144209.418906-5-stefan.klug@ideasonboard.com>","date":"2024-07-05T14:41:40","name":"[v4,04/23] libtuning: Copy visualize_macbeth_chart from raspberry pi","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"bdbe0195f5acdfda9765bc3bdfd110a56df3161a","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20593/mbox/","series":[{"id":4446,"url":"https://patchwork.libcamera.org/api/series/4446/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4446","date":"2024-07-05T14:41:36","name":"Add ccm calibration to libtuning","version":4,"mbox":"https://patchwork.libcamera.org/series/4446/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20593/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20593/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E77D7BD87C\n\tfor ;\n\tFri, 5 Jul 2024 14:42:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2AE966333F;\n\tFri, 5 Jul 2024 16:42:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 72FE3619C7\n\tfor ;\n\tFri, 5 Jul 2024 16:42:24 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:60b6:33a3:3a20:6030])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E15BE4CC;\n\tFri, 5 Jul 2024 16:41:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Yp5V/USu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720190515;\n\tbh=tlm1x0J5jmk30Y9C6Gp/GQ/L/wK4A7G359lvJLAwih8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Yp5V/USuEMJEgSnArtaMb4d7U50p9yifjJ4VWonv1GoWk8Vo3A3WZyIokGjdUTfw6\n\ttrOfrxNR+tNU+XNinM//hgjGphRjFfXpRul1MPfXHjo9w2sbrn1PZq5LOiUUSoCJjO\n\t6MOt83IYGSHaG2A6M+YdwtGeyy+4bhSw2v6gIfao=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tLaurent Pinchart ,\n\tPaul Elder ","Subject":"[PATCH v4 04/23] libtuning: Copy visualize_macbeth_chart from\n\traspberry pi","Date":"Fri, 5 Jul 2024 16:41:40 +0200","Message-ID":"<20240705144209.418906-5-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20240705144209.418906-1-stefan.klug@ideasonboard.com>","References":"<20240705144209.418906-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Copy visualize_macbeth_chart from raspberry pi. It is copied verbatim\nand does not work in this state.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Laurent Pinchart \nAcked-by: Paul Elder \n---\n utils/tuning/libtuning/utils.py | 43 +++++++++++++++++++++++++++++++++\n 1 file changed, 43 insertions(+)","diff":"diff --git a/utils/tuning/libtuning/utils.py b/utils/tuning/libtuning/utils.py\nindex 1e8128ea0571..f099c0ed685c 100644\n--- a/utils/tuning/libtuning/utils.py\n+++ b/utils/tuning/libtuning/utils.py\n@@ -123,3 +123,46 @@ def load_images(input_dir: str, config: dict, load_nonlsc: bool, load_lsc: bool)\n return None\n \n return images\n+\n+\n+\n+\"\"\"\n+Some code that will save virtual macbeth charts that show the difference between optimised matrices and non optimised matrices\n+\n+The function creates an image that is 1550 by 1050 pixels wide, and fills it with patches which are 200x200 pixels in size\n+Each patch contains the ideal color, the color from the original matrix, and the color from the final matrix\n+_________________\n+| |\n+| Ideal Color |\n+|_______________|\n+| Old | new |\n+| Color | Color |\n+|_______|_______|\n+\n+Nice way of showing how the optimisation helps change the colors and the color matricies\n+\"\"\"\n+def visualise_macbeth_chart(macbeth_rgb, original_rgb, new_rgb, output_filename):\n+ image = np.zeros((1050, 1550, 3), dtype=np.uint8)\n+ colorindex = -1\n+ for y in range(6):\n+ for x in range(4): # Creates 6 x 4 grid of macbeth chart\n+ colorindex += 1\n+ xlocation = 50 + 250 * x # Means there is 50px of black gap between each square, more like the real macbeth chart.\n+ ylocation = 50 + 250 * y\n+ for g in range(200):\n+ for i in range(100):\n+ image[xlocation + i, ylocation + g] = macbeth_rgb[colorindex]\n+ xlocation = 150 + 250 * x\n+ ylocation = 50 + 250 * y\n+ for i in range(100):\n+ for g in range(100):\n+ image[xlocation + i, ylocation + g] = original_rgb[colorindex] # Smaller squares below to compare the old colors with the new ones\n+ xlocation = 150 + 250 * x\n+ ylocation = 150 + 250 * y\n+ for i in range(100):\n+ for g in range(100):\n+ image[xlocation + i, ylocation + g] = new_rgb[colorindex]\n+\n+ img = Image.fromarray(image, 'RGB')\n+ img.save(str(output_filename) + 'Generated Macbeth Chart.png')\n+\n","prefixes":["v4","04/23"]}