[{"id":30357,"web_url":"https://patchwork.libcamera.org/comment/30357/","msgid":"","date":"2024-07-05T13:39:37","subject":"Re: [PATCH v2 10/11] ipa: rkisp1: Add compand feature flag to ipa\n\tcontext","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Paul, hi Laurent,\n\nThank you for the patch.\n\nOn Thu, Jul 04, 2024 at 07:20:34PM +0300, Laurent Pinchart wrote:\n> From: Paul Elder \n> \n> Add a compand feature flag to the hardware settings section of the IPA\n> context, so that we can act accordingly for black level subtraction, and\n> to pave the way to skipping companding appropriately when support for it\n> is added.\n> \n> Signed-off-by: Paul Elder \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n\n> ---\n> src/ipa/rkisp1/ipa_context.h | 1 +\n> src/ipa/rkisp1/rkisp1.cpp | 14 +++++++++++++-\n> 2 files changed, 14 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index 1d0e9030af1c..f5503ada7d8b 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -31,6 +31,7 @@ struct IPAHwSettings {\n> \tunsigned int numHistogramBins;\n> \tunsigned int numHistogramWeights;\n> \tunsigned int numGammaOutSamples;\n> +\tbool compand;\n> };\n> \n> struct IPASessionConfiguration {\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 1a89eabf10b4..083d5b08caff 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -93,6 +93,15 @@ const IPAHwSettings ipaHwSettingsV10{\n> \tRKISP1_CIF_ISP_HIST_BIN_N_MAX_V10,\n> \tRKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE_V10,\n> \tRKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES_V10,\n> +\tfalse,\n> +};\n> +\n> +const IPAHwSettings ipaHwSettingsIMX8MP{\n> +\tRKISP1_CIF_ISP_AE_MEAN_MAX_V10,\n> +\tRKISP1_CIF_ISP_HIST_BIN_N_MAX_V10,\n> +\tRKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE_V10,\n> +\tRKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES_V10,\n> +\ttrue,\n> };\n> \n> const IPAHwSettings ipaHwSettingsV12{\n> @@ -100,6 +109,7 @@ const IPAHwSettings ipaHwSettingsV12{\n> \tRKISP1_CIF_ISP_HIST_BIN_N_MAX_V12,\n> \tRKISP1_CIF_ISP_HISTOGRAM_WEIGHT_GRIDS_SIZE_V12,\n> \tRKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES_V12,\n> +\tfalse,\n> };\n> \n> /* List of controls handled by the RkISP1 IPA */\n> @@ -130,9 +140,11 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n> \t/* \\todo Add support for other revisions */\n> \tswitch (hwRevision) {\n> \tcase RKISP1_V10:\n> -\tcase RKISP1_V_IMX8MP:\n> \t\tcontext_.hw = &ipaHwSettingsV10;\n> \t\tbreak;\n> +\tcase RKISP1_V_IMX8MP:\n> +\t\tcontext_.hw = &ipaHwSettingsIMX8MP;\n> +\t\tbreak;\n> \tcase RKISP1_V12:\n> \t\tcontext_.hw = &ipaHwSettingsV12;\n> \t\tbreak;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7FA22BEFBE\n\tfor ;\n\tFri, 5 Jul 2024 13:39:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2FEAE62E22;\n\tFri, 5 Jul 2024 15:39:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB557619BF\n\tfor ;\n\tFri, 5 Jul 2024 15:39:39 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:60b6:33a3:3a20:6030])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F29B5541;\n\tFri, 5 Jul 2024 15:39:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WCZErdi7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720186750;\n\tbh=BscoO4T2+/80Fk5yJVui5fXH8LkdiFpO9yZ7p0s4MFw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WCZErdi752+e6kc1yIY7kYOBt+JFVjz/+/rOewWgbdjz0kBMSMccO8zpNh2/Hgv4e\n\tn7Fvy9qJ/JvpDtVpM653biQr/NwOhOCPptG1AvPG+2lh6rsp2UAsz5wjG3/FNQ2raT\n\t2GAuWsp016OXxzgbUIUJM9uh0eBQz/9S5Sm6kB6M=","Date":"Fri, 5 Jul 2024 15:39:37 +0200","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, \n\tJacopo Mondi ,\n\tPaul Elder ","Subject":"Re: [PATCH v2 10/11] ipa: rkisp1: Add compand feature flag to ipa\n\tcontext","Message-ID":"","References":"<20240704162035.15074-1-laurent.pinchart@ideasonboard.com>\n\t<20240704162035.15074-11-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240704162035.15074-11-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]