[{"id":30352,"web_url":"https://patchwork.libcamera.org/comment/30352/","msgid":"","date":"2024-07-05T12:45:12","subject":"Re: [PATCH v2 09/11] ipa: rkisp1: params: Add companding blocks","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Thu, Jul 04, 2024 at 07:20:33PM +0300, Laurent Pinchart wrote:\n> Extend the RkISP1 parameters helper with support for the new companding\n> blocks.\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> Changes since v1:\n> \n> - Fix block structure for expand and compress\n> ---\n> src/ipa/rkisp1/params.cpp | 3 +++\n> src/ipa/rkisp1/params.h | 6 ++++++\n> 2 files changed, 9 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/params.cpp b/src/ipa/rkisp1/params.cpp\n> index 7155038deb18..9a619ef82894 100644\n> --- a/src/ipa/rkisp1/params.cpp\n> +++ b/src/ipa/rkisp1/params.cpp\n> @@ -71,6 +71,9 @@ const std::map kBlockTypeInfo = {\n> \tRKISP1_BLOCK_TYPE_ENTRY_MEAS(Hst, HST, hst),\n> \tRKISP1_BLOCK_TYPE_ENTRY_MEAS(Aec, AEC, aec),\n> \tRKISP1_BLOCK_TYPE_ENTRY_MEAS(Afc, AFC, afc),\n> +\tRKISP1_BLOCK_TYPE_ENTRY_EXT(CompandBls, COMPAND_BLS, compand_bls),\n> +\tRKISP1_BLOCK_TYPE_ENTRY_EXT(CompandExpand, COMPAND_EXPAND, compand_curve),\n> +\tRKISP1_BLOCK_TYPE_ENTRY_EXT(CompandCompress, COMPAND_COMPRESS, compand_curve),\n> };\n> \n> } /* namespace */\n> diff --git a/src/ipa/rkisp1/params.h b/src/ipa/rkisp1/params.h\n> index 7a7bf07299b2..3d15102da20c 100644\n> --- a/src/ipa/rkisp1/params.h\n> +++ b/src/ipa/rkisp1/params.h\n> @@ -37,6 +37,9 @@ enum class Block {\n> \tHst,\n> \tAec,\n> \tAfc,\n> +\tCompandBls,\n> +\tCompandExpand,\n> +\tCompandCompress,\n> };\n> \n> namespace details {\n> @@ -68,6 +71,9 @@ RKISP1_DEFINE_BLOCK_TYPE(Awb, awb_meas)\n> RKISP1_DEFINE_BLOCK_TYPE(Hst, hst)\n> RKISP1_DEFINE_BLOCK_TYPE(Aec, aec)\n> RKISP1_DEFINE_BLOCK_TYPE(Afc, afc)\n> +RKISP1_DEFINE_BLOCK_TYPE(CompandBls, compand_bls)\n> +RKISP1_DEFINE_BLOCK_TYPE(CompandExpand, compand_curve)\n> +RKISP1_DEFINE_BLOCK_TYPE(CompandCompress, compand_curve)\n> \n> } /* namespace details */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1280FBEFBE\n\tfor ;\n\tFri, 5 Jul 2024 12:45:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC90262E25;\n\tFri, 5 Jul 2024 14:45:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C7B4619C7\n\tfor ;\n\tFri, 5 Jul 2024 14:45:20 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 65DD14CC;\n\tFri, 5 Jul 2024 14:44:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZUmtvmB4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720183490;\n\tbh=lJf7ZsH5nJA5fuNSCkjlbzlgeN1A2sAuvZ7CXudjJ10=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZUmtvmB4QlF3x4wWDcxPTRGnUZSU/HI1e5wIOR8zOnFj66WobMSF4C1AiK34NiQ2e\n\tmxEEJrK5GePflTG3Od6kNVArqG0uyjma22HTCTVz/YChuHvqdIEPMXG+4SSiwoG2Ru\n\tWYQqU/Kr9xYx31zPVTuTRDL5VMqt0f6dIgXMvh3w=","Date":"Fri, 5 Jul 2024 21:45:12 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org,\n\tJacopo Mondi ","Subject":"Re: [PATCH v2 09/11] ipa: rkisp1: params: Add companding blocks","Message-ID":"","References":"<20240704162035.15074-1-laurent.pinchart@ideasonboard.com>\n\t<20240704162035.15074-10-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240704162035.15074-10-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]