[{"id":30356,"web_url":"https://patchwork.libcamera.org/comment/30356/","msgid":"<psg5o56clpras5lknv4qdiwxoamdfe54osbju2zkhj7fsdz7he@dbt763enjxbd>","date":"2024-07-05T13:36:28","subject":"Re: [PATCH v2 08/11] include: rkisp1: Update header for compand\n\tparameters","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Paul, hi Laurent,\n\nThank you for the patch.\n\nOn Thu, Jul 04, 2024 at 07:20:32PM +0300, Laurent Pinchart wrote:\n> From: Paul Elder <paul.elder@ideasonboard.com>\n> \n> Update the rkisp1-config.h header with the definitions for the\n> companding block, which use the extensible parameters format. The\n> changes come from the \"[PATCH v2 0/5] media: rkisp1: Add support for the\n> companding block\" series posted to the linux-media mailing list and\n> available at [1].\n> \n> [1] https://lore.kernel.org/all/20240704154932.6686-1-laurent.pinchart@ideasonboard.com/\n> \n> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\nCheers,\nStefan\n\n\n> ---\n>  include/linux/rkisp1-config.h | 89 ++++++++++++++++++++++++++++++++++-\n>  1 file changed, 88 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/linux/rkisp1-config.h b/include/linux/rkisp1-config.h\n> index 2fe735943d02..848c7f72bc43 100644\n> --- a/include/linux/rkisp1-config.h\n> +++ b/include/linux/rkisp1-config.h\n> @@ -164,6 +164,11 @@\n>  #define RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS      17\n>  #define RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS  6\n>  \n> +/*\n> + * Compand\n> + */\n> +#define RKISP1_CIF_ISP_COMPAND_NUM_POINTS\t64\n> +\n>  /*\n>   * Measurement types\n>   */\n> @@ -851,6 +856,39 @@ struct rkisp1_params_cfg {\n>  \tstruct rkisp1_cif_isp_isp_other_cfg others;\n>  };\n>  \n> +/**\n> + * struct rkisp1_cif_isp_compand_bls_config - Rockchip ISP1 Companding parameters (BLS)\n> + * @r: Fixed subtraction value for Bayer pattern R\n> + * @gr: Fixed subtraction value for Bayer pattern Gr\n> + * @gb: Fixed subtraction value for Bayer pattern Gb\n> + * @b: Fixed subtraction value for Bayer pattern B\n> + *\n> + * The values will be subtracted from the sensor values. Note that unlike the\n> + * dedicated BLS block, the BLS values in the compander are 20-bit unsigned.\n> + */\n> +struct rkisp1_cif_isp_compand_bls_config {\n> +\t__u32 r;\n> +\t__u32 gr;\n> +\t__u32 gb;\n> +\t__u32 b;\n> +};\n> +\n> +/**\n> + * struct rkisp1_cif_isp_compand_curve_config - Rockchip ISP1 Companding\n> + * parameters (expand and compression curves)\n> + * @px: Compand curve x-values. Each value stores the distance from the\n> + *      previous x-value, expressed as log2 of the distance on 5 bits.\n> + * @x: Compand curve x-values. The functionality of these parameters are\n> + *     unknown due to do a lack of hardware documentation, but these are left\n> + *     here for future compatibility purposes.\n> + * @y: Compand curve y-values\n> + */\n> +struct rkisp1_cif_isp_compand_curve_config {\n> +\t__u8 px[RKISP1_CIF_ISP_COMPAND_NUM_POINTS];\n> +\t__u32 x[RKISP1_CIF_ISP_COMPAND_NUM_POINTS];\n> +\t__u32 y[RKISP1_CIF_ISP_COMPAND_NUM_POINTS];\n> +};\n> +\n>  /*---------- PART2: Measurement Statistics ------------*/\n>  \n>  /**\n> @@ -1018,6 +1056,9 @@ struct rkisp1_stat_buffer {\n>   * @RKISP1_EXT_PARAMS_BLOCK_TYPE_HST_MEAS: Histogram statistics\n>   * @RKISP1_EXT_PARAMS_BLOCK_TYPE_AEC_MEAS: Auto exposure statistics\n>   * @RKISP1_EXT_PARAMS_BLOCK_TYPE_AFC_MEAS: Auto-focus statistics\n> + * @RKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_BLS: BLS in the compand block\n> + * @RKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_EXPAND: Companding expand curve\n> + * @RKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_COMPRESS: Companding compress curve\n>   */\n>  enum rkisp1_ext_params_block_type {\n>  \tRKISP1_EXT_PARAMS_BLOCK_TYPE_BLS,\n> @@ -1037,6 +1078,9 @@ enum rkisp1_ext_params_block_type {\n>  \tRKISP1_EXT_PARAMS_BLOCK_TYPE_HST_MEAS,\n>  \tRKISP1_EXT_PARAMS_BLOCK_TYPE_AEC_MEAS,\n>  \tRKISP1_EXT_PARAMS_BLOCK_TYPE_AFC_MEAS,\n> +\tRKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_BLS,\n> +\tRKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_EXPAND,\n> +\tRKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_COMPRESS,\n>  };\n>  \n>  /**\n> @@ -1384,6 +1428,46 @@ struct rkisp1_ext_params_afc_config {\n>  \tstruct rkisp1_cif_isp_afc_config config;\n>  } __attribute__((aligned(8)));\n>  \n> +/**\n> + * struct rkisp1_ext_params_compand_bls_config - RkISP1 extensible params\n> + * Compand BLS config\n> + *\n> + * RkISP1 extensible parameters Companding configuration block (black level\n> + * subtraction). Identified by :c:type:`RKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_BLS`.\n> + *\n> + * @header: The RkISP1 extensible parameters header, see\n> + *\t    :c:type:`rkisp1_ext_params_block_header`\n> + * @config: Companding BLS configuration, see\n> + *\t    :c:type:`rkisp1_cif_isp_compand_bls_config`\n> + */\n> +struct rkisp1_ext_params_compand_bls_config {\n> +\tstruct rkisp1_ext_params_block_header header;\n> +\tstruct rkisp1_cif_isp_compand_bls_config config;\n> +} __attribute__((aligned(8)));\n> +\n> +/**\n> + * struct rkisp1_ext_params_compand_curve_config - RkISP1 extensible params\n> + * Compand curve config\n> + *\n> + * RkISP1 extensible parameters Companding configuration block (expand and\n> + * compression curves). Identified by\n> + * :c:type:`RKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_EXPAND`or\n> + * :c:type:`RKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_COMPRESS`.\n> + *\n> + * @header: The RkISP1 extensible parameters header, see\n> + *\t    :c:type:`rkisp1_ext_params_block_header`\n> + * @config: Companding curve configuration, see\n> + *\t    :c:type:`rkisp1_cif_isp_compand_curve_config`\n> + */\n> +struct rkisp1_ext_params_compand_curve_config {\n> +\tstruct rkisp1_ext_params_block_header header;\n> +\tstruct rkisp1_cif_isp_compand_curve_config config;\n> +} __attribute__((aligned(8)));\n> +\n> +/*\n> + * The rkisp1_ext_params_compand_curve_config structure is counted twice as it\n> + * is used for both the COMPAND_EXPAND and COMPAND_COMPRESS block types.\n> + */\n>  #define RKISP1_EXT_PARAMS_MAX_SIZE\t\t\t\t\t\\\n>  \t(sizeof(struct rkisp1_ext_params_bls_config)\t\t\t+\\\n>  \tsizeof(struct rkisp1_ext_params_dpcc_config)\t\t\t+\\\n> @@ -1401,7 +1485,10 @@ struct rkisp1_ext_params_afc_config {\n>  \tsizeof(struct rkisp1_ext_params_awb_meas_config)\t\t+\\\n>  \tsizeof(struct rkisp1_ext_params_hst_config)\t\t\t+\\\n>  \tsizeof(struct rkisp1_ext_params_aec_config)\t\t\t+\\\n> -\tsizeof(struct rkisp1_ext_params_afc_config))\n> +\tsizeof(struct rkisp1_ext_params_afc_config)\t\t\t+\\\n> +\tsizeof(struct rkisp1_ext_params_compand_bls_config)\t\t+\\\n> +\tsizeof(struct rkisp1_ext_params_compand_curve_config)\t\t+\\\n> +\tsizeof(struct rkisp1_ext_params_compand_curve_config))\n>  \n>  /**\n>   * enum rksip1_ext_param_buffer_version - RkISP1 extensible parameters version\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52B14BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  5 Jul 2024 13:36:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4746D62C99;\n\tFri,  5 Jul 2024 15:36:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4FA9619BF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  5 Jul 2024 15:36:31 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:60b6:33a3:3a20:6030])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D43657F3;\n\tFri,  5 Jul 2024 15:36:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gHLRxi8v\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720186561;\n\tbh=NE3f44n8mNu14pwA00Ni2XUyM5RuplWEeLficDVTJnQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gHLRxi8vT6I5h892tKvZ/AKn1w3I7ZFjqDZ2P0Y30hTfxJa9MgIGT2CSzlCsteF8S\n\tfIixhHmfoLovkP+trjp8+wtlpkPwiKbkQxv1SLKhwotcz/6FjMWG7Q2tfYDQUE4oRa\n\tEIbgyNmIb1VWKftg+4H693GhhS88QCa0tms0u5IY=","Date":"Fri, 5 Jul 2024 15:36:28 +0200","From":"Stefan Klug <stefan.klug@ideasonboard.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org, \n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>","Subject":"Re: [PATCH v2 08/11] include: rkisp1: Update header for compand\n\tparameters","Message-ID":"<psg5o56clpras5lknv4qdiwxoamdfe54osbju2zkhj7fsdz7he@dbt763enjxbd>","References":"<20240704162035.15074-1-laurent.pinchart@ideasonboard.com>\n\t<20240704162035.15074-9-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240704162035.15074-9-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":30360,"web_url":"https://patchwork.libcamera.org/comment/30360/","msgid":"<f1575dd4-c433-49f1-a35f-676e002f6fb0@ideasonboard.com>","date":"2024-07-05T14:29:35","subject":"Re: [PATCH v2 08/11] include: rkisp1: Update header for compand\n\tparameters","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Laurent, Paul\n\nOn 04/07/2024 17:20, Laurent Pinchart wrote:\n> From: Paul Elder <paul.elder@ideasonboard.com>\n>\n> Update the rkisp1-config.h header with the definitions for the\n> companding block, which use the extensible parameters format. The\n> changes come from the \"[PATCH v2 0/5] media: rkisp1: Add support for the\n> companding block\" series posted to the linux-media mailing list and\n> available at [1].\n>\n> [1] https://lore.kernel.org/all/20240704154932.6686-1-laurent.pinchart@ideasonboard.com/\n>\n> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n\n\nLooks good to me:\n\n\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\n\n>   include/linux/rkisp1-config.h | 89 ++++++++++++++++++++++++++++++++++-\n>   1 file changed, 88 insertions(+), 1 deletion(-)\n>\n> diff --git a/include/linux/rkisp1-config.h b/include/linux/rkisp1-config.h\n> index 2fe735943d02..848c7f72bc43 100644\n> --- a/include/linux/rkisp1-config.h\n> +++ b/include/linux/rkisp1-config.h\n> @@ -164,6 +164,11 @@\n>   #define RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS      17\n>   #define RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS  6\n>   \n> +/*\n> + * Compand\n> + */\n> +#define RKISP1_CIF_ISP_COMPAND_NUM_POINTS\t64\n> +\n>   /*\n>    * Measurement types\n>    */\n> @@ -851,6 +856,39 @@ struct rkisp1_params_cfg {\n>   \tstruct rkisp1_cif_isp_isp_other_cfg others;\n>   };\n>   \n> +/**\n> + * struct rkisp1_cif_isp_compand_bls_config - Rockchip ISP1 Companding parameters (BLS)\n> + * @r: Fixed subtraction value for Bayer pattern R\n> + * @gr: Fixed subtraction value for Bayer pattern Gr\n> + * @gb: Fixed subtraction value for Bayer pattern Gb\n> + * @b: Fixed subtraction value for Bayer pattern B\n> + *\n> + * The values will be subtracted from the sensor values. Note that unlike the\n> + * dedicated BLS block, the BLS values in the compander are 20-bit unsigned.\n> + */\n> +struct rkisp1_cif_isp_compand_bls_config {\n> +\t__u32 r;\n> +\t__u32 gr;\n> +\t__u32 gb;\n> +\t__u32 b;\n> +};\n> +\n> +/**\n> + * struct rkisp1_cif_isp_compand_curve_config - Rockchip ISP1 Companding\n> + * parameters (expand and compression curves)\n> + * @px: Compand curve x-values. Each value stores the distance from the\n> + *      previous x-value, expressed as log2 of the distance on 5 bits.\n> + * @x: Compand curve x-values. The functionality of these parameters are\n> + *     unknown due to do a lack of hardware documentation, but these are left\n> + *     here for future compatibility purposes.\n> + * @y: Compand curve y-values\n> + */\n> +struct rkisp1_cif_isp_compand_curve_config {\n> +\t__u8 px[RKISP1_CIF_ISP_COMPAND_NUM_POINTS];\n> +\t__u32 x[RKISP1_CIF_ISP_COMPAND_NUM_POINTS];\n> +\t__u32 y[RKISP1_CIF_ISP_COMPAND_NUM_POINTS];\n> +};\n> +\n>   /*---------- PART2: Measurement Statistics ------------*/\n>   \n>   /**\n> @@ -1018,6 +1056,9 @@ struct rkisp1_stat_buffer {\n>    * @RKISP1_EXT_PARAMS_BLOCK_TYPE_HST_MEAS: Histogram statistics\n>    * @RKISP1_EXT_PARAMS_BLOCK_TYPE_AEC_MEAS: Auto exposure statistics\n>    * @RKISP1_EXT_PARAMS_BLOCK_TYPE_AFC_MEAS: Auto-focus statistics\n> + * @RKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_BLS: BLS in the compand block\n> + * @RKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_EXPAND: Companding expand curve\n> + * @RKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_COMPRESS: Companding compress curve\n>    */\n>   enum rkisp1_ext_params_block_type {\n>   \tRKISP1_EXT_PARAMS_BLOCK_TYPE_BLS,\n> @@ -1037,6 +1078,9 @@ enum rkisp1_ext_params_block_type {\n>   \tRKISP1_EXT_PARAMS_BLOCK_TYPE_HST_MEAS,\n>   \tRKISP1_EXT_PARAMS_BLOCK_TYPE_AEC_MEAS,\n>   \tRKISP1_EXT_PARAMS_BLOCK_TYPE_AFC_MEAS,\n> +\tRKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_BLS,\n> +\tRKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_EXPAND,\n> +\tRKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_COMPRESS,\n>   };\n>   \n>   /**\n> @@ -1384,6 +1428,46 @@ struct rkisp1_ext_params_afc_config {\n>   \tstruct rkisp1_cif_isp_afc_config config;\n>   } __attribute__((aligned(8)));\n>   \n> +/**\n> + * struct rkisp1_ext_params_compand_bls_config - RkISP1 extensible params\n> + * Compand BLS config\n> + *\n> + * RkISP1 extensible parameters Companding configuration block (black level\n> + * subtraction). Identified by :c:type:`RKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_BLS`.\n> + *\n> + * @header: The RkISP1 extensible parameters header, see\n> + *\t    :c:type:`rkisp1_ext_params_block_header`\n> + * @config: Companding BLS configuration, see\n> + *\t    :c:type:`rkisp1_cif_isp_compand_bls_config`\n> + */\n> +struct rkisp1_ext_params_compand_bls_config {\n> +\tstruct rkisp1_ext_params_block_header header;\n> +\tstruct rkisp1_cif_isp_compand_bls_config config;\n> +} __attribute__((aligned(8)));\n> +\n> +/**\n> + * struct rkisp1_ext_params_compand_curve_config - RkISP1 extensible params\n> + * Compand curve config\n> + *\n> + * RkISP1 extensible parameters Companding configuration block (expand and\n> + * compression curves). Identified by\n> + * :c:type:`RKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_EXPAND`or\n> + * :c:type:`RKISP1_EXT_PARAMS_BLOCK_TYPE_COMPAND_COMPRESS`.\n> + *\n> + * @header: The RkISP1 extensible parameters header, see\n> + *\t    :c:type:`rkisp1_ext_params_block_header`\n> + * @config: Companding curve configuration, see\n> + *\t    :c:type:`rkisp1_cif_isp_compand_curve_config`\n> + */\n> +struct rkisp1_ext_params_compand_curve_config {\n> +\tstruct rkisp1_ext_params_block_header header;\n> +\tstruct rkisp1_cif_isp_compand_curve_config config;\n> +} __attribute__((aligned(8)));\n> +\n> +/*\n> + * The rkisp1_ext_params_compand_curve_config structure is counted twice as it\n> + * is used for both the COMPAND_EXPAND and COMPAND_COMPRESS block types.\n> + */\n>   #define RKISP1_EXT_PARAMS_MAX_SIZE\t\t\t\t\t\\\n>   \t(sizeof(struct rkisp1_ext_params_bls_config)\t\t\t+\\\n>   \tsizeof(struct rkisp1_ext_params_dpcc_config)\t\t\t+\\\n> @@ -1401,7 +1485,10 @@ struct rkisp1_ext_params_afc_config {\n>   \tsizeof(struct rkisp1_ext_params_awb_meas_config)\t\t+\\\n>   \tsizeof(struct rkisp1_ext_params_hst_config)\t\t\t+\\\n>   \tsizeof(struct rkisp1_ext_params_aec_config)\t\t\t+\\\n> -\tsizeof(struct rkisp1_ext_params_afc_config))\n> +\tsizeof(struct rkisp1_ext_params_afc_config)\t\t\t+\\\n> +\tsizeof(struct rkisp1_ext_params_compand_bls_config)\t\t+\\\n> +\tsizeof(struct rkisp1_ext_params_compand_curve_config)\t\t+\\\n> +\tsizeof(struct rkisp1_ext_params_compand_curve_config))\n>   \n>   /**\n>    * enum rksip1_ext_param_buffer_version - RkISP1 extensible parameters version","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC311BEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  5 Jul 2024 14:29:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C42AD619C7;\n\tFri,  5 Jul 2024 16:29:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 63EDB619BF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  5 Jul 2024 16:29:38 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A35DC4CC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  5 Jul 2024 16:29:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KzHjhgPA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720189748;\n\tbh=LMnfriGYIm255KgHiATCnaMrMmZeDo3077Qk6qhAQ4U=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=KzHjhgPAXXeoiabloeBxAcAKilSx1Pfb01zKgX+5DSb4ZRW+0aDQUZbqeG72zow3m\n\twy2TT5VmrIuN6/DlvGZ4YqpTG4g1i7jl9qlFR4yDmPhp3EenDx+CYzOLCjtjmzlUez\n\tcx+ulkrpCayW3Iukm6CLHq6KOJeOBMNlc9GoOj6E=","Message-ID":"<f1575dd4-c433-49f1-a35f-676e002f6fb0@ideasonboard.com>","Date":"Fri, 5 Jul 2024 15:29:35 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 08/11] include: rkisp1: Update header for compand\n\tparameters","To":"libcamera-devel@lists.libcamera.org","References":"<20240704162035.15074-1-laurent.pinchart@ideasonboard.com>\n\t<20240704162035.15074-9-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally <dan.scally@ideasonboard.com>","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240704162035.15074-9-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]