[{"id":30350,"web_url":"https://patchwork.libcamera.org/comment/30350/","msgid":"","date":"2024-07-05T12:42:39","subject":"Re: [PATCH v2 07/11] pipeline: rkisp1: Use the extensible parameters\n\tformat","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Thu, Jul 04, 2024 at 07:20:31PM +0300, Laurent Pinchart wrote:\n> From: Jacopo Mondi \n> \n> Now that the IPA module supports the extensible parameters format,\n> switch to it when available. If the kernel driver doesn't support the\n> new format, setFormat() will adjust paramFormat to the legacy format,\n> which will be passed to the IPA module, preserving backward\n> compatibility.\n> \n> Signed-off-by: Jacopo Mondi \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index f5c01a2566d2..177ded134dbc 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -799,7 +799,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \t}\n> \n> \tV4L2DeviceFormat paramFormat;\n> -\tparamFormat.fourcc = V4L2PixelFormat(V4L2_META_FMT_RK_ISP1_PARAMS);\n> +\tparamFormat.fourcc = V4L2PixelFormat(V4L2_META_FMT_RK_ISP1_EXT_PARAMS);\n> \tret = param_->setFormat(¶mFormat);\n> \tif (ret)\n> \t\treturn ret;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C9469BEFBE\n\tfor ;\n\tFri, 5 Jul 2024 12:42:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 74B3862E22;\n\tFri, 5 Jul 2024 14:42:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62740619BF\n\tfor ;\n\tFri, 5 Jul 2024 14:42:46 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C0FA94CC;\n\tFri, 5 Jul 2024 14:42:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CFKohIYG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720183336;\n\tbh=wKHIf7snsaZv07D3bbfzR5w5fUXgfTl8+Oy6YVdFcp4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CFKohIYG2PGco8Tnjcd1a0KYjvATawRQuB3qEzFKIte5OADGMa7pmU4K2IN3VWcMb\n\toS/gl8bv3VUtSMAgxKrQ/6d7KuV5Nzgw29V1tg5OGPbbD+upbxUnTqR/lpx0AfyyF2\n\tqNGakNz8JUs2tUzNEcty36qfU302kh8d0kYBUWPI=","Date":"Fri, 5 Jul 2024 21:42:39 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org,\n\tJacopo Mondi ","Subject":"Re: [PATCH v2 07/11] pipeline: rkisp1: Use the extensible parameters\n\tformat","Message-ID":"","References":"<20240704162035.15074-1-laurent.pinchart@ideasonboard.com>\n\t<20240704162035.15074-8-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240704162035.15074-8-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]