{"id":20584,"url":"https://patchwork.libcamera.org/api/patches/20584/?format=json","web_url":"https://patchwork.libcamera.org/patch/20584/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240704162035.15074-8-laurent.pinchart@ideasonboard.com>","date":"2024-07-04T16:20:31","name":"[v2,07/11] pipeline: rkisp1: Use the extensible parameters format","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d58b301a2af8365da1e587946f1c79ec6c9b24d1","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20584/mbox/","series":[{"id":4445,"url":"https://patchwork.libcamera.org/api/series/4445/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4445","date":"2024-07-04T16:20:24","name":"rkisp1: Support BLS on i.MX8MP","version":2,"mbox":"https://patchwork.libcamera.org/series/4445/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20584/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20584/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 38A44BD87C\n\tfor ;\n\tThu, 4 Jul 2024 16:21:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C3BEB6336A;\n\tThu, 4 Jul 2024 18:21:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4E8463339\n\tfor ;\n\tThu, 4 Jul 2024 18:21:03 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C7139502;\n\tThu, 4 Jul 2024 18:20:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IQht+/P8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720110034;\n\tbh=EqFIo8Oo6zvgh4IKxB0JZ0fd4pCNT7fxOksrrAbZFqk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=IQht+/P8JY6jF+kvNqsMCWV3KrZPwLq7gvoSOzZsElSt9SLU+4cFI24HGQznxMVce\n\tWdTxeYhcG/k4Po6bca5pEucscevUX3oweJdlnEU9G2fSD7lYhtxk1LV3IhjdmOp/2I\n\tpF5JpJKWrYy02/ZYqKK0r1iR2eO63xIXgJMs75IA=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ,\n\tPaul Elder ","Subject":"[PATCH v2 07/11] pipeline: rkisp1: Use the extensible parameters\n\tformat","Date":"Thu, 4 Jul 2024 19:20:31 +0300","Message-ID":"<20240704162035.15074-8-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","In-Reply-To":"<20240704162035.15074-1-laurent.pinchart@ideasonboard.com>","References":"<20240704162035.15074-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Jacopo Mondi \n\nNow that the IPA module supports the extensible parameters format,\nswitch to it when available. If the kernel driver doesn't support the\nnew format, setFormat() will adjust paramFormat to the legacy format,\nwhich will be passed to the IPA module, preserving backward\ncompatibility.\n\nSigned-off-by: Jacopo Mondi \nSigned-off-by: Laurent Pinchart \nReviewed-by: Jacopo Mondi \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex f5c01a2566d2..177ded134dbc 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -799,7 +799,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \t}\n \n \tV4L2DeviceFormat paramFormat;\n-\tparamFormat.fourcc = V4L2PixelFormat(V4L2_META_FMT_RK_ISP1_PARAMS);\n+\tparamFormat.fourcc = V4L2PixelFormat(V4L2_META_FMT_RK_ISP1_EXT_PARAMS);\n \tret = param_->setFormat(¶mFormat);\n \tif (ret)\n \t\treturn ret;\n","prefixes":["v2","07/11"]}