[{"id":30347,"web_url":"https://patchwork.libcamera.org/comment/30347/","msgid":"","date":"2024-07-05T11:42:49","subject":"Re: [PATCH v2 04/11] ipa: rkisp1: Pass parameters buffer size to\n\tpipeline handler","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Thu, Jul 04, 2024 at 07:20:28PM +0300, Laurent Pinchart wrote:\n> From: Jacopo Mondi \n> \n> The ISP parameters buffer currently has a fixed payload size, which is\n> hardcoded in the pipeline handler. To prepare for support of the\n> extensible parameters format that has a variable payload size, pass the\n> size from the IPA module to the pipeline handler explicitly. Keep the\n> size hardcoded to sizeof(struct rkisp1_params_cfg) for now, this will be\n> udpated later.\n> \n> Signed-off-by: Jacopo Mondi \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> include/libcamera/ipa/rkisp1.mojom | 2 +-\n> src/ipa/rkisp1/rkisp1.cpp | 2 +-\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 7 +++----\n> 3 files changed, 5 insertions(+), 6 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/rkisp1.mojom b/include/libcamera/ipa/rkisp1.mojom\n> index 585d38572aa2..80d54a03aa90 100644\n> --- a/include/libcamera/ipa/rkisp1.mojom\n> +++ b/include/libcamera/ipa/rkisp1.mojom\n> @@ -37,7 +37,7 @@ interface IPARkISP1Interface {\n> };\n> \n> interface IPARkISP1EventInterface {\n> -\tparamsBufferReady(uint32 frame);\n> +\tparamsBufferReady(uint32 frame, uint32 bytesused);\n> \tsetSensorControls(uint32 frame, libcamera.ControlList sensorControls);\n> \tmetadataReady(uint32 frame, libcamera.ControlList metadata);\n> };\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 71698bc47391..84ffe6cf2777 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -332,7 +332,7 @@ void IPARkISP1::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)\n> \tfor (auto const &algo : algorithms())\n> \t\talgo->prepare(context_, frame, frameContext, params);\n> \n> -\tparamsBufferReady.emit(frame);\n> +\tparamsBufferReady.emit(frame, sizeof(*params));\n> }\n> \n> void IPARkISP1::processStatsBuffer(const uint32_t frame, const uint32_t bufferId,\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 73e56b8fbf13..f5c01a2566d2 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -110,7 +110,7 @@ public:\n> \tstd::unique_ptr ipa_;\n> \n> private:\n> -\tvoid paramFilled(unsigned int frame);\n> +\tvoid paramFilled(unsigned int frame, unsigned int bytesused);\n> \tvoid setSensorControls(unsigned int frame,\n> \t\t\t const ControlList &sensorControls);\n> \n> @@ -379,15 +379,14 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision)\n> \treturn 0;\n> }\n> \n> -void RkISP1CameraData::paramFilled(unsigned int frame)\n> +void RkISP1CameraData::paramFilled(unsigned int frame, unsigned int bytesused)\n> {\n> \tPipelineHandlerRkISP1 *pipe = RkISP1CameraData::pipe();\n> \tRkISP1FrameInfo *info = frameInfo_.find(frame);\n> \tif (!info)\n> \t\treturn;\n> \n> -\tinfo->paramBuffer->_d()->metadata().planes()[0].bytesused =\n> -\t\tsizeof(struct rkisp1_params_cfg);\n> +\tinfo->paramBuffer->_d()->metadata().planes()[0].bytesused = bytesused;\n> \tpipe->param_->queueBuffer(info->paramBuffer);\n> \tpipe->stat_->queueBuffer(info->statBuffer);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81751BD87C\n\tfor ;\n\tFri, 5 Jul 2024 11:42:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 339A1619C7;\n\tFri, 5 Jul 2024 13:42:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 970DD619C7\n\tfor ;\n\tFri, 5 Jul 2024 13:42:55 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1745C541;\n\tFri, 5 Jul 2024 13:42:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IIuOvnvG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720179746;\n\tbh=QA1bIwpGr+dxbrMEQojBd4YdQsLXrIQHdFddlYMZ3HA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IIuOvnvG5ShPcSyEg6E84l2pdYwcnaccCicpHGCWHSk6gJdzAcDkOCaQLGI1MNWlu\n\tUHxFbdzSGGroYT0hwdXS2RxR7XdSV7Y0jUdMwkIvkGCHe/JDwYUzAd7JwZfhnhBivo\n\tCwDfjbthmncPj+ZBXyJ4OQRm+8mA3BN24wjZvLP0=","Date":"Fri, 5 Jul 2024 20:42:49 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org,\n\tJacopo Mondi ","Subject":"Re: [PATCH v2 04/11] ipa: rkisp1: Pass parameters buffer size to\n\tpipeline handler","Message-ID":"","References":"<20240704162035.15074-1-laurent.pinchart@ideasonboard.com>\n\t<20240704162035.15074-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240704162035.15074-5-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]