[{"id":30346,"web_url":"https://patchwork.libcamera.org/comment/30346/","msgid":"","date":"2024-07-05T11:41:39","subject":"Re: [PATCH v2 03/11] ipa: rkisp1: Pass parameters buffer format to\n\tIPA module","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Thu, Jul 04, 2024 at 07:20:27PM +0300, Laurent Pinchart wrote:\n> The rkisp1 driver supports two formats for the ISP parameters buffer,\n> the legacy fixed format and the new extensible format. In preparation of\n> support for the new format, pass the parameters buffer format from the\n> pipeline handler to the IPA module and store it.\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> include/libcamera/ipa/rkisp1.mojom | 1 +\n> src/ipa/rkisp1/rkisp1.cpp | 2 ++\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 +\n> 3 files changed, 4 insertions(+)\n> \n> diff --git a/include/libcamera/ipa/rkisp1.mojom b/include/libcamera/ipa/rkisp1.mojom\n> index 1009e970a1b5..585d38572aa2 100644\n> --- a/include/libcamera/ipa/rkisp1.mojom\n> +++ b/include/libcamera/ipa/rkisp1.mojom\n> @@ -11,6 +11,7 @@ import \"include/libcamera/ipa/core.mojom\";\n> struct IPAConfigInfo {\n> \tlibcamera.IPACameraSensorInfo sensorInfo;\n> \tlibcamera.ControlInfoMap sensorControls;\n> +\tuint32 paramFormat;\n> };\n> \n> interface IPARkISP1Interface {\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 23e0826cc335..71698bc47391 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -79,6 +79,7 @@ private:\n> \tstd::map mappedBuffers_;\n> \n> \tControlInfoMap sensorControls_;\n> +\tuint32_t paramFormat_;\n> \n> \t/* Local parameter storage */\n> \tstruct IPAContext context_;\n> @@ -208,6 +209,7 @@ int IPARkISP1::configure(const IPAConfigInfo &ipaConfig,\n> \t\t\t ControlInfoMap *ipaControls)\n> {\n> \tsensorControls_ = ipaConfig.sensorControls;\n> +\tparamFormat_ = ipaConfig.paramFormat;\n> \n> \tconst auto itExp = sensorControls_.find(V4L2_CID_EXPOSURE);\n> \tint32_t minExposure = itExp->second.min().get();\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 4cbf105dbdcd..73e56b8fbf13 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -819,6 +819,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \t\treturn ret;\n> \n> \tipaConfig.sensorControls = data->sensor_->controls();\n> +\tipaConfig.paramFormat = paramFormat.fourcc;\n> \n> \tret = data->ipa_->configure(ipaConfig, streamConfig, &data->controlInfo_);\n> \tif (ret) {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 240DEBEFBE\n\tfor ;\n\tFri, 5 Jul 2024 11:41:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 242FE62E26;\n\tFri, 5 Jul 2024 13:41:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 937A9619C7\n\tfor ;\n\tFri, 5 Jul 2024 13:41:46 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D78B7541;\n\tFri, 5 Jul 2024 13:41:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KW6ezaT8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720179677;\n\tbh=3t40elryQQf+rycJqlTdoCTsB+mB1nd+CZMBAgWpAWk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KW6ezaT8lycUG75ZkDdPKFF36jN42umZxXPVVUM0gE1ncL4jrLUagWBQhA4jL4k0w\n\tPKNERYD33zunNY1L7WfivkW8gXDMNx0KBiDWSOJ9xOTfy9EQqNtRWS1vkR8Z5tl0gy\n\tdmmbsZv7jD86QbdiNJFhbemSvx4TAcO3WZKatSfU=","Date":"Fri, 5 Jul 2024 20:41:39 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org,\n\tJacopo Mondi ","Subject":"Re: [PATCH v2 03/11] ipa: rkisp1: Pass parameters buffer format to\n\tIPA module","Message-ID":"","References":"<20240704162035.15074-1-laurent.pinchart@ideasonboard.com>\n\t<20240704162035.15074-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240704162035.15074-4-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]