[{"id":30345,"web_url":"https://patchwork.libcamera.org/comment/30345/","msgid":"","date":"2024-07-05T11:39:13","subject":"Re: [PATCH v2 02/11] include: videodev2: Add\n\tV4L2_META_FMT_RK_ISP1_EXT_PARAMS","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Thu, Jul 04, 2024 at 07:20:26PM +0300, Laurent Pinchart wrote:\n> From: Jacopo Mondi \n> \n> Signed-off-by: Jacopo Mondi \n\nAcked-by: Paul Elder \n\n> ---\n> include/linux/videodev2.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h\n> index 7fe522e85249..f3890072d913 100644\n> --- a/include/linux/videodev2.h\n> +++ b/include/linux/videodev2.h\n> @@ -829,6 +829,7 @@ struct v4l2_pix_format {\n> /* Vendor specific - used for RK_ISP1 camera sub-system */\n> #define V4L2_META_FMT_RK_ISP1_PARAMS\tv4l2_fourcc('R', 'K', '1', 'P') /* Rockchip ISP1 3A Parameters */\n> #define V4L2_META_FMT_RK_ISP1_STAT_3A\tv4l2_fourcc('R', 'K', '1', 'S') /* Rockchip ISP1 3A Statistics */\n> +#define V4L2_META_FMT_RK_ISP1_EXT_PARAMS\tv4l2_fourcc('R', 'K', '1', 'E') /* Rockchip ISP1 3a Extensible Parameters */\n> \n> /* The metadata format identifier for BE configuration buffers. */\n> #define V4L2_META_FMT_RPI_BE_CFG v4l2_fourcc('R', 'P', 'B', 'C')","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 724B9BEFBE\n\tfor ;\n\tFri, 5 Jul 2024 11:39:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 206EF62C99;\n\tFri, 5 Jul 2024 13:39:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19523619C7\n\tfor ;\n\tFri, 5 Jul 2024 13:39:20 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 85A9E541;\n\tFri, 5 Jul 2024 13:38:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AXL8xeU2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720179530;\n\tbh=4jYMfveOq3wUPxsWo46Ski3uhFE6AdZEKcVKYuHi1b0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=AXL8xeU2tnQyuN/0GlueIIX/2Pps/Enfc8QNumeJJaacTKxl53uS3d3PhS7NLVnDp\n\tKyc6jc4ReLg87ZVDjxdlmVvPla+Yeb4r4cGpcg0txRjK40b0aynVccYnshRDIzGhmB\n\t2tXJepNqWQHiQesqEzyFQjhNmymyolyQFCgNBVN8=","Date":"Fri, 5 Jul 2024 20:39:13 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org,\n\tJacopo Mondi ","Subject":"Re: [PATCH v2 02/11] include: videodev2: Add\n\tV4L2_META_FMT_RK_ISP1_EXT_PARAMS","Message-ID":"","References":"<20240704162035.15074-1-laurent.pinchart@ideasonboard.com>\n\t<20240704162035.15074-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240704162035.15074-3-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30353,"web_url":"https://patchwork.libcamera.org/comment/30353/","msgid":"","date":"2024-07-05T12:48:15","subject":"Re: [PATCH v2 02/11] include: videodev2: Add\n\tV4L2_META_FMT_RK_ISP1_EXT_PARAMS","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Jacopo, hi Laurent,\n\nThank you for the patch.\n\nOn Thu, Jul 04, 2024 at 07:20:26PM +0300, Laurent Pinchart wrote:\n> From: Jacopo Mondi \n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan \n\n> ---\n> include/linux/videodev2.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h\n> index 7fe522e85249..f3890072d913 100644\n> --- a/include/linux/videodev2.h\n> +++ b/include/linux/videodev2.h\n> @@ -829,6 +829,7 @@ struct v4l2_pix_format {\n> /* Vendor specific - used for RK_ISP1 camera sub-system */\n> #define V4L2_META_FMT_RK_ISP1_PARAMS\tv4l2_fourcc('R', 'K', '1', 'P') /* Rockchip ISP1 3A Parameters */\n> #define V4L2_META_FMT_RK_ISP1_STAT_3A\tv4l2_fourcc('R', 'K', '1', 'S') /* Rockchip ISP1 3A Statistics */\n> +#define V4L2_META_FMT_RK_ISP1_EXT_PARAMS\tv4l2_fourcc('R', 'K', '1', 'E') /* Rockchip ISP1 3a Extensible Parameters */\n> \n> /* The metadata format identifier for BE configuration buffers. */\n> #define V4L2_META_FMT_RPI_BE_CFG v4l2_fourcc('R', 'P', 'B', 'C')\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 95DBBBD87C\n\tfor ;\n\tFri, 5 Jul 2024 12:48:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C0B762E25;\n\tFri, 5 Jul 2024 14:48:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A720619C7\n\tfor ;\n\tFri, 5 Jul 2024 14:48:17 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:60b6:33a3:3a20:6030])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5DD124CC;\n\tFri, 5 Jul 2024 14:47:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WdvpAUxP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720183668;\n\tbh=06VZLfeJrQvkK53qHaMT2rilhy7TXYztXxX0pchTxS0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WdvpAUxPAOqdJvltpiW/dEaWI3zEjCL2BI5x3rm+lqLoeHo2tX9rnx0iBvwlvGlhV\n\tfeRP/UsdK0AkwSKRb1Qfjt0cc8BbN3Hl1jdeLvxf++DPv9YT+AqAKTZ6hO4gk7S9Lh\n\ttXNUu/SAnkh590a9ExTGnMsV+wj7pB/UYSanmAQ4=","Date":"Fri, 5 Jul 2024 14:48:15 +0200","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, \n\tJacopo Mondi ,\n\tPaul Elder ","Subject":"Re: [PATCH v2 02/11] include: videodev2: Add\n\tV4L2_META_FMT_RK_ISP1_EXT_PARAMS","Message-ID":"","References":"<20240704162035.15074-1-laurent.pinchart@ideasonboard.com>\n\t<20240704162035.15074-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240704162035.15074-3-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]