[{"id":30321,"web_url":"https://patchwork.libcamera.org/comment/30321/","msgid":"","date":"2024-07-04T10:56:50","subject":"Re: [PATCH v2 1/2] libcamera: base: utils: Implement hex() for 8-bit\n\tand 16-bit values","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch.\n\nOn Thu, Jul 04, 2024 at 01:07:27PM +0300, Laurent Pinchart wrote:\n> The utils::hex() function is implemented for 32-bit and 64-bit integers,\n> but not for 8-bit and 16-bit. This causes a link error (possibly at\n> runtime for IPA modules due to lazy linking) when trying to print 8-bit\n> or 16-bit integers. Implement additional specializations to fix it.\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Umang Jain \n\nReviewed-by: Stefan Klug \n\nRegards,\nStefan\n\n> ---\n> include/libcamera/base/utils.h | 24 ++++++++++++++++++++++++\n> 1 file changed, 24 insertions(+)\n> \n> diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\n> index 4ae02dc97478..734ff81e2860 100644\n> --- a/include/libcamera/base/utils.h\n> +++ b/include/libcamera/base/utils.h\n> @@ -90,6 +90,30 @@ template _hex hex(T value, unsigned int width = 0);\n> \n> #ifndef __DOXYGEN__\n> +template<>\n> +inline _hex hex(int8_t value, unsigned int width)\n> +{\n> +\treturn { static_cast(value), width ? width : 2 };\n> +}\n> +\n> +template<>\n> +inline _hex hex(uint8_t value, unsigned int width)\n> +{\n> +\treturn { static_cast(value), width ? width : 2 };\n> +}\n> +\n> +template<>\n> +inline _hex hex(int16_t value, unsigned int width)\n> +{\n> +\treturn { static_cast(value), width ? width : 4 };\n> +}\n> +\n> +template<>\n> +inline _hex hex(uint16_t value, unsigned int width)\n> +{\n> +\treturn { static_cast(value), width ? width : 4 };\n> +}\n> +\n> template<>\n> inline _hex hex(int32_t value, unsigned int width)\n> {\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 773E8BEFBE\n\tfor ;\n\tThu, 4 Jul 2024 10:56:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9971262E17;\n\tThu, 4 Jul 2024 12:56:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D4E6619C8\n\tfor ;\n\tThu, 4 Jul 2024 12:56:53 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:c01a:815:781:30fb])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9EECB502;\n\tThu, 4 Jul 2024 12:56:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"G/2kpk3+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720090584;\n\tbh=Ynxu8URKVpcwPMASeZZCsjuyDKv1aMMKBP/i/wX2Uh8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=G/2kpk3+NHrb3abla+0iIaNXHU6SFmrupy2fcNiJaZBkZU58s3zc6+TK8ur4L+eIs\n\tSvoMMFWW0Pa8vyBPL10lKAVntdS9/SlnZO1OHF36vgT0yhm4CG6fLeJ2GD+p6h89SI\n\tldaT4OBLkk8HpDdSxfU1nbpv+URRlfCVU4TrjI3E=","Date":"Thu, 4 Jul 2024 12:56:50 +0200","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 1/2] libcamera: base: utils: Implement hex() for 8-bit\n\tand 16-bit values","Message-ID":"","References":"<20240704100728.7003-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240704100728.7003-1-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]