[{"id":30330,"web_url":"https://patchwork.libcamera.org/comment/30330/","msgid":"","date":"2024-07-04T13:25:33","subject":"Re: [PATCH v1 09/11] ipa: rkisp1: params: Add companding blocks","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Thu, Jul 04, 2024 at 01:52:28AM GMT, Laurent Pinchart wrote:\n> Extend the RkISP1 parameters helper with support for the new companding\n> blocks.\n\nif the kernel side gets merged in one go, this can be squashed with\nthe introduction of RkISP1Params\n\nReviewed-by: Jacopo Mondi \n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/rkisp1/params.cpp | 3 +++\n> src/ipa/rkisp1/params.h | 6 ++++++\n> 2 files changed, 9 insertions(+)\n>\n> diff --git a/src/ipa/rkisp1/params.cpp b/src/ipa/rkisp1/params.cpp\n> index ac25ade1c8c4..5fb8fbf943a7 100644\n> --- a/src/ipa/rkisp1/params.cpp\n> +++ b/src/ipa/rkisp1/params.cpp\n> @@ -66,6 +66,9 @@ const std::map kBlockTypeInfo = {\n> \tRKISP1_BLOCK_TYPE_ENTRY_MEAS(Hst, HST, hst),\n> \tRKISP1_BLOCK_TYPE_ENTRY_MEAS(Aec, AEC, aec),\n> \tRKISP1_BLOCK_TYPE_ENTRY_MEAS(Afc, AFC, afc),\n> +\tRKISP1_BLOCK_TYPE_ENTRY_EXT(CompandBls, COMPAND_BLS, compand_bls),\n> +\tRKISP1_BLOCK_TYPE_ENTRY_EXT(CompandExpand, COMPAND_EXPAND, compand_curve),\n> +\tRKISP1_BLOCK_TYPE_ENTRY_EXT(CompandCompress, COMPAND_COMPRESS, compand_curve),\n> };\n>\n> } /* namespace */\n> diff --git a/src/ipa/rkisp1/params.h b/src/ipa/rkisp1/params.h\n> index ddd081de7894..13b2bbbb8182 100644\n> --- a/src/ipa/rkisp1/params.h\n> +++ b/src/ipa/rkisp1/params.h\n> @@ -37,6 +37,9 @@ enum class Block {\n> \tHst,\n> \tAec,\n> \tAfc,\n> +\tCompandBls,\n> +\tCompandExpand,\n> +\tCompandCompress,\n> };\n>\n> namespace details {\n> @@ -68,6 +71,9 @@ RKISP1_DEFINE_BLOCK_TYPE(Awb, awb_meas)\n> RKISP1_DEFINE_BLOCK_TYPE(Hst, hst)\n> RKISP1_DEFINE_BLOCK_TYPE(Aec, aec)\n> RKISP1_DEFINE_BLOCK_TYPE(Afc, afc)\n> +RKISP1_DEFINE_BLOCK_TYPE(CompandBls, compand_bls)\n> +RKISP1_DEFINE_BLOCK_TYPE(CompandExpand, compand_expand)\n> +RKISP1_DEFINE_BLOCK_TYPE(CompandCompress, compand_compress)\n>\n> } /* namespace details */\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5EFB3BD87C\n\tfor ;\n\tThu, 4 Jul 2024 13:25:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18D7262C99;\n\tThu, 4 Jul 2024 15:25:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 22F56619C8\n\tfor ;\n\tThu, 4 Jul 2024 15:25:37 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F7BE502;\n\tThu, 4 Jul 2024 15:25:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VB7BAE+w\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720099508;\n\tbh=e69GhNVXfZWbS1SgLDiJ1pZadJHVZDR095vCG6pA5nA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VB7BAE+wPP8Hfusk9pQ+G4EhyvbGmBZWF+UmXJ4xV8+aYA3e08pqgjHntRjVzSRrY\n\tevUELYrJgMe6Vgs1lWb3KIGFnPMHsJTHZFq5QxiMGJ147biPtON9Mmo9MYjO2rX7oQ\n\td/rUSJRfpu603nUw8SB4z4VOJXIhd57odJSiWvRk=","Date":"Thu, 4 Jul 2024 15:25:33 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, \n\tJacopo Mondi ,\n\tPaul Elder ","Subject":"Re: [PATCH v1 09/11] ipa: rkisp1: params: Add companding blocks","Message-ID":"","References":"<20240703225230.3530-1-laurent.pinchart@ideasonboard.com>\n\t<20240703225230.3530-10-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240703225230.3530-10-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]