[{"id":30328,"web_url":"https://patchwork.libcamera.org/comment/30328/","msgid":"","date":"2024-07-04T12:34:19","subject":"Re: [PATCH v1 07/11] pipeline: rkisp1: Use the extensible parameters\n\tformat","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"HI Laurent\n\nOn Thu, Jul 04, 2024 at 01:52:26AM GMT, Laurent Pinchart wrote:\n> From: Jacopo Mondi \n>\n> Now that the IPA module supports the extensible parameters format,\n> switch to it when available. If the kernel driver doesn't support the\n> new format, setFormat() will adjust paramFormat to the legacy format,\n> which will be passed to the IPA module, preserving backward\n> compatibility.\n>\n> Signed-off-by: Jacopo Mondi \n> Signed-off-by: Laurent Pinchart \n\neasy\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index f5c01a2566d2..177ded134dbc 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -799,7 +799,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \t}\n>\n> \tV4L2DeviceFormat paramFormat;\n> -\tparamFormat.fourcc = V4L2PixelFormat(V4L2_META_FMT_RK_ISP1_PARAMS);\n> +\tparamFormat.fourcc = V4L2PixelFormat(V4L2_META_FMT_RK_ISP1_EXT_PARAMS);\n> \tret = param_->setFormat(¶mFormat);\n> \tif (ret)\n> \t\treturn ret;\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1FC4EBD87C\n\tfor ;\n\tThu, 4 Jul 2024 12:34:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CE15E62E17;\n\tThu, 4 Jul 2024 14:34:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BACE62C99\n\tfor ;\n\tThu, 4 Jul 2024 14:34:21 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CC9B963D;\n\tThu, 4 Jul 2024 14:33:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PivBKoy3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720096432;\n\tbh=NyGa4r1+bImNigm46jnchOff0nnfDDvNZSJj3/0OlV0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PivBKoy3MgBrE7IT9sxt6f7K20yjI/t7yC463ET3TJB0mpAVLMDOFg3qIvAOLXBoK\n\t+71zk0PNczH2VkGhoSG9iV/EIjMmDt+gVP5T5xP5UDvR8UJd9VfBGtQwWRTZNBcFY5\n\tiW1MXzW3SgYTK0nIMfRcDAOkxmZsDDK15LHQTL70=","Date":"Thu, 4 Jul 2024 14:34:19 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, \n\tJacopo Mondi ,\n\tPaul Elder ","Subject":"Re: [PATCH v1 07/11] pipeline: rkisp1: Use the extensible parameters\n\tformat","Message-ID":"","References":"<20240703225230.3530-1-laurent.pinchart@ideasonboard.com>\n\t<20240703225230.3530-8-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240703225230.3530-8-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]