[{"id":30401,"web_url":"https://patchwork.libcamera.org/comment/30401/","msgid":"<863998f2-6c73-4a2f-84d2-ee5c8eb30397@ideasonboard.com>","date":"2024-07-13T16:08:38","subject":"Re: [PATCH v2 13/19] libcamera: software_isp: Call\n\tAlgorithm::process","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Milan\n\nOn 03/07/24 11:21 pm, Milan Zamazal wrote:\n> This patch adds Algorithm::process call for the defined algorithms.\n> This is preparation only since there are currently no Algorithm based\n> algorithms defined.\n>\n> As software ISP currently doesn't produce any metadata, a dummy and\n> unused metadata instance is created to satisfy Algorithm::process API.\n> This should be changed in future.\n>\n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Umang Jain \n> ---\n> src/ipa/simple/soft_simple.cpp | 13 ++++++++++++-\n> 1 file changed, 12 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\n> index f4a6bdf4..a8499f29 100644\n> --- a/src/ipa/simple/soft_simple.cpp\n> +++ b/src/ipa/simple/soft_simple.cpp\n> @@ -287,10 +287,21 @@ void IPASoftSimple::prepare(const uint32_t frame)\n> }\n> \n> void IPASoftSimple::processStats(\n> -\t[[maybe_unused]] const uint32_t frame,\n> +\tconst uint32_t frame,\n> \t[[maybe_unused]] const uint32_t bufferId,\n> \tconst ControlList &sensorControls)\n> {\n> +\tIPAFrameContext &frameContext = context_.frameContexts.get(frame);\n> +\t/*\n> +\t * Software ISP currently does not produce any metadata. Use an empty\n> +\t * ControlList for now.\n> +\t *\n> +\t * \\todo Implement proper metadata handling\n> +\t */\n> +\tControlList metadata(controls::controls);\n> +\tfor (auto const &algo : algorithms())\n> +\t\talgo->process(context_, frame, frameContext, stats_, metadata);\n> +\n> \tSwIspStats::Histogram histogram = stats_->yHistogram;\n> \tif (ignoreUpdates_ > 0)\n> \t\tblackLevel_.update(histogram);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC543BDB1C\n\tfor ;\n\tSat, 13 Jul 2024 16:08:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5E8B763372;\n\tSat, 13 Jul 2024 18:08:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CE0763369\n\tfor ;\n\tSat, 13 Jul 2024 18:08:43 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EAD17E4;\n\tSat, 13 Jul 2024 18:08:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"isYH3Yf2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720886888;\n\tbh=flQ4AhYey1hVgaCQp5s8HMWkGnNJ3aB6kVU/BdXHoCU=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=isYH3Yf2PJoH5rG2UCZuxPHR+AF0tWshoH4SjmbFkcnOT4mVmAyjuiI+l90+PaYKJ\n\t9669Pvi0sjI8DYVVzLEJdZRB5luCfRkhLgVr8kfUq8tvNi72WjRj9jm6KIDz1MFp3/\n\txiMqoalvxWbfryvci3i5PPQslH/k7JDv/ln0rDbE=","Message-ID":"<863998f2-6c73-4a2f-84d2-ee5c8eb30397@ideasonboard.com>","Date":"Sat, 13 Jul 2024 21:38:38 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 13/19] libcamera: software_isp: Call\n\tAlgorithm::process","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","References":"<20240703175119.1872585-1-mzamazal@redhat.com>\n\t<20240703175119.1872585-14-mzamazal@redhat.com>","Content-Language":"en-US","From":"Umang Jain ","In-Reply-To":"<20240703175119.1872585-14-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]